From patchwork Mon Dec 25 17:42:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 183226 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp492972dyb; Mon, 25 Dec 2023 09:42:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWW7q709hbDnBfmaUHZgXOtWr75F8H2M+zKMk9SlUv9RbFuYGQVl86A/ovmbIK7jXsL2b1 X-Received: by 2002:a05:6e02:19c6:b0:35f:f11b:c41e with SMTP id r6-20020a056e0219c600b0035ff11bc41emr7421802ill.1.1703526179763; Mon, 25 Dec 2023 09:42:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703526179; cv=none; d=google.com; s=arc-20160816; b=hdjiunhVWxZyRQLcczLDV9M4d8sb3LRBTDiGVMmJC1dGV8T+LdkYkX+fGxqqWH03nJ 4aW70xLry8VfqaIOlLNiYNOWWgksSOy5GNv94XRYtFLzMi1W55M7gq11p891RfvKpuZf lNj5CehMGoefW9HaVSW2ahPgZW7Xycnfao/lypp8wjog7xzpY88gSmhV5Y0yekOPsj5Q SFbmdakp9o4TllUOfaYWHSq0HoLQJQLbKqKFrR3eO1JwQayH9B/LXY0x5r7Zopx3JxGt r9xD7kdkIQOSw5jG6NpOjMWQMRJPOjqlLaGkIvpmyKo3ZqEUAm8eSz8zrNI92QMdNy1a 5l0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=jCNmKWsu0CzCXWmokXMMJ1bARHH/2ErBHLCDYhxE+nM=; fh=xQ7XBkV8Vfr1n1guxZ3RC0eNPkZJ/hSLNnxt7nNRj5I=; b=HTlwHFiK5JevQ/Q+MgJ+6JRJwmsPYSvssBwXTql4JeAypKZhLT6nBLX5JeQE1egqba U2jvl3eMwj15mUi6ka2YL1yA3PlGDItyvSjMpJJ1REom2c7DtMtRB71CqieuSlDVkveg rVlv9TcsaWmonYDrkrGKRKcQklNvs+jKNo6tMbCMs/INWG6JkfxpgrKpEiZi0K+UYZqM V/kDskMUshArnBH52mkS2bAj20jkJ2MVnOCg3KfptMfG/uf+q2FiFTHtMmDzTO8DvBxL hAN9kW2TbzUPGOo+1ttiZWQaUJ6+IzlkVWiIIow7KRUIqmnl3EQrUQFIVMyfeLhj1mS0 HkPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=GUGCLXGK; spf=pass (google.com: domain of linux-kernel+bounces-11132-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11132-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id x9-20020a654149000000b005c64505cbc2si8230572pgp.19.2023.12.25.09.42.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Dec 2023 09:42:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11132-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=GUGCLXGK; spf=pass (google.com: domain of linux-kernel+bounces-11132-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11132-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 885ED28234B for ; Mon, 25 Dec 2023 17:42:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3D71F537EF; Mon, 25 Dec 2023 17:42:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="GUGCLXGK" X-Original-To: linux-kernel@vger.kernel.org Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0280152F81; Mon, 25 Dec 2023 17:42:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703526136; x=1704130936; i=markus.elfring@web.de; bh=DN1DZ8Q4gr5JZBxx9y14h9ITgGHp31mL41Pkj2olJ1A=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=GUGCLXGK50GeUpvRJtg0JnwjPvlj9KjLdZ6hnHgCZ7nV6QgNCMmrcpzpwAQ70Ol7 qO5R2gtqkc1MNHYTdwh7d631z7rgPuH2OicMr6JTF90SXOG9dLzxaT/JfmECvkJ8n +0mXs/5ehrzdTNqomfoAgwGC75lvL2pKxtYdyxt7mokmr4xuIL79ohwQ3iIEyBYcD bv9ryRjlgYqFi+ShqU8vXjnryXZgF3Bx6RraD0a2Ac4H2IeSRg/WW2aeyVQuGTRS8 NH2qxhdbeSThfunmlodBXo4K3C1c1ULC1iqhOTD0sqeW4py2h7F6AG+MAk8RM+/dH xmVAZbuSnYkTz+9Ikw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N4eGT-1rAHrb34j9-011WsV; Mon, 25 Dec 2023 18:42:16 +0100 Message-ID: <8ecc9bd5-9001-4844-a3ea-f2b522a73cd3@web.de> Date: Mon, 25 Dec 2023 18:42:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 5/7] EDAC/amd64: Improve two size determinations in probe_one_instance() Content-Language: en-GB From: Markus Elfring To: linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org, Borislav Petkov , James Morse , Mauro Carvalho Chehab , Robert Richter , Tony Luck , Yazen Ghannam Cc: LKML , cocci@inria.fr, Muralidhara M K References: <8c9e2c01-9ed0-4392-af40-4e8eb393cb67@web.de> In-Reply-To: <8c9e2c01-9ed0-4392-af40-4e8eb393cb67@web.de> X-Provags-ID: V03:K1:2mmKeyB1681GDxQi1sKnPOxPX+IaW+IkMgtER2YiMnejmtGjbMk 3Ko4EESXm92JaHnCN2m0nvkIeD/9+qCD+PJ9jEuMQFRWqwRgx9ByNpHoyRtd04L46Zb3wRx 8tOs7YLcV+gQktydVjndK5GQX9qI3SopK+lN2So6YhhfQavedtD+5w3lBQZQlf5FXXlZ8JP y4KJGoSkRArEGQ/wJuD7w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:DHtw6zTu/ns=;qWnu/Dj6l7S/ReZRUeGYnZubsgz alUOx57ZHhmLeJNK3u+AxhyisQjpXkeYOr6Gk7Z571mItKHhBpGwrNi8hyJERGTCZOoo74tyn XxlyWNa2uBWxaYlboMZyHOZA3myfX7qOurv1LV4JKj9UeSClXSm762HBvIqzW03e0YRAwrPJo 9RO5Ds4F6U52TZ/tzrfojla58eW+qLPlwJy0FENYXfA14+nZefXeivvyAXhHtPkSRR6nje5Fq NKA7RSZaO+IZJJFIG/Q3NmB7g+t7kh7uWR2ENHwolyNC1Cj+3lymkqVd/PcLqptQScIHi3h8O ePASCHgyQHiTW9wH170nnayAtHFkUApWmPFfx1wAFnJOkbiBVjvjN3xlWmGJWe66EZuQ2Jlsn ytZcneh96QyDJr0OgSZFMjZcL0cJ+O2vGTcfSBXxzwQIucogVgAlJbTbr6i3KdGfMwdeAsc3m 0fO8qO7dR88x2fpB/VcxflEXabc3CLC+RtwTKpkR4/sPEWII1dlGxwIsh/A13oupumo2LNmVO t48TTbPeZISVqp9P8VcIpb7WsVeh/y0DCf4Jb2pAD5eOZvmZZfjXZgGHYSOv79Z8wZGSC/vyu tJgfBmMZHQdheZA3Txh5l681+c4OcDEGaKUI5eNRu5ShvlwCOD8cNSDJLyK6itGTkZdVgi6/W GyA46ziiIrgBci4qobkuYwcqOXVl1mhj1Lw1WMj3FgTfm/2v8MJLbCRIGu79Pljgoc9BK5dam JttUoHilFg6GBKKd4jvxqXP3OEMwX5xWP6EjpxwsQk/tTv2z5hj1lMWVhneS9kw97rdluJVf6 IHUQM4vSFqaqolLsxdf8niYTzHpbUIydjqkZZcrTRC6DjwaEauwFzkOxjft37bqSicfIqThyr qp6eK8wrRm8pNkINAZ5EutPoVfwQbJ71wXjOUQ2BXQkSv5LS/8NyAWA6V/5wkZrV6UyNSoiKu oI0Sky7sHiQiGaCKjaiv2bUrz1s= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786276667337795016 X-GMAIL-MSGID: 1786276667337795016 From: Markus Elfring Date: Mon, 25 Dec 2023 17:24:37 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator “sizeof” to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/edac/amd64_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.43.0 diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index 64680de47cab..7536236df542 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -4268,13 +4268,13 @@ static int probe_one_instance(unsigned int nid) struct ecc_settings *s; int ret; - s = kzalloc(sizeof(struct ecc_settings), GFP_KERNEL); + s = kzalloc(sizeof(*s), GFP_KERNEL); if (!s) return -ENOMEM; ecc_stngs[nid] = s; - pvt = kzalloc(sizeof(struct amd64_pvt), GFP_KERNEL); + pvt = kzalloc(sizeof(*pvt), GFP_KERNEL); if (!pvt) { ret = -ENOMEM; goto err_settings;