From patchwork Wed Dec 27 21:02:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183566 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1666233dyb; Wed, 27 Dec 2023 13:04:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFMXZk7X+e951hD4tBraqAzQFYztVGlY3Bn8AZr4yzeM90Wif5YLnTDG3FMIpzDlPNOsjje X-Received: by 2002:a05:6871:713:b0:1ff:a07:d38d with SMTP id f19-20020a056871071300b001ff0a07d38dmr8111148oap.69.1703711098320; Wed, 27 Dec 2023 13:04:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703711098; cv=none; d=google.com; s=arc-20160816; b=zWDuVuW8roObskodRPeSyGzZWrSf/iBm71sWI/JkX0mO/0oKovzu7in2hY7TuLozoE WRqGjxX9CrWr+ut/Sm0AVbkga2MJqAAI0JfSO2oBrTGbpxGed/JmyaSQPFJ6Jt2fNlRC j0CTVxJKU4iX0XSkS2vLh5H4BeX0FBklKxiKzoWgxA8DCPjxVWcLlv0pBjaRI7KuTRW0 1/I5bTN3gCxFCIDfSuwimNVzMUCH9urcJg4iESumpFZd4Ombs0vfIuyviAV8IiYYlJXE wvkGDkdiTwVdRpalOtStaHmVrnXvyYfcDes6ckE8ebk4AYKKjtSNZoVwVUnP1N7eUyGk IIDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=tlL3Dh011HE0Jn3vey6WuiazRgboLJN1ZCcIt5+gb4E=; fh=6/ZKSqeg6LPH8a8dy6NxIJTRxzc3seIO2jbSKXtyqd4=; b=XpEyTxAEswRktg4XBM5kVc7l2cNv6ha9RruuxSflKOgORUT8Dsgya7caSk5DOTJjwj zECmm/TkfGDdUir4uKzkvwc438Sd3d9Tn4Pc9boF5fcCEyivcpLtQYaEL3CZe+gdFbkc IR67QLE+gpWprTYSWrmmY554LkkYINStbFXoyJxTOZEa8uWYJlm0kEL/p18R55M+wxGN sEy5NGGkZucLmw7G7PmKtp5py2cS2xhDgBn25wj8601RRCX1HZl93jwUthf8ADr8PUjr xmRe1xVVTyjrmQ3+S39eJCl+b5PCarat8s3vWBbpOsr9yF269UHuqbF63T4UEImXvwjn nuww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12266-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12266-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id y11-20020a05610207cb00b00466f296b909si1009676vsg.656.2023.12.27.13.04.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 13:04:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12266-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12266-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12266-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AC69A1C20AB0 for ; Wed, 27 Dec 2023 21:04:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 12DB44A98F; Wed, 27 Dec 2023 21:03:06 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3525481B3 for ; Wed, 27 Dec 2023 21:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIb3L-0000t1-Me; Wed, 27 Dec 2023 22:02:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIb3K-001wFN-4t; Wed, 27 Dec 2023 22:02:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIb3L-001ZVw-0V; Wed, 27 Dec 2023 22:02:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jassi Brar Cc: Thierry Reding , Jonathan Hunter , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 11/12] mailbox: tegra-hsp: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 22:02:39 +0100 Message-ID: <8e00bbc23e1115d9ff185d4b98c6d764607036df.1703710628.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1705; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=PYLOV0x2mjDrqYc2WOt4MZWPAGaq8meNv350E++Xqz4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljJDxKf9dkG1I03uOMN9mSF6cbRm7XcpAFwVg0 hQObdda4w2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYyQ8QAKCRCPgPtYfRL+ ToRJB/9LAqLeEDXl6LyRgrBJMUDfPV5gfr4iqzE2TfwlmQtMY9VVZgSzBclmKAp67Bbm/0T/UDQ WQhJApBRY3tDJ6nbdJRiM+X2RqemRskrEpDlrgs8TeSBp+kSzc1D2Vt6mGNLc1z/r/gZrbTFt1o vBbYu411RH9zW7g92zneQxlLLwATK7Pd6poTrBDIWJr8hKPxA/zut4gUqsqzrnID55PyUzK8rn5 huukRLE4HTpWVspSJFxgep0Gz2FiTTPsJt4i9c/NhPq1txhd50cf++t/+yDYPPq9TtoNAE9zbER ey/05V7M2b7TcaR1mlbT1iDSAlnr97gMhjSr9UTe7LvbM0Zz X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786470568679220231 X-GMAIL-MSGID: 1786470568679220231 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mailbox/tegra-hsp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c index fe29fc2ca526..19ef56cbcfd3 100644 --- a/drivers/mailbox/tegra-hsp.c +++ b/drivers/mailbox/tegra-hsp.c @@ -868,13 +868,11 @@ static int tegra_hsp_probe(struct platform_device *pdev) return 0; } -static int tegra_hsp_remove(struct platform_device *pdev) +static void tegra_hsp_remove(struct platform_device *pdev) { struct tegra_hsp *hsp = platform_get_drvdata(pdev); lockdep_unregister_key(&hsp->lock_key); - - return 0; } static int __maybe_unused tegra_hsp_resume(struct device *dev) @@ -953,7 +951,7 @@ static struct platform_driver tegra_hsp_driver = { .pm = &tegra_hsp_pm_ops, }, .probe = tegra_hsp_probe, - .remove = tegra_hsp_remove, + .remove_new = tegra_hsp_remove, }; static int __init tegra_hsp_init(void)