From patchwork Wed Feb 7 18:40:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 198040 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp2433733dyb; Wed, 7 Feb 2024 10:45:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfHzjw86qRB/U9PH0ACOuvNbxBLEBT3LipsDPYr/YX0HNRjRRWWH/ImHza1g27R4bFS4F2 X-Received: by 2002:a05:6359:4c12:b0:176:2bb2:12bb with SMTP id kj18-20020a0563594c1200b001762bb212bbmr4375075rwc.1.1707331557627; Wed, 07 Feb 2024 10:45:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707331557; cv=pass; d=google.com; s=arc-20160816; b=rM28vicwNPwKdtHxBJYbgv97gKnZyZvw77nBra0fLwZm+isXpI6NoIy9vq+uUCtKvS KRotn6YWsOu0UgUlZ3lSqteTwpZtcUCwRQKw9tUbtUEM09xKtXkAC8zVRjHsI6iOI/a3 rWezZL4KE4EjMoInpHwP2SIjqa3oGVWAKzZy0IvXct+J4dH1tj+2obP4tl/y+IWpsaYd IWri/didRTRkxRMlFnVeXeKbZ+uQaaXIWbeLbpHALYU0kWp86rnAbFK1iNH0Y2yO4Bev unMJlPF1W9OlJyHWLMYufgB3dQUO7NGRrF32DJ9UdPVGSaVUuyhLwo0Ci1OiUlNXwnQ3 c0+w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Sv0Q/6xqUm20oYbgW8JmB5NjAGSwMosI/S1EaCMQFJE=; fh=XbsmwN7QnxjQm8Zz6/GllULnQWt2y6XIwEUM5gzGVV0=; b=SdCJOKh9Yt8A6PzJlziTebo3EkzH8w5tBLB1tT1owxG/bPjI0n8wX8yxMN+27cjjNI pa76LloUJ2OGnzlLV3xX9OfNxghQy4F1QhOSFulfzaJTfNgiylMaWNlOPfajuOZAgxgL /hN5ELUxdnL2iE215FlJn8TfccRVIDXWK9sfzASvzy2pmHkdXAjGih7KTdp6NdzVNs62 kTFBC8mql28XkEVcDaHq1t6qsbaXFfR8pOFKKtcsNlj5KQp4FftkejoWFFMEfhMExOh8 aApyFNJD7HDvRKpqC15rHjZ11L4HUh2Kj3JnbTkNQCSPoas1QOm7Zx893Hvp9Hzy22Bh T5tA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-56924-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56924-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCUSEaTfuyBRDfXIHVg1kNFbNbIOb+rugCKzEOr0Tz0dXrPNqhWfnwPjwLcvnPrkfnl0pKtDHxMVXilXE5zJ0y095Yy8Rw== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s12-20020a63770c000000b005d54ef5dd07si2179349pgc.161.2024.02.07.10.45.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 10:45:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56924-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-56924-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56924-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 80CAB288FE1 for ; Wed, 7 Feb 2024 18:45:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BB4BC1292E3; Wed, 7 Feb 2024 18:43:25 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F209585281 for ; Wed, 7 Feb 2024 18:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707331400; cv=none; b=sfqZDgu02quTZaf1OgbqWuA86lRak40Tn8eITKp0Rem6oeXPanDsfqcsLdCBW9IEhdWNrdDt7iM+dG7GNFy6NfV8pnOyiy+TZlbo0b/rlZDs3ZmhRCZ4uHMABEshxFZYUU3plNLdjKCmYHzDyTqEOHuViRHU8K+x91IhUlYGi+4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707331400; c=relaxed/simple; bh=JgBVUlN1d7qYFnm0ZKVPd582aguOzqNX2Ijr5H69uZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L9UchSFyh4UGl5bKnqaIZNYbmTJWlQ7If27OYgGZkvtrSzdPIDkBQNvbVNWXNcKKxnBY8fXYFJj8bPY6uOpIBwZpBMKL50CMXTXaUpTiiW7Oh/Z0HX8IdAoW5/Ws4VjMLH3kdnN+CGQg07HN32PD3AgAWdTJZc4B4mpKUHm/maE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rXmt7-0007iL-Hm; Wed, 07 Feb 2024 19:43:13 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rXmt7-0054Xq-1P; Wed, 07 Feb 2024 19:43:13 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rXmt6-00HRss-36; Wed, 07 Feb 2024 19:43:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mark Brown Cc: kernel@pengutronix.de, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron Subject: [PATCH v3 17/32] spi: cadence-quadspi: Don't emit error message on allocation error Date: Wed, 7 Feb 2024 19:40:31 +0100 Message-ID: <8da90785395664bf17d16428f46e84b95ef5cc3b.1707324794.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=977; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=JgBVUlN1d7qYFnm0ZKVPd582aguOzqNX2Ijr5H69uZY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlw86pp9uzxmuDyQ0mFGdNd2DpAvbKt7gfjHNv9 bKDArohENOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZcPOqQAKCRCPgPtYfRL+ TuIlB/9IqxAwKlOkz/l+TR7Hb1usnQ7iK++5ehWAYDu/QUDiAb0Yl6oDxx1gkrkZoMLbBbVL8ZZ HZ2aSBvGj/+pdWAEzqQiRLKWaOnlmljb9ZUigfxDM6ncvtG30HQ7kiQ1qizjLR+4diCVKZsR1Md fGAfxverac0tyFjzbeCouufNq/jVaDgEvLMpgp19kIz4IMGODU8wcTHr+/wWD9HbzZLeVo8LNYx EeQdKkrVAkOdnpay8fJ9nfaZAFUySgRpBRETYDKjauJ8Vtc7d0ifrcVHE2/auIeHfeC1kMcGFeX 5nJz+ea84Omsw9yoUs5bwsTeEzWUHJG0NLjokzF7tUN2MARp X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790266895399403384 X-GMAIL-MSGID: 1790266895399403384 Drivers are not supposed to emit an error message when a memory allocation fails, as the kernel is very loud in this case already anyhow. Acked-by: Jonathan Cameron Signed-off-by: Uwe Kleine-König --- drivers/spi/spi-cadence-quadspi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c index f94e0d370d46..eb6cc861b00b 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -1712,10 +1712,9 @@ static int cqspi_probe(struct platform_device *pdev) int irq; host = devm_spi_alloc_host(&pdev->dev, sizeof(*cqspi)); - if (!host) { - dev_err(&pdev->dev, "devm_spi_alloc_host failed\n"); + if (!host) return -ENOMEM; - } + host->mode_bits = SPI_RX_QUAD | SPI_RX_DUAL; host->mem_ops = &cqspi_mem_ops; host->mem_caps = &cqspi_mem_caps;