Message ID | 8d870bdc59dd5e2754542388a03095ea09c96297.1694767209.git.geert+renesas@glider.be |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp913652vqi; Fri, 15 Sep 2023 02:23:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH45nduuWF0ZkTngie/T108qc3gN4CYShsWMlRm7EBOI+ATn3ysxY1SRy7a9z4srMWEVpE2 X-Received: by 2002:a05:6808:6:b0:3a7:6d64:aa68 with SMTP id u6-20020a056808000600b003a76d64aa68mr1180329oic.18.1694769834942; Fri, 15 Sep 2023 02:23:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694769834; cv=none; d=google.com; s=arc-20160816; b=Lv8j76tliPsG7epeQ9PAb4EQ4RVaCfQkEsdawHtLLZA8FVND+rj96P0D8SpQ/d9D5S eevJOYiwOqYXPAw4s3wkdHxrLPDBzU/SSqwDez/MEOl+DLL3SfJ+urBlASQrYIlF5Tp2 NmANRSfRU2019kKJKYN63BLTAyBjSRyytlbNLxGcSoV9jWBw40LqorJ/C2HP+kncPijF o3uQgBXAmfwhxRiuUDmCGxr/UN3ETkJxeZ4Dyhooxl2i20c/ucAQgWNkjlSDbddFJrpB 4uGNuveoXl2e2l9hc+TzLCpMZr5H91SXI4pfQhedgUXMAcMIhED2xsIZzRHTBQo/J3KB mAzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=hhLEbAXNFl4ODDHSW/d/S+L2YUwaiWGyMen3mVmuGwI=; fh=KH8HnsdO2yip8Q9uuYy0FWJVbOcjQeNq7C+3VKM5Hzg=; b=mGh7OCG5r9OeHmEFrECsLOSJa3HX5aJGO3s8JE86HIYEIcdC6oZ1mvpRdVQdTs9ONm 9PEHZs1z84SsZbKyaqj3msxXwXiaXfJB5Sxvkk+Yjucgl1l45N9yyx6rkrecWvB6vodS AkqCigdcAmWyH8wkTJBGsLNau5r7a3vBtlTWin8i+rdSY6r4uNQpPc1zzQ9m0VlaYsPw cgXdhJ4o1/yGixK9myRQ/VqY1Of7vnuVSWJeUh4LglSndFOkWxi7nrw62lYsv5U++rYs KvJX0d5p6hOTBnv80M1vT9yRqgMF+94E5H/5TAN6LgjPZAbZQsXHNBVkyfsKEPIZXhIk 0C9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id l62-20020a638841000000b0056c2f508898si2913921pgd.725.2023.09.15.02.23.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 02:23:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 2981C8325D05; Fri, 15 Sep 2023 01:55:03 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233489AbjIOIy6 (ORCPT <rfc822;ruipengqi7@gmail.com> + 32 others); Fri, 15 Sep 2023 04:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233268AbjIOIy1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 15 Sep 2023 04:54:27 -0400 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [IPv6:2a02:1800:110:4::f00:19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C57FE273F for <linux-kernel@vger.kernel.org>; Fri, 15 Sep 2023 01:54:17 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:7135:da8b:ba1d:1a7c]) by laurent.telenet-ops.be with bizsmtp id m8uE2A00N3q21w7018uEgL; Fri, 15 Sep 2023 10:54:15 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qh4aJ-003lGw-JI; Fri, 15 Sep 2023 10:54:14 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qh4ac-00Gdby-J2; Fri, 15 Sep 2023 10:54:14 +0200 From: Geert Uytterhoeven <geert+renesas@glider.be> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Thomas Zimmermann <tzimmermann@suse.de>, Magnus Damm <magnus.damm@gmail.com> Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Subject: [PATCH v4 17/41] drm: renesas: shmobile: Convert to use devm_request_irq() Date: Fri, 15 Sep 2023 10:53:32 +0200 Message-Id: <8d870bdc59dd5e2754542388a03095ea09c96297.1694767209.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: <cover.1694767208.git.geert+renesas@glider.be> References: <cover.1694767208.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 15 Sep 2023 01:55:03 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777094974416688109 X-GMAIL-MSGID: 1777094974416688109 |
Series |
drm: renesas: shmobile: Atomic conversion + DT support
|
|
Commit Message
Geert Uytterhoeven
Sept. 15, 2023, 8:53 a.m. UTC
Convert to managed IRQ handling, to simplify cleanup. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- v4: - No changes, v3: - No changes, v2: - Add Reviewed-by. --- drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c index 399fedd42271cb49..bf3a9c1db177095e 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c @@ -196,7 +196,6 @@ static void shmob_drm_remove(struct platform_device *pdev) drm_dev_unregister(ddev); drm_kms_helper_poll_fini(ddev); - free_irq(sdev->irq, ddev); drm_dev_put(ddev); } @@ -277,8 +276,8 @@ static int shmob_drm_probe(struct platform_device *pdev) goto err_modeset_cleanup; sdev->irq = ret; - ret = request_irq(sdev->irq, shmob_drm_irq, 0, ddev->driver->name, - ddev); + ret = devm_request_irq(&pdev->dev, sdev->irq, shmob_drm_irq, 0, + ddev->driver->name, ddev); if (ret < 0) { dev_err(&pdev->dev, "failed to install IRQ handler\n"); goto err_modeset_cleanup; @@ -290,14 +289,12 @@ static int shmob_drm_probe(struct platform_device *pdev) */ ret = drm_dev_register(ddev, 0); if (ret < 0) - goto err_irq_uninstall; + goto err_modeset_cleanup; drm_fbdev_generic_setup(ddev, 16); return 0; -err_irq_uninstall: - free_irq(sdev->irq, ddev); err_modeset_cleanup: drm_kms_helper_poll_fini(ddev); err_free_drm_dev: