| Message ID | 8c8a126a83683bae69d0fd20a93bdea8f810f6d0.1675792435.git.philipp.g.hortmann@gmail.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7300:2388:b0:96:219d:e725 with SMTP id i8csp4220448dyf;
Tue, 7 Feb 2023 10:18:20 -0800 (PST)
X-Google-Smtp-Source:
AK7set/j/qXyd0PqZV2brZdnYyIWVXyb9agVAS236VfNbMujAYlzdyjHykhqMq345RTQfCo9vm2+
X-Received: by 2002:aa7:94ad:0:b0:590:74f1:8c8a with SMTP id
a13-20020aa794ad000000b0059074f18c8amr3674208pfl.15.1675793900122;
Tue, 07 Feb 2023 10:18:20 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1675793900; cv=none;
d=google.com; s=arc-20160816;
b=bAqPN7QsaQZzM1MPJGEbpu9VBMKrvd59CdEdpTwtgIntSL6065o5YTmdxQUPMdOO73
TPF0rkPXQNR2LaK+0MRXJLUspAWA4mb9Dz1KLqtBB/Hz6tXKgnJTQf3PW5A/8WhIKtLq
j3aNWgNaNUNca7N++bomSyoGSe1Wk04e23FBeKbbq0abwoVJcsdfz/V3gNLmr+U7KzFb
79vpVffNInpZ4FjOL05fDPcudM20YgNeTOv2OkzH5+u9qFSEQYwnsqnIDk/Hfrm3Ngbh
SWVjn2Hza+Klc3zN904YUBwW5kc6kKeReWcncB0VmztEq13c5o/pdLNa0I9CfPthKor9
tzfg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:in-reply-to:content-disposition:mime-version
:references:message-id:subject:to:from:date:dkim-signature;
bh=U3O/aD4Uv2cETSrvPLtPnBPSmR1X5PU3SN0FZx5rCJs=;
b=ZvnxBogOzYHWZMlyeN5EwdpvAU0SgJlU6uchtJbPDigpiNuIrT/WjiJcSiJQzsFWPC
IG/FD2SRZjRubqmIMgwgXDxkosDqubVzgcD54Cr0PyvxHpCCdqngRZQCAO//gSp05dPB
NiUpiFuk5M87drxeE+eRNoqL3QhftEP+rQ9/HV/BxbzUSdOKdSGnICpnSqq03Hvt/6xt
ESk8uZGfEA8iAGMvOkBQCXr51DnOoLIptuPo3f21W/dI2L8R6cUYmRzban2CfCjSN2oy
7so+TCYSb3IFhuWdTD7QY9II54Oe1X7MxgxtBYUDVjOrct5kHsfQ34g7mWBc6qTQ01Ur
MItQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@gmail.com header.s=20210112 header.b=H46iivmu;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
q9-20020aa78429000000b0058286279c89si15950734pfn.309.2023.02.07.10.18.05;
Tue, 07 Feb 2023 10:18:20 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gmail.com header.s=20210112 header.b=H46iivmu;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232088AbjBGSQt (ORCPT <rfc822;kmanaouilinux@gmail.com>
+ 99 others); Tue, 7 Feb 2023 13:16:49 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40550 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S232110AbjBGSQg (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 7 Feb 2023 13:16:36 -0500
Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com
[IPv6:2a00:1450:4864:20::431])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2307F3E601
for <linux-kernel@vger.kernel.org>;
Tue, 7 Feb 2023 10:16:26 -0800 (PST)
Received: by mail-wr1-x431.google.com with SMTP id y1so14455292wru.2
for <linux-kernel@vger.kernel.org>;
Tue, 07 Feb 2023 10:16:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=in-reply-to:content-disposition:mime-version:references:message-id
:subject:to:from:date:from:to:cc:subject:date:message-id:reply-to;
bh=U3O/aD4Uv2cETSrvPLtPnBPSmR1X5PU3SN0FZx5rCJs=;
b=H46iivmubbNG5bbuSnlVhfSauQ6dL6uQj6DuSUlCCkjOa6nqUuc3TxnMT1KCzkg21N
q6QcwCmLYTC3L+s3U24GTq1ONcqZkrrYLB7r9x7e18VE9/wkK4SFrQLkxyrW+Qhvbqlg
3i+CV48cGSDhlzw1GuWlVEd7xnRqKf7bo55Idy8MoZUZ+SRvz9MbuPlseRS3XaxQbi2I
0t4YTNqqLVJyHEKfTyihlwORxT41Qp8Q1Ai7Oq8gtsmh7448nw8lBuZuE1jetCJLwGbK
Baz13ZcPVl6plyBYW0+NTSPgpb6Kf3lNj6j745eUHuMQJPwVY+zlT53ecpb+0ZryJbxY
jMSg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=in-reply-to:content-disposition:mime-version:references:message-id
:subject:to:from:date:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=U3O/aD4Uv2cETSrvPLtPnBPSmR1X5PU3SN0FZx5rCJs=;
b=eZQRHQsYlHXtUh7L2Io3rPmne+wWN6KeK2OzpZtmH5GlVIkw+NS9p0n3DDYh/AoJAP
zcjanahplW5g5Xnf9/zXl90eiuVFNpnXz9ZWHCVbWt/U/PXJfHv0vADeQhKWIVb19aAU
yU8l6S9wjWIJP5u+RGUiW+c55iCoTm8DKkLEXwmU+7WQ8KNtjCTK1vofQ+nW2lCl6yRf
OUBvsJaCs3jUHrZGxUCsoiU3nKeb59HQbT/7xHUraOTarIx8/DFvIMEKZUN1QYhqBG1Y
soLbgteYiSVifGO1Z99LHwfO7CTEgVwI98zxRaNM+gVnq2Tw+q0dHgPl79XXt8uaLRYB
ErGg==
X-Gm-Message-State: AO0yUKUW9VrPaRgdO46/20iqP1XOza1Cr9b85W70XoilsTcuMM0GB0gN
Y2Qnn8SICijfBf036X7eNbo=
X-Received: by 2002:a05:6000:12cb:b0:2bf:e46c:8b89 with SMTP id
l11-20020a05600012cb00b002bfe46c8b89mr2738630wrx.4.1675793784708;
Tue, 07 Feb 2023 10:16:24 -0800 (PST)
Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de.
[87.147.81.70])
by smtp.gmail.com with ESMTPSA id
e20-20020a5d5954000000b002bfd524255esm12073035wri.43.2023.02.07.10.16.23
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 07 Feb 2023 10:16:24 -0800 (PST)
Date: Tue, 7 Feb 2023 19:16:22 +0100
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 02/10] staging: rtl8192e: Calculate definition of
MSR_LINK_MASK
Message-ID:
<8c8a126a83683bae69d0fd20a93bdea8f810f6d0.1675792435.git.philipp.g.hortmann@gmail.com>
References: <cover.1675792435.git.philipp.g.hortmann@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1675792435.git.philipp.g.hortmann@gmail.com>
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1757197265029637460?=
X-GMAIL-MSGID: =?utf-8?q?1757197265029637460?=
|
| Series |
staging: rtl8192e: Rename constants and variables from rtl_dm.h
|
|
Commit Message
Philipp Hortmann
Feb. 7, 2023, 6:16 p.m. UTC
Calculate definition of MSR_LINK_MASK ((1<<0)|(1<<1)) = 3. Equation is not
accepted by checkpatch because of missing spaces.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Tue, Feb 07, 2023 at 07:16:22PM +0100, Philipp Hortmann wrote: > Calculate definition of MSR_LINK_MASK ((1<<0)|(1<<1)) = 3. Equation is not > accepted by checkpatch because of missing spaces. > > Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h > index 1546bb575293..20a35c9caee8 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h > @@ -170,7 +170,7 @@ enum _RTL8192PCI_HW { > #define BW_OPMODE_20MHZ BIT2 > IC_VERRSION = 0x301, > MSR = 0x303, > -#define MSR_LINK_MASK ((1<<0)|(1<<1)) > +#define MSR_LINK_MASK 3 This is a bit field, it should be: #define MSR_LINK_MASK (BIT(1) | BIT(0)) right? thanks, greg k-h
On Wed, 2023-02-08 at 13:31 +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 07, 2023 at 07:16:22PM +0100, Philipp Hortmann wrote: > > Calculate definition of MSR_LINK_MASK ((1<<0)|(1<<1)) = 3. Equation is not > > accepted by checkpatch because of missing spaces. [] > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h [] > > @@ -170,7 +170,7 @@ enum _RTL8192PCI_HW { > > #define BW_OPMODE_20MHZ BIT2 > > IC_VERRSION = 0x301, > > MSR = 0x303, > > -#define MSR_LINK_MASK ((1<<0)|(1<<1)) > > +#define MSR_LINK_MASK 3 > > This is a bit field, it should be: > #define MSR_LINK_MASK (BIT(1) | BIT(0)) > right? Perhaps better as GENMASK(1, 0)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h index 1546bb575293..20a35c9caee8 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h @@ -170,7 +170,7 @@ enum _RTL8192PCI_HW { #define BW_OPMODE_20MHZ BIT2 IC_VERRSION = 0x301, MSR = 0x303, -#define MSR_LINK_MASK ((1<<0)|(1<<1)) +#define MSR_LINK_MASK 3 #define MSR_LINK_MANAGED 2 #define MSR_LINK_ADHOC 1 #define MSR_LINK_MASTER 3