[v2] scsi: mpi3mr: Fix the type used for pointers to bitmap
Commit Message
Bitmaps are "unsigned long[]", so better use "unsigned long *" instead of
a plain "void *" when dealing with pointers to bitmaps.
This is more informative.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
v2: Fix some other declaration
---
drivers/scsi/mpi3mr/mpi3mr.h | 8 ++++----
drivers/scsi/mpi3mr/mpi3mr_fw.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
Comments
Christophe,
> Bitmaps are "unsigned long[]", so better use "unsigned long *" instead
> of a plain "void *" when dealing with pointers to bitmaps.
Applied to 6.5/scsi-staging, thanks!
On Sun, 07 May 2023 17:23:49 +0200, Christophe JAILLET wrote:
> Bitmaps are "unsigned long[]", so better use "unsigned long *" instead of
> a plain "void *" when dealing with pointers to bitmaps.
>
> This is more informative.
>
>
Applied to 6.5/scsi-queue, thanks!
[1/1] scsi: mpi3mr: Fix the type used for pointers to bitmap
https://git.kernel.org/mkp/scsi/c/144679dfb584
@@ -1133,18 +1133,18 @@ struct mpi3mr_ioc {
u32 chain_buf_count;
struct dma_pool *chain_buf_pool;
struct chain_element *chain_sgl_list;
- void *chain_bitmap;
+ unsigned long *chain_bitmap;
spinlock_t chain_buf_lock;
struct mpi3mr_drv_cmd bsg_cmds;
struct mpi3mr_drv_cmd host_tm_cmds;
struct mpi3mr_drv_cmd dev_rmhs_cmds[MPI3MR_NUM_DEVRMCMD];
struct mpi3mr_drv_cmd evtack_cmds[MPI3MR_NUM_EVTACKCMD];
- void *devrem_bitmap;
+ unsigned long *devrem_bitmap;
u16 dev_handle_bitmap_bits;
- void *removepend_bitmap;
+ unsigned long *removepend_bitmap;
struct list_head delayed_rmhs_list;
- void *evtack_cmds_bitmap;
+ unsigned long *evtack_cmds_bitmap;
struct list_head delayed_evtack_cmds_list;
u32 ts_update_counter;
@@ -1134,7 +1134,7 @@ static int mpi3mr_issue_and_process_mur(struct mpi3mr_ioc *mrioc,
static int
mpi3mr_revalidate_factsdata(struct mpi3mr_ioc *mrioc)
{
- void *removepend_bitmap;
+ unsigned long *removepend_bitmap;
if (mrioc->facts.reply_sz > mrioc->reply_sz) {
ioc_err(mrioc,