Message ID | 8894bf2c44eaf4959c7a1966b66229e6cf5cda96.1683183860.git.quic_varada@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp238068vqo; Fri, 5 May 2023 01:29:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6E/mOBzgBx6xtA82Li1OEuwKZv1sSBozx62W/BtMLOAAjVttnfB5ie1eFSoMok0g6lnk4D X-Received: by 2002:a17:903:24e:b0:1a8:431:9e14 with SMTP id j14-20020a170903024e00b001a804319e14mr678044plh.25.1683275343909; Fri, 05 May 2023 01:29:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683275343; cv=none; d=google.com; s=arc-20160816; b=i2tROaJKt39VmmMw5qnU+xtUcQGWvlzbN08j6PK6wCCjADGbvqCPcyH1dq6xuOpzaI 43i9+MPzkfxFxulVDb+jDuVySGrbS5vjQv5vZeKqu3icwEWIy/6QDI0cVyW9AegHOiex cojZqWohWnPeZG8SLESO/t2vQSOj5QgI651plcDo7H1DM0x2Cmzf04d58dP95hauYat+ 2j6aW9QEdd8WTgFHfmzC+dZLZPuRiE1pPmla/ipqaYsNVzDq0OILVPn5DkUd7BY6pDVS /HiM9nkQbdBz4Ih2tIN3+0QCrySpEnXhaZTFP5asdH7nyHyi4dgiY2aSorAv2JIkMH63 i22Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=WZtO0HqANQYzG7rjKke7I95LJ7e1euJQtwGimPfnjXM=; b=g4c9rug1GirrnTfIZNtYsT80IfELRBm+iRA3HAqRIR+gpcsQUlQITkKGIVML5QJkB1 vePsigbwh1elsESl56/RlLAY9hNSPVvtx9GJ8BMNN2oEv1B06egnpQtbC0WaHB+HkmzI eYuJnyRO7ZV7m/gRqCtx6Hu0OHJAgkvot6LtOVtlH7HP8fzqnebmTYm73EEDo/umN/Fs 1W9iRN21zwVxCUC3oDBlT7TlsltxcAfyjVON0ryJkFiGVDg39xO/AT4kD+ArV9jAgOVw 5LtRhm9J+LlIIyi0cpB9cYKauB5tOu5zDnfX5PRbeVYOTP1G0pwMO/51AXmoxbePOmVg g5AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=lSa8tsuR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s6-20020a170902b18600b001a531f29044si1094012plr.521.2023.05.05.01.28.48; Fri, 05 May 2023 01:29:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=lSa8tsuR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231395AbjEEIXc (ORCPT <rfc822;b08248@gmail.com> + 99 others); Fri, 5 May 2023 04:23:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231384AbjEEIXN (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 5 May 2023 04:23:13 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDB751893A; Fri, 5 May 2023 01:22:55 -0700 (PDT) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3457quNV027492; Fri, 5 May 2023 08:22:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=WZtO0HqANQYzG7rjKke7I95LJ7e1euJQtwGimPfnjXM=; b=lSa8tsuRIkesTK4+67xE6VQ38GhR56fzrSBGYIUAGV/6Egt1/EPJ0fGlyUVp0rkW8H6M yvplfAp3I4X7+gJBs3BlRupAU8F5SRpdTfkqwbaPPDU1XYs+2jBTbRPfy/QGq1GWDAH1 8GOOCrhB14uNbTOPnIiYaUXLTnA6cvX6m1/WsbqDmspaO+sDd3BZTqbQQZCnEM+YgP4/ RjQmXNqgHq6vWIio4dk1wAHDfWV8GSnaN2s9OLRRvcIfVlZFdAiB72eXiJO6lowS4ipF UCh/uzhWMgUasOU8FvTBcqI2CNLjQSdL6EOvl4LfwjKOqcD5qA215Z+UlRz000vUNdo0 lw== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qckf714vn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 05 May 2023 08:22:50 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3458Mn8S016460 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 5 May 2023 08:22:49 GMT Received: from varda-linux.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 5 May 2023 01:22:44 -0700 From: Varadarajan Narayanan <quic_varada@quicinc.com> To: <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <vkoul@kernel.org>, <kishon@kernel.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>, <mturquette@baylibre.com>, <sboyd@kernel.org>, <quic_wcheng@quicinc.com>, <linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>, <linux-clk@vger.kernel.org> CC: Varadarajan Narayanan <quic_varada@quicinc.com> Subject: [PATCH v10 8/9] arm64: dts: qcom: ipq9574: Add LDO regulator node Date: Fri, 5 May 2023 13:05:09 +0530 Message-ID: <8894bf2c44eaf4959c7a1966b66229e6cf5cda96.1683183860.git.quic_varada@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <cover.1683183860.git.quic_varada@quicinc.com> References: <cover.1683183860.git.quic_varada@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: wxr9xcnmWvKmX3mjpxUMBVK4BlGVJUG4 X-Proofpoint-ORIG-GUID: wxr9xcnmWvKmX3mjpxUMBVK4BlGVJUG4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-04_15,2023-05-04_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 bulkscore=0 phishscore=0 adultscore=0 malwarescore=0 mlxlogscore=776 suspectscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305050069 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765042127199248938?= X-GMAIL-MSGID: =?utf-8?q?1765042127199248938?= |
Series |
Enable IPQ9754 USB
|
|
Commit Message
Varadarajan Narayanan
May 5, 2023, 7:35 a.m. UTC
Add LDO regulator node
Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
Changes in v10:
- Add LDO regulator node
---
arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++
1 file changed, 7 insertions(+)
Comments
On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > Add LDO regulator node As this LDO is provided by the PMIC, it would be nice to know why it is modelled as an always-on regulator instead of the proper PMIC regulator. Up to now we were doing this only for the outstanding power rails like CX/MX or EBI. > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > Changes in v10: > - Add LDO regulator node > --- > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > index bdc1434..1f5d14f 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > @@ -60,6 +60,13 @@ > regulator-min-microvolt = <725000>; > regulator-max-microvolt = <1075000>; > }; > + > + mp5496_l2: l2 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > }; > }; > > -- > 2.7.4 >
On 5.05.2023 11:29, Dmitry Baryshkov wrote: > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan > <quic_varada@quicinc.com> wrote: >> >> Add LDO regulator node > > As this LDO is provided by the PMIC, it would be nice to know why it > is modelled as an always-on regulator instead of the proper PMIC > regulator. Up to now we were doing this only for the outstanding power > rails like CX/MX or EBI. (which we then stopped registering as regulators and started to manage through rpm(h)pd drivers and the genpd framework) Konrad > >> >> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> >> --- >> Changes in v10: >> - Add LDO regulator node >> --- >> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> index bdc1434..1f5d14f 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> @@ -60,6 +60,13 @@ >> regulator-min-microvolt = <725000>; >> regulator-max-microvolt = <1075000>; >> }; >> + >> + mp5496_l2: l2 { >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> }; >> }; >> >> -- >> 2.7.4 >> > >
On Fri, 5 May 2023 at 22:26, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > On 5.05.2023 11:29, Dmitry Baryshkov wrote: > > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan > > <quic_varada@quicinc.com> wrote: > >> > >> Add LDO regulator node > > > > As this LDO is provided by the PMIC, it would be nice to know why it > > is modelled as an always-on regulator instead of the proper PMIC > > regulator. Up to now we were doing this only for the outstanding power > > rails like CX/MX or EBI. > (which we then stopped registering as regulators and started > to manage through rpm(h)pd drivers and the genpd framework) I mean having regulator-fixed s4a on sm8250 in addition to the CX genpd, because some of the parts really expect to have a regulator. But anyway, we are getting away from the subj. Let's wait for the answer from Varadarajan. > > Konrad > > > >> > >> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > >> --- > >> Changes in v10: > >> - Add LDO regulator node > >> --- > >> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > >> index bdc1434..1f5d14f 100644 > >> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > >> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > >> @@ -60,6 +60,13 @@ > >> regulator-min-microvolt = <725000>; > >> regulator-max-microvolt = <1075000>; > >> }; > >> + > >> + mp5496_l2: l2 { > >> + regulator-min-microvolt = <1800000>; > >> + regulator-max-microvolt = <1800000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> }; > >> };
On Fri, May 05, 2023 at 12:29:54PM +0300, Dmitry Baryshkov wrote: > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan > <quic_varada@quicinc.com> wrote: > > > > Add LDO regulator node > > As this LDO is provided by the PMIC, it would be nice to know why it > is modelled as an always-on regulator instead of the proper PMIC > regulator. Up to now we were doing this only for the outstanding power > rails like CX/MX or EBI. These are always ON because USB phy doesn't support power collapse, and there is a chance that other IP blocks might be sharing the rail. Thanks Varada > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Changes in v10: > > - Add LDO regulator node > > --- > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > index bdc1434..1f5d14f 100644 > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > @@ -60,6 +60,13 @@ > > regulator-min-microvolt = <725000>; > > regulator-max-microvolt = <1075000>; > > }; > > + > > + mp5496_l2: l2 { > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > }; > > }; > > > > -- > > 2.7.4 > > > > > -- > With best wishes > Dmitry
On Sat, 6 May 2023 at 14:09, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > On Fri, May 05, 2023 at 12:29:54PM +0300, Dmitry Baryshkov wrote: > > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan > > <quic_varada@quicinc.com> wrote: > > > > > > Add LDO regulator node > > > > As this LDO is provided by the PMIC, it would be nice to know why it > > is modelled as an always-on regulator instead of the proper PMIC > > regulator. Up to now we were doing this only for the outstanding power > > rails like CX/MX or EBI. > > These are always ON because USB phy doesn't support power > collapse, and there is a chance that other IP blocks might be > sharing the rail. You are describing the software side here. From the hardware point of view, it is an I2C regulator, which is probably also exported as an SMD_RPM regulator. Unless you have a good reason not to do so, there should be a node under rpm-requests, which describes mp5496 regulators exported via RPM. then USB should refer to those regulators. > > Thanks > Varada > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > --- > > > Changes in v10: > > > - Add LDO regulator node > > > --- > > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > index bdc1434..1f5d14f 100644 > > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > @@ -60,6 +60,13 @@ > > > regulator-min-microvolt = <725000>; > > > regulator-max-microvolt = <1075000>; > > > }; > > > + > > > + mp5496_l2: l2 { > > > + regulator-min-microvolt = <1800000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > }; > > > }; > > > > > > -- > > > 2.7.4 > > > > > > > > > -- > > With best wishes > > Dmitry
On Sat, May 06, 2023 at 02:33:11PM +0300, Dmitry Baryshkov wrote: > On Sat, 6 May 2023 at 14:09, Varadarajan Narayanan > <quic_varada@quicinc.com> wrote: > > > > On Fri, May 05, 2023 at 12:29:54PM +0300, Dmitry Baryshkov wrote: > > > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan > > > <quic_varada@quicinc.com> wrote: > > > > > > > > Add LDO regulator node > > > > > > As this LDO is provided by the PMIC, it would be nice to know why it > > > is modelled as an always-on regulator instead of the proper PMIC > > > regulator. Up to now we were doing this only for the outstanding power > > > rails like CX/MX or EBI. > > > > These are always ON because USB phy doesn't support power > > collapse, and there is a chance that other IP blocks might be > > sharing the rail. > > You are describing the software side here. From the hardware point of > view, it is an I2C regulator, which is probably also exported as an > SMD_RPM regulator. Unless you have a good reason not to do so, there > should be a node under rpm-requests, which describes mp5496 regulators > exported via RPM. then USB should refer to those regulators. Yes. It is a part of rpm-requests. That is why have mentioned V10 is dependent on https://lore.kernel.org/lkml/20230407155727.20615-1-quic_devipriy@quicinc.com/T/. The 4th patch of the above series (https://lore.kernel.org/lkml/20230407155727.20615-1-quic_devipriy@quicinc.com/T/#mea3f0ea37c53cf5e39e10cd6cf3bed5243cec629) adds the rpm_requests node and this regulator definition is added to it. Hope that is ok. Thanks Varada > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > > --- > > > > Changes in v10: > > > > - Add LDO regulator node > > > > --- > > > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > > index bdc1434..1f5d14f 100644 > > > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > > @@ -60,6 +60,13 @@ > > > > regulator-min-microvolt = <725000>; > > > > regulator-max-microvolt = <1075000>; > > > > }; > > > > + > > > > + mp5496_l2: l2 { > > > > + regulator-min-microvolt = <1800000>; > > > > + regulator-max-microvolt = <1800000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > }; > > > > }; > > > > > > > > -- > > > > 2.7.4 > > > > > > > > > > > > > -- > > > With best wishes > > > Dmitry > > > > -- > With best wishes > Dmitry
On Mon, 8 May 2023 at 08:17, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > On Sat, May 06, 2023 at 02:33:11PM +0300, Dmitry Baryshkov wrote: > > On Sat, 6 May 2023 at 14:09, Varadarajan Narayanan > > <quic_varada@quicinc.com> wrote: > > > > > > On Fri, May 05, 2023 at 12:29:54PM +0300, Dmitry Baryshkov wrote: > > > > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan > > > > <quic_varada@quicinc.com> wrote: > > > > > > > > > > Add LDO regulator node > > > > > > > > As this LDO is provided by the PMIC, it would be nice to know why it > > > > is modelled as an always-on regulator instead of the proper PMIC > > > > regulator. Up to now we were doing this only for the outstanding power > > > > rails like CX/MX or EBI. > > > > > > These are always ON because USB phy doesn't support power > > > collapse, and there is a chance that other IP blocks might be > > > sharing the rail. > > > > You are describing the software side here. From the hardware point of > > view, it is an I2C regulator, which is probably also exported as an > > SMD_RPM regulator. Unless you have a good reason not to do so, there > > should be a node under rpm-requests, which describes mp5496 regulators > > exported via RPM. then USB should refer to those regulators. > > Yes. It is a part of rpm-requests. That is why have mentioned V10 > is dependent on > https://lore.kernel.org/lkml/20230407155727.20615-1-quic_devipriy@quicinc.com/T/. > The 4th patch of the above series > (https://lore.kernel.org/lkml/20230407155727.20615-1-quic_devipriy@quicinc.com/T/#mea3f0ea37c53cf5e39e10cd6cf3bed5243cec629) > adds the rpm_requests node and this regulator definition is added > to it. Hope that is ok. It is fine. Most probably I was mistaken by the patch itself. Please excuse me. If this this is an RPM regulator, it's is fine and correct. > > Thanks > Varada > > > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > > > --- > > > > > Changes in v10: > > > > > - Add LDO regulator node > > > > > --- > > > > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > > > > 1 file changed, 7 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > > > index bdc1434..1f5d14f 100644 > > > > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > > > @@ -60,6 +60,13 @@ > > > > > regulator-min-microvolt = <725000>; > > > > > regulator-max-microvolt = <1075000>; > > > > > }; > > > > > + > > > > > + mp5496_l2: l2 { > > > > > + regulator-min-microvolt = <1800000>; > > > > > + regulator-max-microvolt = <1800000>; > > > > > + regulator-boot-on; > > > > > + regulator-always-on; > > > > > + }; > > > > > }; > > > > > }; > > > > > > > > > > -- > > > > > 2.7.4 > > > > > > > > > > > > > > > > > -- > > > > With best wishes > > > > Dmitry > > > > > > > > -- > > With best wishes > > Dmitry
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts index bdc1434..1f5d14f 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts @@ -60,6 +60,13 @@ regulator-min-microvolt = <725000>; regulator-max-microvolt = <1075000>; }; + + mp5496_l2: l2 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; }; };