From patchwork Thu Feb 16 17:57:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 58180 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp444368wrn; Thu, 16 Feb 2023 09:59:42 -0800 (PST) X-Google-Smtp-Source: AK7set/58ZJKOY7oFNBoPyy5Kzw489ksS5Ej++J0MJM1I7jKuYf8HR3J4ZyjVHDP75xZSTeW8V14 X-Received: by 2002:aa7:d885:0:b0:4ac:c85c:fb8d with SMTP id u5-20020aa7d885000000b004acc85cfb8dmr7285711edq.10.1676570382111; Thu, 16 Feb 2023 09:59:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676570382; cv=none; d=google.com; s=arc-20160816; b=grJIQoiwWcEyNkZQgSxszJLCmvhimwWQuVxv+Q7NMoGXUmXHKzQ51hGBxqEPCMCgfk 2/KsnAT3hXcFQVZ/CQVqAq/eEypwIRi7Hw56TGIf3Lpzv2iPCET9uNnsUyzg8JDKVA3U bFauHXXLKSVi+3pC956474kzZf7mQYl7kfTyOE2sb3Yr6l/zBEUGUZ0yRCVZcOnYfYLm M972RGjxjKlgd/0bzP8/h2SuTvGyBbXCQLikvluOZHJd/SabnrtKO7fVhVzXNekuXv2r J+IMlj26T5pGgEFXIEmikxdgl9YeSWRxSk9hs2M/Iax7uR5TD3aJDlPEAnvMC1CcddZ3 GkSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-id:content-language:accept-language:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=SduSeqOwVL90O9MEgDTlHkV2YuE15AjLaWPjyDCCbvQ=; b=jMwMSkW3TfxP4K24DuLp5Xku5ZswXIZ9SY7DLvvNWUEngdopKyQ3vl95EN1lnxyfQv H+Av5hqNLINSY1yZJU2HNiSMBqkvmLh6hvsKftn5XF+1ekBejhXaMxlg6iHEBwPsKs16 WJCKJTGrNW+THN4fttRlOzZ1dCIeiJCe7NJbFT7aqsdVl0BEAThPFc55LRXKxaF/W7u7 1kYyag59UVOtnlkA5v+eozmFzmjJYJYm51r6TRnrRH6WlOxIJGmUyT0HOtLUDeU0h3Zm ycYwV7FAy/atARgtbR8aceXBNcyFnTaes6TPmwV/o8qG5A9rUUr8VHxIssKTpKCWP6JP G0mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=kFmCVb1r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l13-20020aa7c30d000000b004ace0fce45asi2856650edq.509.2023.02.16.09.59.18; Thu, 16 Feb 2023 09:59:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=kFmCVb1r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230045AbjBPR5o (ORCPT + 99 others); Thu, 16 Feb 2023 12:57:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbjBPR5n (ORCPT ); Thu, 16 Feb 2023 12:57:43 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A6911BD1 for ; Thu, 16 Feb 2023 09:57:39 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 8E9FD5FD10; Thu, 16 Feb 2023 20:57:35 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1676570255; bh=SduSeqOwVL90O9MEgDTlHkV2YuE15AjLaWPjyDCCbvQ=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=kFmCVb1rxHNm8v5I0wrODLKy6oWi5DrJVjX3n8ylfuqC+mgu2vSVFodi/xRTa5lY4 2fT6+47r/IzlJvv4YbX0jwJPTGo+9JPMORi3+eEaFqLqsYoHSvI+1FFQuTwGwV3naM hV01t8DBIQdoZW6ecsJ5hb8hDZQzzwLB+YWdvr0bkxhrlwCdwYJ/+o79NxK1YyVgas jiD85t+P389oy8WjJo8IpxT7Rh7SCr0ul22l57qP9lrmTdzifKHrA3PioaTya0H24+ id7ng3Sqjty+eEOzpb0vrzy9oZNg+LiZ+iYI/aA8ONo3aVsoQrsSyO65BazcTQZt90 jNh5GZjJ2pAKw== Received: from S-MS-EXCH02.sberdevices.ru (S-MS-EXCH02.sberdevices.ru [172.16.1.5]) by mx.sberdevices.ru (Postfix) with ESMTP; Thu, 16 Feb 2023 20:57:32 +0300 (MSK) From: =?utf-8?b?0JrRgNCw0YHQvdC+0LIg0JDRgNGB0LXQvdC40Lk=?= To: Liang Yang , Miquel Raynal , Richard Weinberger , "Vignesh Raghavendra" , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?0Jo=?= =?utf-8?b?0YDQsNGB0L3QvtCyINCQ0YDRgdC10L3QuNC5?= , Krasnov Arseniy CC: "linux-mtd@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-amlogic@lists.infradead.org" , "linux-kernel@vger.kernel.org" , kernel Subject: [PATCH] mtd: rawnand: meson: initialize struct with zeroes Thread-Topic: [PATCH] mtd: rawnand: meson: initialize struct with zeroes Thread-Index: AQHZQjAk8W+Ow1LN4Uavv419Ihk4sA== Date: Thu, 16 Feb 2023 17:57:32 +0000 Message-ID: <8881a365-e218-916a-e68d-d889797279be@sberdevices.ru> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-ID: <67C80C4B08BF6441AA617A43FDA00DA0@sberdevices.ru> MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/02/16 08:39:00 #20868660 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758011464953012120?= X-GMAIL-MSGID: =?utf-8?q?1758011464953012120?= This structure must be zeroed, because it's field 'hw->core' is used as 'parent' in 'clk_core_fill_parent_index()', but it will be uninitialized. The following backtrace is result of the dereference of such pointer: [ 1.081319] __clk_register+0x414/0x820 [ 1.085113] devm_clk_register+0x64/0xd0 [ 1.088995] meson_nfc_probe+0x258/0x6ec [ 1.092875] platform_probe+0x70/0xf0 [ 1.096498] really_probe+0xc8/0x3e0 [ 1.100034] __driver_probe_device+0x84/0x190 [ 1.104346] driver_probe_device+0x44/0x120 [ 1.108487] __driver_attach+0xb4/0x220 [ 1.112282] bus_for_each_dev+0x78/0xd0 [ 1.116077] driver_attach+0x2c/0x40 [ 1.119613] bus_add_driver+0x184/0x240 [ 1.123408] driver_register+0x80/0x140 [ 1.127203] __platform_driver_register+0x30/0x40 [ 1.131860] meson_nfc_driver_init+0x24/0x30 Signed-off-by: Arseniy Krasnov --- drivers/mtd/nand/raw/meson_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.35.0 diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c index 5ee01231ac4c..30e326adabfc 100644 --- a/drivers/mtd/nand/raw/meson_nand.c +++ b/drivers/mtd/nand/raw/meson_nand.c @@ -991,7 +991,7 @@ static const struct mtd_ooblayout_ops meson_ooblayout_ops = { static int meson_nfc_clk_init(struct meson_nfc *nfc) { - struct clk_parent_data nfc_divider_parent_data[1]; + struct clk_parent_data nfc_divider_parent_data[1] = {0}; struct clk_init_data init = {0}; int ret;