From patchwork Sun Feb 25 15:54:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 206084 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp1635697dyb; Sun, 25 Feb 2024 07:58:41 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXJf77XmYu7EtyZR2GIkYwzs6t7eecywJOK8wi4YysfDRJdcswsGx3cuvAZ030T6D5pV8MD7ViRn3aLTUQZWnlKhIPIJw== X-Google-Smtp-Source: AGHT+IFTxbESPo+fn/OgAHVAFg/rAcgMu8Euow5S2y5WT1tuWr4gvXodXvxSu62mN5VW/W+Ouehn X-Received: by 2002:a05:6e02:118a:b0:365:12e:4ef1 with SMTP id y10-20020a056e02118a00b00365012e4ef1mr5433254ili.5.1708876721307; Sun, 25 Feb 2024 07:58:41 -0800 (PST) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id lv13-20020a1709032a8d00b001dbc6f9e3a8si2294784plb.66.2024.02.25.07.58.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 07:58:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-80174-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-80174-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80174-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3A4F6B21E69 for ; Sun, 25 Feb 2024 15:56:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 659AC1B96E; Sun, 25 Feb 2024 15:55:21 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ADBF1799F for ; Sun, 25 Feb 2024 15:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708876519; cv=none; b=TzZGRwxJJPgWdmyuWGNYzo465TBBDMBd8Qqy7TLOTjxTHTqUpKOQ3OB/SFyyfD+VY8TXmmuoxxXP7HtdhGnM3CoLoJ59A3QZ0eoTYnTJQqwCvMqeS0nv3zAQSrSNMfwmnLzoYC34i+o7jYsisdNJUb88usG2ag+eSy/YQhbz4UI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708876519; c=relaxed/simple; bh=UuZYWOa89eHlHR4UPrFuYfV6ZZKmYfISpH6emRmR32Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ecFONfOhe5XaK5iLhO2QLPDZs0l+0BGGmFVdVRXf6KF9ECIvM4Z9kBVMXdHj2n6zp58R4ynhQQ5F/PoRrU9bHnED+MGQ8IohCGjd5BjewQiYS89TXBmp+w6L0dRBHYn9okTZSMvFW+T/ZFsc1SreC16I0a+KvvnddBx2lLf0fJ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1reGqN-00006W-HQ; Sun, 25 Feb 2024 16:55:11 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1reGqM-002pKF-W4; Sun, 25 Feb 2024 16:55:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1reGqM-00BKow-2w; Sun, 25 Feb 2024 16:55:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: MyungJoo Ham , Chanwoo Choi Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/7] extcon: intel-cht-wc: Convert to platform remove callback returning void Date: Sun, 25 Feb 2024 16:54:51 +0100 Message-ID: <87f0b8f158565cb9ea68b42db2bb018f82a7ee27.1708876186.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1845; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=UuZYWOa89eHlHR4UPrFuYfV6ZZKmYfISpH6emRmR32Q=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl22LRMs74IYM8KRHlBfQXhdldwEVVxjWhCHuZm RiEsmGOlpeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZdti0QAKCRCPgPtYfRL+ Ts38CACjV8KO4l/kx+h6REYW4CyVrftN7YTwT/P0yw1bDYD9Z1G2pFm+Cj7nDHK1oPCRKuyyoK1 2JiC4gDn1T9eR7ZA5amZcpMqAOEwtlaxruP8A50FFGvWrCOPIjSXjnp0ukRWkIrpA4aswI+5V7n ZB1vB3Ou8gKeDBuiFlW+P9vB14pd3hX1Y8A30RUvjaTlndh5eggF1xc01bUecMoZzPwWNC9/55m PY74KaL1dMcwI6lW7xBfbk6oqc5GOd4xxK/ev6TftR+MBOrgFum+9r7Jz04BROX9YCgAi2a8gU5 W7jyM4fQFvxhpTOTDsISooBOtt0O77nE23T2DsbhHAPq3syA X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791887116882839966 X-GMAIL-MSGID: 1791887116882839966 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/extcon/extcon-intel-cht-wc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/extcon/extcon-intel-cht-wc.c b/drivers/extcon/extcon-intel-cht-wc.c index 2c55f06ba699..733c470c3102 100644 --- a/drivers/extcon/extcon-intel-cht-wc.c +++ b/drivers/extcon/extcon-intel-cht-wc.c @@ -617,13 +617,11 @@ static int cht_wc_extcon_probe(struct platform_device *pdev) return ret; } -static int cht_wc_extcon_remove(struct platform_device *pdev) +static void cht_wc_extcon_remove(struct platform_device *pdev) { struct cht_wc_extcon_data *ext = platform_get_drvdata(pdev); cht_wc_extcon_sw_control(ext, false); - - return 0; } static const struct platform_device_id cht_wc_extcon_table[] = { @@ -634,7 +632,7 @@ MODULE_DEVICE_TABLE(platform, cht_wc_extcon_table); static struct platform_driver cht_wc_extcon_driver = { .probe = cht_wc_extcon_probe, - .remove = cht_wc_extcon_remove, + .remove_new = cht_wc_extcon_remove, .id_table = cht_wc_extcon_table, .driver = { .name = "cht_wcove_pwrsrc",