From patchwork Wed Dec 27 16:26:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183515 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1532720dyb; Wed, 27 Dec 2023 08:28:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFrb5NukGFese33AspnOt2TgGo6qLcjQlxCJ5tzyE1DPcGL5UmqZpPbR296TQ7nwL/YOz2p X-Received: by 2002:a05:6214:e82:b0:67f:310b:7aa with SMTP id hf2-20020a0562140e8200b0067f310b07aamr14200383qvb.18.1703694509431; Wed, 27 Dec 2023 08:28:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694509; cv=none; d=google.com; s=arc-20160816; b=r0/Vh7fyHFN401PeTkrEVFIC5IeuvP0zELfLeBBz+hB75jUaKhjq3gdvPVbwmlq6gf Z5/Hx9NEyDmEkZbPhZL0aWwK4yXMzzS1I22bT1ecvP5ArD9TEoRYVPY5Sz3biwifYbyS hT8fNAFNJwaw99Yp6t3cdfbcYAB4H+s4PljknHZwS0fW3uTHHLV16YFFzMg2ey6FljIq N7q/Pgq44BB7uwW5NaaOA9izsTBINmrZm5BdilBOhKqWX3gPf4uZsBKenVAb5NNz7aSP 6lV7SWS8q8wjsn8SrvtXM2fP2SjyM9N016r0GCGMqlbLTjZZLKQGdJwLa6BqcwDMXuWE CmHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=4euGTQWQmuDBbD7Z0U2oMuDE0hHyu3RyhpdH3lolfgo=; fh=Pv8I0nxJOLyHkgyXeQ28bFoz2KGItoI9hXXX1Uk9JJ4=; b=SyR+PsX31TmmnFVnmXcccuFClyNKZFJImDXhmXastuIvLG1j+8YcW4ZJsZ+fCpRUgO JqLWBCJmBxXukfy7hX3JgloXEjDOV4HZpKbv3D04aephOfP4RcTW62MFcs24o74fr8vf +oH0A5GVyzFEZ/l41XaPu9w8doBxHnxr8LCWdwBrYw0kFt7wQSwyfrosPm5jZOHvaaeQ 31165gJb1jQA0STMTy4udFCLK1EgJG3xaII8aGA5En1tGu4wjYlr2Dur4ukaXiXpBf+J WDLOJ+NglyowCj6VO+t6MyTmIIZsypARcMaiQBiM+iCE5X7RcH2ERrdFy+m/zhCNtFdL M0sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12130-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12130-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f21-20020a05620a409500b007815e21d56csi2079515qko.340.2023.12.27.08.28.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:28:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12130-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12130-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12130-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3D19A1C20E1F for ; Wed, 27 Dec 2023 16:28:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D476E481CC; Wed, 27 Dec 2023 16:26:57 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55CD246437 for ; Wed, 27 Dec 2023 16:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWjz-00059m-UU; Wed, 27 Dec 2023 17:26:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjw-001tZK-Lv; Wed, 27 Dec 2023 17:26:41 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjx-001Wmg-2E; Wed, 27 Dec 2023 17:26:41 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Sudeep Holla Cc: kernel@pengutronix.de, Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/11] firmware: arm_scmi: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:25 +0100 Message-ID: <86165c8ccd0bb47000a29e711102795b36c8df41.1703693980.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1796; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=JK/CSDYjlDzz8/Ko2zYkIZLw829LGnskJHP4zrb3nSc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFAzHGKIj+U2X2/VquNqcN62INqnmVrFKeBUV waVRlMvMSiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQMwAKCRCPgPtYfRL+ To+6CACSdd6ebXHEHuZH278GDpN/34UYlQyumgf05hEYLn7eStz0mwZTNZNBViswZLobbkbPjvj TUoGFM03/AvIKHgJVHzZmivM8csSsF18pCdURQ/26QNnv4XEItA9q6KOOGze54yeGKt4ir7mRwo H1syPHLrzQLDrf00QPIvhRj3sJoRF6FHV8HfYI7nGpnextDyr6+zTkcfxOC1vUvY+TIUXgHMk3A J41YL+ZRdcpMZEH7qFNq9icFrtCTVzqpNTLBT7x0xMmtWYCvS6o5xqwpQLeDOadis6WNhBrmRIR jH3lsv1OVKlzE+oq89AayWxMuMsgh1FqBuumXnYiubyQyRqf X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453173866430909 X-GMAIL-MSGID: 1786453173866430909 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/firmware/arm_scmi/driver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index a9f70e6e58ac..3ea64b22cf0d 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -2834,7 +2834,7 @@ static int scmi_probe(struct platform_device *pdev) return ret; } -static int scmi_remove(struct platform_device *pdev) +static void scmi_remove(struct platform_device *pdev) { int id; struct scmi_info *info = platform_get_drvdata(pdev); @@ -2868,8 +2868,6 @@ static int scmi_remove(struct platform_device *pdev) scmi_cleanup_txrx_channels(info); ida_free(&scmi_id, info->id); - - return 0; } static ssize_t protocol_version_show(struct device *dev, @@ -2947,7 +2945,7 @@ static struct platform_driver scmi_driver = { .dev_groups = versions_groups, }, .probe = scmi_probe, - .remove = scmi_remove, + .remove_new = scmi_remove, }; /**