From patchwork Fri May 26 06:38:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 99310 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp268670vqr; Thu, 25 May 2023 23:42:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4wiBRBLix3C3UUO4ECil0iDwOAOixAFmr93fmpX6WNI0jxf8UnhnNeqTiKeKJ3ucRMBxTf X-Received: by 2002:a17:90b:50e:b0:256:1fd4:1431 with SMTP id r14-20020a17090b050e00b002561fd41431mr1443960pjz.8.1685083354041; Thu, 25 May 2023 23:42:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685083354; cv=none; d=google.com; s=arc-20160816; b=b8ey0tKGBWD9m97qWEiVoGnvpA7fg5VFqI6dnJpwd/Eg7xZYtcqOnigjKqzFSEH/GN XgI3zwfB5a2et5tUw1b+2zkLqIPsMwtPMZoX/VIYlN9JKk0yW6JE/veFIgABtr5VHRDY vqtiz7BDL5VcEGHuk1P+edXMlD4eIfyMFwB8B1MVMChrxlIBIxEtFuT9y9LWBALVHvIY bn5DhD5r9cYLbJCC4kUNiaUClmM049bR2n3o/a/Q4fi1JxLiBAUfFlF6D8BxGcqmll/F O2ItpAwr7uFavG/z9pNOwF5L8M7HXD5uHawQXf3mCMnAFpNR5Y+RsfEiPaTt2M0fi6FF p6sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mILjjqW3e0J19x6hS+N8rbpkhGpdI9PUFEHSMRI8loY=; b=oZ1N4pSAfD6eeXSVDZCdZg/yTGjYQ0a5WNbjOQuCJKyGKj/Xq21WyC+74HGC1BkOnu fmLh53vFefjrbzJ06r9uDwq4C/TQoqdL0QMb+r8n3tm1Z69WcBjaLWR7YjzB256JwXLE s26XmHK/6M85YpQwmJOqBpM491PC5UlSaVWMTwZLA0aBlLhkism4m0+NcHLynDG3Pmsa gwZm/xjBY2SPXB64WGvVu9ZdfJoQWn3SFotVnmFeovzAKyvzrI91fP7KK5zg3YFh62vv XdWuTld5jub5tuTw27RXvw5zhsvlHML6TtxqvKlDJqr9fgpWkFU4k9C3nfptPHWunBcC QhZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=QqXMhxrL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z5-20020a17090abd8500b0024ddf090102si1164646pjr.56.2023.05.25.23.42.22; Thu, 25 May 2023 23:42:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=QqXMhxrL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242025AbjEZGiX (ORCPT + 99 others); Fri, 26 May 2023 02:38:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229736AbjEZGiV (ORCPT ); Fri, 26 May 2023 02:38:21 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3430D12E; Thu, 25 May 2023 23:38:20 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2af318fa2b8so3735701fa.0; Thu, 25 May 2023 23:38:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685083098; x=1687675098; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mILjjqW3e0J19x6hS+N8rbpkhGpdI9PUFEHSMRI8loY=; b=QqXMhxrLSOQ7nywZmaV7FI8ymMNakypk/Dj49sU/2sDG0/483oULyJT6EobYi7rVba 8z9sE1Pprf0DjsFyPhYBCeJ5hj2PEc1OjxdGBMdpH3pb86B9hxgJTGVDp2nPZD7SOxsj mhmPeXbd3LP5fqRLmSSLu5MbCZbUVbq81BHynri16/t8nwtTH06TyXpz5z30VuH5vizN 27bRI/gVnmIY8LM6JfAiuCvsJl57gdSWfiwwHb4W+qXG1vKqPI9oFS56Ta+NPvU501Wr y9Sux0yIWvW9kkenQIowZeI7gvmimXrzszuOvcahFTAA6lpvw0YLtKKCP+dRbq4cXkdA pE5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685083098; x=1687675098; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mILjjqW3e0J19x6hS+N8rbpkhGpdI9PUFEHSMRI8loY=; b=P39P+AdThQjdw3yHzg9grSz8usuTVt6o6+3gIsBDSYH9iVV1L83gZdFMkeq3MrkxlW VBs+ZTuWay+VH3aXtobjpQzZT3q8t5GvRQfdnedANF54h/ydPDZA2/ZP5UUngEXDe3nz /7lxjVSt/lwB1TS51dCpH7G86jhwZ38BGg/nmQoHJ46FoctkratwGsQEhgKtfU5MaXhO /pdR09S/gJ9SnvbjFNeCBeMMP3bMU/hhUmTPk4cSHxWYKgSxc+mcQmxxJ71gqFeN/OFd sUwr0RTtQdWPV8F1KcrcCDI2EjsQuT09WWR4rQiQhMUhcLEoYZzBPcBFF3yWxGt2Pdoz K+lg== X-Gm-Message-State: AC+VfDz2C/Q/jiQNYSONyQ58c/qxaIi5MXnxFJPWW2eId8EAhcYqHIi8 IfJDKscwyjQGaeMQdj+SPNs= X-Received: by 2002:a2e:9ed9:0:b0:2ad:d949:dd39 with SMTP id h25-20020a2e9ed9000000b002add949dd39mr516174ljk.29.1685083098283; Thu, 25 May 2023 23:38:18 -0700 (PDT) Received: from fedora ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id q16-20020a2e84d0000000b002ad1ba6ee36sm557453ljh.140.2023.05.25.23.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 23:38:17 -0700 (PDT) Date: Fri, 26 May 2023 09:38:05 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan =?iso-8859-1?q?Neusch=E4fer?= , Linus Walleij , Paul Cercueil , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: [PATCH v6 4/8] pinctrl: wpcm450: relax return value check for IRQ get Message-ID: <830e6e61cf51d43cb7a99b846ab4676823e4e78a.1685082026.git.mazziesaccount@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766937962668078508?= X-GMAIL-MSGID: =?utf-8?q?1766937962668078508?= fwnode_irq_get[_byname]() were changed to not return 0 anymore. The special error case where device-tree based IRQ mapping fails can't no longer be reliably detected from this return value. This yields a functional change in the driver where the mapping failure is treated as an error. The mapping failure can occur for example when the device-tree IRQ information translation call-back(s) (xlate) fail, IRQ domain is not found, IRQ type conflicts, etc. In most cases this indicates an error in the device-tree and special handling is not really required. One more thing to note is that ACPI APIs do not return zero for any failures so this special handling did only apply on device-tree based systems. Drop the special (no error, just skip the IRQ) handling for DT mapping failures as these can no longer be separated from other errors at driver side. Signed-off-by: Matti Vaittinen Reviewed-by: Jonathan Neuschäfer Acked-by: Linus Walleij Reviewed-by: Jonathan Cameron --- Revision history: v5 => : - No changes v4 => v5: Fix typo in subject "elax" => "relax" Please note, I took Linus' reply to v4 cover-letter as ack && added the tag. Please let me know if this was not Ok. The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone. --- drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c index 2d1c1652cfd9..f9326210b5eb 100644 --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c @@ -1106,8 +1106,6 @@ static int wpcm450_gpio_register(struct platform_device *pdev, irq = fwnode_irq_get(child, i); if (irq < 0) break; - if (!irq) - continue; girq->parents[i] = irq; girq->num_parents++;