diff mbox series

[RESEND] get_maintainer: add email addresses from dts files

Message ID 829b122da52482707b783dc3d93d3ff0179cb0ca.camel@perches.com
State New
Headers
Series [RESEND] get_maintainer: add email addresses from dts files |

Commit Message

Joe Perches Feb. 12, 2023, 9:17 p.m. UTC 
  From: Shawn Guo <shawnguo@kernel.org>

MAINTAINER file will get bloated quickly if individual section entry
is created for each .dts/.dtsi file.  Add the email address from dts
files to get_maintainer output for saving unnecessary patching on
MAINTAINER file.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Joe Perches <joe@perches.com>
---

Hey Andrew.  This was originally sent a year and a half ago.

Link: https://lore.kernel.org/all/20210809080204.8381-1-shawnguo@kernel.org/

Please pick this up.  Thanks.

 scripts/get_maintainer.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Oct. 28, 2023, 5:46 p.m. UTC | #1 
On Sun, Feb 12, 2023 at 01:17:45PM -0800, Joe Perches wrote:

> From: Shawn Guo <shawnguo@kernel.org>
> 
> MAINTAINER file will get bloated quickly if individual section entry
> is created for each .dts/.dtsi file.  Add the email address from dts
> files to get_maintainer output for saving unnecessary patching on
> MAINTAINER file.
> 
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Joe Perches <joe@perches.com>
> ---
> 
> Hey Andrew.  This was originally sent a year and a half ago.
> 
> Link: https://lore.kernel.org/all/20210809080204.8381-1-shawnguo@kernel.org/
> 
> Please pick this up.  Thanks.
> 
>  scripts/get_maintainer.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 2075db0c08b8..15aa8f947f4b 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -436,7 +436,7 @@ sub maintainers_in_file {
>  
>      return if ($file =~ m@\bMAINTAINERS$@);
>  
> -    if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
> +    if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) {
>  	open(my $f, '<', $file)
>  	    or die "$P: Can't open $file: $!\n";
>  	my $text = do { local($/) ; <$f> };
> 

This seems to have not been picked up, and would be useful for the tool
to have both for the kernel itself and other projects which also use it
and MAINTAINERS files. Can this please be picked up? Thanks!
Andrew Morton Nov. 6, 2023, 6:21 p.m. UTC | #2 
On Sat, 28 Oct 2023 13:46:56 -0400 Tom Rini <trini@konsulko.com> wrote:

> > -    if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
> > +    if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) {
> >  	open(my $f, '<', $file)
> >  	    or die "$P: Can't open $file: $!\n";
> >  	my $text = do { local($/) ; <$f> };
> > 
> 
> This seems to have not been picked up, and would be useful for the tool
> to have both for the kernel itself and other projects which also use it
> and MAINTAINERS files. Can this please be picked up? Thanks!

I'm not finding the original in my archives.  Can we have a resend please?
diff mbox series

Patch

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 2075db0c08b8..15aa8f947f4b 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -436,7 +436,7 @@  sub maintainers_in_file {
 
     return if ($file =~ m@\bMAINTAINERS$@);
 
-    if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
+    if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) {
 	open(my $f, '<', $file)
 	    or die "$P: Can't open $file: $!\n";
 	my $text = do { local($/) ; <$f> };