Message ID | 7f983ce079b176e1e1ac2a7d0c35b36197c5fa6b.1694613528.git.geert@linux-m68k.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp1121116vqx; Wed, 13 Sep 2023 07:21:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCUsdOoSTSHFsHSfd+kUm5jDJOSzdUJb4Pf1ljNjwrr+T2yLR+qrQebqArLMeNwpvCogfd X-Received: by 2002:a05:6a00:b54:b0:68f:caaa:e6d5 with SMTP id p20-20020a056a000b5400b0068fcaaae6d5mr3447465pfo.14.1694614860084; Wed, 13 Sep 2023 07:21:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694614860; cv=none; d=google.com; s=arc-20160816; b=APK7OQ2Rg6VCMI5VX9zA4DYzv78b57HYRk0GQRCDW2raFy0eUtaH9gkgQr4xecKTlc iD7YDmfVp2a+OkkJRRMAgAdZK5oerDoPUvCVxfDXNhloF7tgAtLdCMgiH7DMRQ96h6ba PjAHbfbINIUb3aO1bq+Q35PwF3VJYkf59tTnT10VZtLNrV9BEvYUkne+NaEXhpAyD+Ln q5Ba3pUfqMtOdY828o0FljX7QmG/XCnjuN/CLsuUnzt4G1o9OsuUdQNH8SrhSoUi8RQj ctuCQSxcE2T8xz6gugRT8OadZGc8U5R6lcnhXkDMUXVtf733BASu1Y0AeuOJRoKP1M7I DR4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=KglRTDF9jdSg4sYf3+Ovc55d8ixMunJ959Rjb349q+I=; fh=fKMC3BTGjlLXl5EvEhzqt3WHCynqYJKK7wAqLAOkWUw=; b=AoS3PYvrMhS8ZaqQ2MmXaZ5PHJP8P/ZdLrtpvuhPRQx+j+cMFaKKCEN20HFXDofSbX cg1gpG66b1WJUsVJQ+WMY7lU/18+tBXUGsZGKWS0UllT1drolLS7QJNhH6zVJYrdOT9I 6W8sQP+MfGzebVAqnguig+i1XEKZwJU+YSGo5LmMEVf0vMYKlXg6jJhkEQdeVnU4ncFv MGbG8xKONF9VpcpAfjOVduv5gjBDGEtGJwsSN00LLVz9qo1o6CWT0fUYy3+HIumx0X1q YryQtE9z4GyqvZ08+jTumPohpEet4q8GLeucaTTIJ9NKstmkkN/gU6BYDL1l5ThO2y2V w0Vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id j15-20020a633c0f000000b00563e0a0b2e1si9823983pga.451.2023.09.13.07.20.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 07:21:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 2C00C808D2BD; Wed, 13 Sep 2023 07:10:55 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241485AbjIMOJ7 (ORCPT <rfc822;pwkd43@gmail.com> + 36 others); Wed, 13 Sep 2023 10:09:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241331AbjIMOJN (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 13 Sep 2023 10:09:13 -0400 Received: from gauss.telenet-ops.be (gauss.telenet-ops.be [195.130.132.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8D181BF1 for <linux-kernel@vger.kernel.org>; Wed, 13 Sep 2023 07:08:51 -0700 (PDT) Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by gauss.telenet-ops.be (Postfix) with ESMTPS id 4Rm2PG2KJvz4wxgY for <linux-kernel@vger.kernel.org>; Wed, 13 Sep 2023 16:08:50 +0200 (CEST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:f674:9611:cd05:f25a]) by baptiste.telenet-ops.be with bizsmtp id lS8p2A0063fvA4V01S8prH; Wed, 13 Sep 2023 16:08:50 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qgQXe-003ctG-88; Wed, 13 Sep 2023 16:08:47 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qgQXv-00FV6F-Il; Wed, 13 Sep 2023 16:08:47 +0200 From: Geert Uytterhoeven <geert@linux-m68k.org> To: linux-m68k@lists.linux-m68k.org Cc: Arnd Bergmann <arnd@arndb.de>, Finn Thain <fthain@linux-m68k.org>, Michael Schmitz <schmitzmic@gmail.com>, Philip Blundell <philb@gnu.org>, Greg Ungerer <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>, Sam Creasey <sammy@sammy.net>, Laurent Vivier <laurent@vivier.eu>, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org> Subject: [PATCH v2 36/52] m68k: q40: Add and use "q40.h" Date: Wed, 13 Sep 2023 16:08:26 +0200 Message-Id: <7f983ce079b176e1e1ac2a7d0c35b36197c5fa6b.1694613528.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <cover.1694613528.git.geert@linux-m68k.org> References: <cover.1694613528.git.geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 13 Sep 2023 07:10:56 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776932471291260563 X-GMAIL-MSGID: 1776932471291260563 |
Series |
m68k: W=1 fixes
|
|
Commit Message
Geert Uytterhoeven
Sept. 13, 2023, 2:08 p.m. UTC
When building with W=1: arch/m68k/q40/q40ints.c:84:13: warning: no previous prototype for ‘q40_init_IRQ’ [-Wmissing-prototypes] 84 | void __init q40_init_IRQ(void) | ^~~~~~~~~~~~ arch/m68k/q40/q40ints.c:112:6: warning: no previous prototype for ‘q40_mksound’ [-Wmissing-prototypes] 112 | void q40_mksound(unsigned int hz, unsigned int ticks) | ^~~~~~~~~~~ arch/m68k/q40/q40ints.c:152:6: warning: no previous prototype for ‘q40_sched_init’ [-Wmissing-prototypes] 152 | void q40_sched_init (void) | ^~~~~~~~~~~~~~ Fix this by introducing a new header file "q40.h" for holding the prototypes of functions implemented in arch/m68k/q40/. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Arnd Bergmann <arnd@arndb.de> --- v2: - Add Acked-by. --- arch/m68k/q40/config.c | 6 ++---- arch/m68k/q40/q40.h | 6 ++++++ arch/m68k/q40/q40ints.c | 2 ++ 3 files changed, 10 insertions(+), 4 deletions(-) create mode 100644 arch/m68k/q40/q40.h
diff --git a/arch/m68k/q40/config.c b/arch/m68k/q40/config.c index c78ee709b45879c7..2c51c2b4a4fbbf79 100644 --- a/arch/m68k/q40/config.c +++ b/arch/m68k/q40/config.c @@ -36,16 +36,14 @@ #include <asm/q40_master.h> #include <asm/config.h> -extern void q40_init_IRQ(void); +#include "q40.h" + static void q40_get_model(char *model); -extern void q40_sched_init(void); static int q40_hwclk(int, struct rtc_time *); static int q40_get_rtc_pll(struct rtc_pll_info *pll); static int q40_set_rtc_pll(struct rtc_pll_info *pll); -extern void q40_mksound(unsigned int /*freq*/, unsigned int /*ticks*/); - static void q40_mem_console_write(struct console *co, const char *b, unsigned int count); diff --git a/arch/m68k/q40/q40.h b/arch/m68k/q40/q40.h new file mode 100644 index 0000000000000000..3146679bde0dab97 --- /dev/null +++ b/arch/m68k/q40/q40.h @@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +/* q40ints.c */ +void q40_init_IRQ(void); +void q40_mksound(unsigned int hz, unsigned int ticks); +void q40_sched_init(void); diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c index 127d7ecdbd49ecd9..10f1f294e91f9705 100644 --- a/arch/m68k/q40/q40ints.c +++ b/arch/m68k/q40/q40ints.c @@ -24,6 +24,8 @@ #include <asm/q40_master.h> #include <asm/q40ints.h> +#include "q40.h" + /* * Q40 IRQs are defined as follows: * 3,4,5,6,7,10,11,14,15 : ISA dev IRQs