From patchwork Fri Dec 8 16:08:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175891 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555964vqy; Fri, 8 Dec 2023 08:10:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IEnRbeQC35YtdOqw7Wwj6d6XryI/JtyFzJA0quJmLyRFZ/zr9nQKsmRTpkNB3kQpKUHVuyu X-Received: by 2002:a17:902:f549:b0:1d0:6ffd:6e70 with SMTP id h9-20020a170902f54900b001d06ffd6e70mr219841plf.104.1702051803503; Fri, 08 Dec 2023 08:10:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051803; cv=none; d=google.com; s=arc-20160816; b=H+pvJtgRGd01ZrY0q2/fpJlYr0Hhc3BiPm1AhIPk07m8SQxDAx+u8K3EFXPnt/9ThA K6lAO4Eqq1jt01r6RllNdBfp9TNh+d2zRhV9OylULljKn6CC0q8E5YlN7AXNch9JiFpL FAbPFkhyfTBe7kbsKX4pzU381GWQaCS0N6P+xABF5XqJUv9E7pewY3F9FxwggqVTUFdy wRqkYNAMy1lCfttyn/lX3n0nBzfxyfXv6gB5ixMhYw5ITWKWTtNFeumm8yPx8o11FOnY F9DBE8B6hmLr4Wb8aHwV3+ZZFYlN1rGYkcIEothKmVLY4q0oVThjXJ05fJXwCq3NzqSl mgrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PjRDhG9yTf3z30XDWLOboMTEufnEHy528yN+ux6qEBA=; fh=cNwtFUZjTXH2UUcqOFMfvCD75rIs3idIFJ0h0H0CVvA=; b=PCry5C0i/Uk/gs4SgYa4fNbNLhTUH8IMpA0LbpGvSuvtmf6nEvwXmRxzZqRoQCNJF4 OxFNgicSlQc2IHU7rlabmcdiV0g1vjfbS5/hg2QLJSJsuXeBsi7zS0hq/HifZqow9Ztp MhxD50hfFUVR5PMNhYGlTH9t7Hwv6lJW3Vq61LYLQVb09ni7sKNCp8A9MQ7zRz1Z43hW j4p+zzBnPvJy1ve4WfUcwdCaequ/eyeeCVjjcNQ9MrVcIdmFgddYKJKlovuO95n29UIa Gn4OOu8Ugr84QusJf+u4MH859vycXiS5m46rzQB7sstenWbq6n40wgoHUukvegTu05Uc 1L+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id v8-20020a170902b7c800b001d0187da0a0si1765096plz.292.2023.12.08.08.10.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:10:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id DCB6E837E665; Fri, 8 Dec 2023 08:09:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573944AbjLHQJf (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233802AbjLHQJQ (ORCPT ); Fri, 8 Dec 2023 11:09:16 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 543AD1996 for ; Fri, 8 Dec 2023 08:09:22 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPe-00007y-EO; Fri, 08 Dec 2023 17:09:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPc-00ES0L-Ja; Fri, 08 Dec 2023 17:09:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPc-00GUaK-AC; Fri, 08 Dec 2023 17:09:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: Pavel Machek , Kalle Valo , Paolo Abeni , "Steven Rostedt (Google)" , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 3/7] pcmcia: electra_cf: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:08 +0100 Message-ID: <7b07c8624ab53ec90554b7a665bef7662bd94295.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1830; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=n+hlrlFsRjhTMFN/VhJfgAOKKI1JiL5o8AuQJaDTRE8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz9t4grYDDRNZRyGpl8l+mzx2yGASB8M17muz Vz022OdPTSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/bQAKCRCPgPtYfRL+ TpWNB/485Cj9cA18CE30IsaMcPnXRbCFsk534FXaxYYJXEMycoz4bZpvGAJ8jLOXWgDgnK70lsO +pkBkxwNVpvix2AxSiF1GJKuRYbtq3ddnTRfcBepESP3rormcBQnV2b1uxXh1cTgzlNprF13JfT tnqRFcuKsW7T5Y5yCk0hfyZ2G5f2Hw/myzn+GW33HwdfyvZhAlShhuiPiGb/VAxTMkL2qkobj67 mCJjMz9qfoQ1ai/FBtGTw0jkvOHNZnauPOGw83L0B0sjSgVSI3dvvrkOSizpLpMQ5C2rHABZwLh mKheugxZLvGkY1Z/cp+whv808yrozTDnjguLm2OgWGiqzRLr X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:10:00 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730672021335099 X-GMAIL-MSGID: 1784730672021335099 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/electra_cf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c index efc27bc15152..5ae826e54811 100644 --- a/drivers/pcmcia/electra_cf.c +++ b/drivers/pcmcia/electra_cf.c @@ -307,7 +307,7 @@ static int electra_cf_probe(struct platform_device *ofdev) } -static int electra_cf_remove(struct platform_device *ofdev) +static void electra_cf_remove(struct platform_device *ofdev) { struct device *device = &ofdev->dev; struct electra_cf_socket *cf; @@ -326,8 +326,6 @@ static int electra_cf_remove(struct platform_device *ofdev) release_region(cf->io_base, cf->io_size); kfree(cf); - - return 0; } static const struct of_device_id electra_cf_match[] = { @@ -344,7 +342,7 @@ static struct platform_driver electra_cf_driver = { .of_match_table = electra_cf_match, }, .probe = electra_cf_probe, - .remove = electra_cf_remove, + .remove_new = electra_cf_remove, }; module_platform_driver(electra_cf_driver);