[RFC,1/3] MIPS: DTS: jz4780: add #clock-cells to rtc_dev

Message ID 77bcc96a2b81e42b32d48a041d7fac31e7240e56.1676482318.git.hns@goldelico.com
State New
Headers
Series Make WLAN and Bluetooth basically work for CI20 |

Commit Message

H. Nikolaus Schaller Feb. 15, 2023, 5:31 p.m. UTC
  This makes the driver present the clk32k signal if requested.
It is needed to clock the PMU of the BCM4330 WiFi and Bluetooth
module of the CI20 board.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Paul Cercueil Feb. 17, 2023, 4:29 p.m. UTC | #1
Le mercredi 15 février 2023 à 18:31 +0100, H. Nikolaus Schaller a
écrit :
> This makes the driver present the clk32k signal if requested.
> It is needed to clock the PMU of the BCM4330 WiFi and Bluetooth
> module of the CI20 board.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

Reviewed-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
>  arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index c182a656d63bc..18affff85ce38 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -155,6 +155,8 @@ rtc_dev: rtc@10003000 {
>  
>                 clocks = <&cgu JZ4780_CLK_RTCLK>;
>                 clock-names = "rtc";
> +
> +               #clock-cells = <0>;
>         };
>  
>         pinctrl: pin-controller@10010000 {
  
Thomas Bogendoerfer Feb. 19, 2023, 8:31 a.m. UTC | #2
On Fri, Feb 17, 2023 at 04:29:54PM +0000, Paul Cercueil wrote:
> Le mercredi 15 février 2023 à 18:31 +0100, H. Nikolaus Schaller a
> écrit :
> > This makes the driver present the clk32k signal if requested.
> > It is needed to clock the PMU of the BCM4330 WiFi and Bluetooth
> > module of the CI20 board.
> > 
> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> 
> Reviewed-by: Paul Cercueil <paul@crapouillou.net>
> 
> Cheers,
> -Paul
> 
> > ---
> >  arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> > b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> > index c182a656d63bc..18affff85ce38 100644
> > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> > @@ -155,6 +155,8 @@ rtc_dev: rtc@10003000 {
> >  
> >                 clocks = <&cgu JZ4780_CLK_RTCLK>;
> >                 clock-names = "rtc";
> > +
> > +               #clock-cells = <0>;
> >         };
> >  
> >         pinctrl: pin-controller@10010000 {

applied to mips-next.

Thomas.
  

Patch

diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
index c182a656d63bc..18affff85ce38 100644
--- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
+++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
@@ -155,6 +155,8 @@  rtc_dev: rtc@10003000 {
 
 		clocks = <&cgu JZ4780_CLK_RTCLK>;
 		clock-names = "rtc";
+
+		#clock-cells = <0>;
 	};
 
 	pinctrl: pin-controller@10010000 {