From patchwork Tue Mar 14 11:06:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 69503 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1693155wrd; Tue, 14 Mar 2023 04:15:15 -0700 (PDT) X-Google-Smtp-Source: AK7set/+5R5JAAzJ8S4HJozLk+VNmlqE+errSohFq0yqvJuErUUoF9VvwVmJrkv+JfOAoqZBLvkH X-Received: by 2002:a62:1756:0:b0:625:13f3:9409 with SMTP id 83-20020a621756000000b0062513f39409mr3753289pfx.26.1678792514813; Tue, 14 Mar 2023 04:15:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678792514; cv=none; d=google.com; s=arc-20160816; b=MdmtK/Qtzu2aE6bkUc+DYPnaSXa+pf9ReTOYqm4vOUdJR3VEOg0jJhMF7M1h8z3dzB LxV6qks2FYfzQzQhRBwG8SkmPs4JN81DxhJDT4gMf+NvsfERgPOqRS0bnkqNQgdaHNvT h9pjZPjzdUOklLw1V5oD6oU0moox5CuZpxOr6v0rOxe1NKijLs8ShOEU2u+yV+h3yyUl nhud8YGqpQpCAKw77qlF+zwZ2jGX19iCGjvVboBs64IPKP8cjAFZoeD1+i7KTEpSeazf vhR6O6wgmvb10aeuaXa4BrWds6QZgyctEa83BppZtEEPQSIfC/6/nP07me0KVEf5bB/C 5SzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:subject:from:cc:to :in-reply-to:content-language:user-agent:mime-version:date :message-id:dkim-signature; bh=BqQPywzkRmwCTA57RbQWMUd1CdLRbsre5I6PgGn4zLc=; b=f0d9sXUOH31eK077JZNHoTfmNtPUG0LsrK+OT8k1z5m7xaDgp3xT1OZ75cqmTTDW89 I+iuZC60V2N8qV9+/WeURRSGIv3upuuM90nZHMAaPPeREcV/HiIhzvB+dbwMxVVGfPi6 9bywPc+jkw9USHkprA4x0NrMuHla/t13SveNlfNuT2UcIsWBoJ6YfRPRlhoq2eaKGCt5 ZgjM1Y9B8Q4jRM+TUqAydU7kVY9jkPa/oDf6yudLrLUnwcEfrCgo4PLcSrXUTPIs+/Fk UqfbXNt3TqS2MNp1X9601CjCP0STiKHR9fwRjDFo1wqeOt6CAVQSlyOudPIqkxdFAzPF YDig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b="BN0l2/Tf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p68-20020a622947000000b005a8dcaeba57si1872114pfp.371.2023.03.14.04.14.59; Tue, 14 Mar 2023 04:15:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b="BN0l2/Tf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230374AbjCNLKr (ORCPT + 99 others); Tue, 14 Mar 2023 07:10:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231247AbjCNLK3 (ORCPT ); Tue, 14 Mar 2023 07:10:29 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B94D1E9F5; Tue, 14 Mar 2023 04:10:04 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 5D9F75FD62; Tue, 14 Mar 2023 14:10:02 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1678792202; bh=BqQPywzkRmwCTA57RbQWMUd1CdLRbsre5I6PgGn4zLc=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type; b=BN0l2/TfDTCvsziVYfNoVC4mjBCurnqS4VS8aYpiO7hTx4sXavjRCJufKIfRHMicT 6tjzPREFYda1wSXPLrwMk5P7xKn8vpLK31bzoeskcJgABxg4X2cbO+XUH1SMf5Y9CK HKO9Y3nSM54exR5FnTDFOU4Ki+bGcoaVzZMvI4icl6VkkxW2rQap1an+amcsGZl7yc bIbxm4LOWYJHIVj7uXnSfO+L3tPMPqzAts75TdgfRW0SjJX5UyXqeMFmwk2hf7JSMq bVLmJtNMaI0+w89QTAs5xP7zzTht7TcisGNS7vA+UFuQC2E6KRBvwCoxyxqZ4dLn8I 0TgNt+dZ9h1EA== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Tue, 14 Mar 2023 14:10:02 +0300 (MSK) Message-ID: <75e3f51b-2848-d3ce-a995-4ac8320663f6@sberdevices.ru> Date: Tue, 14 Mar 2023 14:06:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US In-Reply-To: <1bfcb7fd-bce3-30cf-8a58-8baa57b7345c@sberdevices.ru> To: Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bobby Eshleman CC: , , , , , , From: Arseniy Krasnov Subject: [PATCH RESEND net v4 2/4] virtio/vsock: remove redundant 'skb_pull()' call X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/03/14 06:01:00 #20942017 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760341540222715649?= X-GMAIL-MSGID: =?utf-8?q?1760341540222715649?= Since we now no longer use 'skb->len' to update credit, there is no sense to update skbuff state, because it is used only once after dequeue to copy data and then will be released. Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff") Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella Acked-by: Bobby Eshleman --- net/vmw_vsock/virtio_transport_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index 618680fd9906..9a411475e201 100644 --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c @@ -465,7 +465,6 @@ static int virtio_transport_seqpacket_do_dequeue(struct vsock_sock *vsk, dequeued_len = err; } else { user_buf_len -= bytes_to_copy; - skb_pull(skb, bytes_to_copy); } spin_lock_bh(&vvs->rx_lock);