From patchwork Fri Dec 15 13:59:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 179311 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9296719dys; Fri, 15 Dec 2023 06:03:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IE0YfWsaIA5AzsY4jahN4mirEnvC1YmQEZonPCwegVkXvBzJn+7VWeAgqUWuygT5YYC2cMW X-Received: by 2002:a05:6102:4188:b0:464:5eac:c249 with SMTP id cd8-20020a056102418800b004645eacc249mr10617443vsb.0.1702649026561; Fri, 15 Dec 2023 06:03:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702649026; cv=none; d=google.com; s=arc-20160816; b=TtlguFND9jb+ILS7sjoctFy0PM4VVMwiHHCXW8499GJYcob771A53TGg3vPZNYB5bV m/yB7SNpYSAFtQIjm7CplU+b9rQkmghLFDJqBgPeXjHhcMT00qHJrlum/zLZhM9iJMju ckg90Lqbd/NCTmtmn2k8u+N2KJXfXwbDKSNB9cBZRjK+b/BC6boWAjelYW8FWiimIeaW X+ZPYrDctr4UyvjthDrKRtCuOSibvgdSVNVt0u0McawoA/ML7nahXzGMq9TqIHPbv0VW r/5g91MIEo22/6AH9UVQXFnFXbkkQjKDazeNwkbyScW5UiLI0GGmIoU2Halm5PsW1XLr OG0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Qn8DYMCXSYitDd5usJa79EOeAJLoxZ1yO79t5yfrlwg=; fh=DcNjyPhulAZQZ5ccHdmXoPHXQdKvB4fSOMNK6hkjNx8=; b=naeGX1mIzq863JixjVN29c+ItFYbhDo0DLge4b8isXnpvciSLIAHl8tvRlk1+Hjoel tQiy7nORJaKsndcfS6hjlDxKkQdx2zcq7te8soUkpe4FF9I1A2faeB9bVZPYlZcWCFpM N0gm6r+0XqMm0aknjZT/Jy6+W6XZjFGHiQB1X67LsZBpsZzTyW1b2s1YQkcvgqQWGzsx o+n5Pb3vYRCyzzzD3Sz/AI0gL2D9BbhQ0xplsWTXpXxq8oipE+GQ0DFxZ4kSZjup8AHb Xs/Dnd+0IMYJEyYIfx+FRD6le/eiyb0KcklRCq3f3+B1nREAjWnAskH8HOOAFjYAYHBt 6lqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1067-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1067-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id x13-20020a0561020c0d00b0046625e5093dsi2523571vss.678.2023.12.15.06.03.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 06:03:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1067-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1067-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1067-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 57AC31C23293 for ; Fri, 15 Dec 2023 14:03:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8944B3BB2C; Fri, 15 Dec 2023 13:59:44 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 874C8347CB for ; Fri, 15 Dec 2023 13:59:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rE8j0-0002rC-Ed; Fri, 15 Dec 2023 14:59:34 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rE8j0-00G2aM-0W; Fri, 15 Dec 2023 14:59:34 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rE8iz-003cDE-Md; Fri, 15 Dec 2023 14:59:33 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Will Deacon , Mark Rutland Cc: Khuong Dinh , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 18/18] perf: xgene: Convert to platform remove callback returning void Date: Fri, 15 Dec 2023 14:59:18 +0100 Message-ID: <75dda01b2ad6e17f726830094bd38cb8faab5cbe.1702648125.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1815; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=1D3m60kbnUksK/WuWQHSRAl7TZysqOiH8RstEIIaHz8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfFu6lmqjVGVsA8r8JJiVanp1hayMpcamEY8We UV3o/A1jOSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXxbugAKCRCPgPtYfRL+ ToLzB/9+s5OjzXe6GfBT4NB0Anrnt5XQvyWxHodZTkqso/txn8S20jxyKZBgbZEm40n6bByfE9Z Y5jY7X9eMilOhnD61sfIzpIOBqWx6Z/SLI1WMWtd511mmdFDYmIBfDfIaApfpdfHmnZo+rQG6mt UX9FuzjlqJzZzX0MXek0fZNGli/bUd9tryph6bZXAfcH823yujJWnWMTdYsBVOleq76Le5kEMFx 0mhhu7w2A+Hb4nKFzzdjyJEm3zhVdqhXpvu9f2Za2x4j9Ux4pNnzcC9QKwUrc7tlX77YTu4akFy CViUrNEh4DxQWjE4KTbRzMb+iGxv5nVA7/nsi4N1BMPw4JIF X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785356905625448400 X-GMAIL-MSGID: 1785356905625448400 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/perf/xgene_pmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c index 7ce344248dda..0d49343d704b 100644 --- a/drivers/perf/xgene_pmu.c +++ b/drivers/perf/xgene_pmu.c @@ -1937,7 +1937,7 @@ xgene_pmu_dev_cleanup(struct xgene_pmu *xgene_pmu, struct list_head *pmus) } } -static int xgene_pmu_remove(struct platform_device *pdev) +static void xgene_pmu_remove(struct platform_device *pdev) { struct xgene_pmu *xgene_pmu = dev_get_drvdata(&pdev->dev); @@ -1947,13 +1947,11 @@ static int xgene_pmu_remove(struct platform_device *pdev) xgene_pmu_dev_cleanup(xgene_pmu, &xgene_pmu->mcpmus); cpuhp_state_remove_instance(CPUHP_AP_PERF_ARM_APM_XGENE_ONLINE, &xgene_pmu->node); - - return 0; } static struct platform_driver xgene_pmu_driver = { .probe = xgene_pmu_probe, - .remove = xgene_pmu_remove, + .remove_new = xgene_pmu_remove, .driver = { .name = "xgene-pmu", .of_match_table = xgene_pmu_of_match,