From patchwork Mon Dec 18 21:05:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180651 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1532094dyi; Mon, 18 Dec 2023 13:06:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQR2KL9u3p2n2yppocv8I2s5AMyTJqhxoFr2TFZaxk12mums2AYSoSNBJyMROjar9b8Sou X-Received: by 2002:a05:6a20:4303:b0:190:5e69:c9dd with SMTP id h3-20020a056a20430300b001905e69c9ddmr9241992pzk.70.1702933579601; Mon, 18 Dec 2023 13:06:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702933579; cv=none; d=google.com; s=arc-20160816; b=ujhcn3SsDlu6Db5N/yTIr5coE5XO4oHs608PBRcP/muWJ/Er2M2ukAn1L/YDjKcX8E PYo8hDmWmUF+VwdJ5nbJvMxjlZe8fhkztBc76q0uRtyWPxcjomzZC7bax1zVHu5RDxiu esu//N9Np0pDkPjRDL7SWuNbkMNozNygq2nnsAG/w3lqO2HoUUsoy+an6VggG9vc3NIW 6jQ0v0GYyiik4KFvhZz/33YMm9mxOa3b1PZYerLjcXWLDHQqvyVpdJrv2DuD3DkwMo0D GvRDldetfLpZjkyWQFFkhZq0yNCEjlzSHC7qbragaos/ki4y5iy9WX6hPGlWzLSTx0LH 2yDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=zpBquncqF8TEBqQCfwUeZMpvMB7Bd40nOrcrE8Tx6Cg=; fh=z+4mHlQ+bi7WTLlpPKhEQGijRz9jx1kHnkUntbLysbk=; b=0sWduaXjDpszvmAbiSEkruMiUCeOs3hdk3+XtxctqVL/60ALt0Fw/DBMfLilulW28K kgjWIXFRKOzn9Fg+X5K5+3TZ/7yHPvTU2IkPhGAExqYuccy2Xu6OJaiffsmVWR/R6PWl PZJUTc0S4U76GyBTiCkFBhIwBKplJ2/oQYhVkoY+raaKbYza1Oe3eUxY1gCnm+ycGRLd M4qvioN6RABE9Qoinef1lhHnag6jvCay2VmPqxy+fhwQLY0ZsuigWOIIG06iNHFdJxsl +sgUanrTPLXjBhZyEg16gRpElZcnK0criiCRo/H7fk8LaeP1U5y1CI3olfkXp2KCW6O7 b4Zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-4388-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4388-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id n10-20020a056a0007ca00b006d34809bd60si4657608pfu.137.2023.12.18.13.06.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 13:06:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4388-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-4388-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4388-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5F9C5284BED for ; Mon, 18 Dec 2023 21:06:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 863E074E2F; Mon, 18 Dec 2023 21:05:37 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E07E073465 for ; Mon, 18 Dec 2023 21:05:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFKnr-0002lQ-0x; Mon, 18 Dec 2023 22:05:31 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFKnq-00GmX0-KU; Mon, 18 Dec 2023 22:05:30 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rFKnq-005Y6F-BZ; Mon, 18 Dec 2023 22:05:30 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Sudip Mukherjee Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] parport: amiga: Convert to platform remove callback returning void Date: Mon, 18 Dec 2023 22:05:18 +0100 Message-ID: <75b3b8f498d6079c974bd47c763c589b9d2c00f6.1702933181.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1802; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=Gq/nWyE6d9ZldFyO+uVIZpTO25j9ER5SvPErnqrRnYI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlgLQN+lLmr5Slm5czjFdtTKrQMInsOAKAzUXc+ vZvRZZc6cqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYC0DQAKCRCPgPtYfRL+ TuCwB/0fpNXLrtKUtEaW1otT3V+Fw0O22vWNi78kkuucllgj9JCtEFoNNl0jPQVsFus3LUnHQrF W9NhbqdSjHBgDfJnWSun4ygXr1g4vvLhn+cwKqKRrHEP3wHlogtrM5+smoI5E/KFHVs10U3oXf7 6vB0EZXYq4wGw5I7Idnj21lJLmhuXECiFOut8HzPc3FZgB8BZJuHWAtVdZb/54r1JLQTZuE7xTA FSL9Nyo13sZA/yVq9rNqyiFCstdAQEOfOwTjwlZ2ZuJcfNApARu2f7h6tWsrROkUoqmHTz7gYI3 wvUneS4QrGph7Ovz9vYMIwJreM0sslARcVznLoO+E8NEk3AD X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785655281229936335 X-GMAIL-MSGID: 1785655281229936335 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/parport/parport_amiga.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/parport/parport_amiga.c b/drivers/parport/parport_amiga.c index 84d5701d606c..e6dc857aac3f 100644 --- a/drivers/parport/parport_amiga.c +++ b/drivers/parport/parport_amiga.c @@ -219,7 +219,7 @@ static int __init amiga_parallel_probe(struct platform_device *pdev) return err; } -static int __exit amiga_parallel_remove(struct platform_device *pdev) +static void __exit amiga_parallel_remove(struct platform_device *pdev) { struct parport *port = platform_get_drvdata(pdev); @@ -227,11 +227,10 @@ static int __exit amiga_parallel_remove(struct platform_device *pdev) if (port->irq != PARPORT_IRQ_NONE) free_irq(IRQ_AMIGA_CIAA_FLG, port); parport_put_port(port); - return 0; } static struct platform_driver amiga_parallel_driver = { - .remove = __exit_p(amiga_parallel_remove), + .remove_new = __exit_p(amiga_parallel_remove), .driver = { .name = "amiga-parallel", },