From patchwork Tue May 30 17:21:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Poimboeuf X-Patchwork-Id: 101049 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2344515vqr; Tue, 30 May 2023 10:31:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7t6Ig4ly7bslAdktGmJz0CZDogCBNeSk4Jm0UDVBwlOLvtAPmQrdSWy/3uZjCEtkRSK9jd X-Received: by 2002:a17:90b:17ca:b0:253:572f:79b2 with SMTP id me10-20020a17090b17ca00b00253572f79b2mr3221999pjb.36.1685467892888; Tue, 30 May 2023 10:31:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685467892; cv=none; d=google.com; s=arc-20160816; b=F0qNyUrQ922SWUfq1aeGKnUo5LFwi4dDlnQE4HveZe9g3JMKETzb3n4KfOcsYX0Lpa fv3QsgRCIFMV3I0zN+NAW64zjh3RF+9Ld7ollA/rFrGvpYxlv0NOVOCnDyyQriz3tKCx eGXVK8rc8g+e1cC03noJvwMHRptNy39G9AIgfkMnz6+Sr8ypXYDAoZgXxA3vm45NGVLU pAPf/0B2sYM2bzC8LHmb9djHLLBC4iZ6qAGsmutcnuoUEDcZs80cFRtmZ1WrE5RKTdwq 4WFswJsRZyx8CLs+0Vtl26LongRiw92K/FOlGUFvVqdD3D9XywAFYetO4p/orxxZslQ+ YuMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VKhdX2Nhlxap9UaTOKSDg7fK54dEeXos3IhKd8EDEQE=; b=uQnTmjaSxeuCHktivUgjZj4AnUoeNohPime8kNd3QlNbf/cJbdbv6FBosUYjsbkieD hEJjcuHrJJq5mw5qk957KJ28+y7WdszTNIzy0mp8657fPTp8Bt2tI1C+RMlAnikvJ3fJ J15Iw/XgxEVSqo5pPw5bBWBBszHj18zTmp7VtzzluhYVG5Byd0ezVLtFm6XjsGg7t4Ks VhN3Fjw3hBWLdLisZSHE05jCyrETiOFo5Y6X3s/R8aOYiBHXcd7fdgX0sns1QtVYoXIv gzGFQsKsdtjzs92YE/5pxp6MIR32NVs27/GCEZxVA5kXxJk4Reo2r8H2em17eCGZjWd4 HvtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F8yDNQfT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p14-20020a17090a2c4e00b002566f56e9aesi4720536pjm.105.2023.05.30.10.31.18; Tue, 30 May 2023 10:31:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F8yDNQfT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232222AbjE3RWA (ORCPT + 99 others); Tue, 30 May 2023 13:22:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232657AbjE3RVi (ORCPT ); Tue, 30 May 2023 13:21:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E007F1 for ; Tue, 30 May 2023 10:21:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CEF006312A for ; Tue, 30 May 2023 17:21:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD3D7C433A7; Tue, 30 May 2023 17:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685467295; bh=d0V+rEHElAyacw8AbdTR1mJCInv/LtANWszfGeTQmgw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F8yDNQfTKA9nvMlc46CPI5hnKobBApcx8UpbyQ1/1Jd06THr0c1Yrc29KuHgNJONw L92oBaxPY9PsXAmIEgotQuKIHrBkiBC5GVST6kWNDK0uY+8YBWNgPibY1j4B43ldNH 562+wEDDcglgp32ZVVEowehtdTQbu8a8m+AzjLqnok5n0PNYOhfgNJfJFTbsJVEYk4 QiWITQu8W4BiqW6AzlDvZkF4NvH7PLwWEkcDs4w0GFg2PXNyB24+4KOb8AAWss5c+W 8FlrJpL2uKKklAZ58mASkOL3Kecc7GquZ+e9++L4rvpc0NfyWRlNGehVlJUYSokNeI QzUtIam/mbfug== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Miroslav Benes Subject: [PATCH 09/22] objtool: Don't free memory in elf_close() Date: Tue, 30 May 2023 10:21:01 -0700 Message-Id: <74bdb3058b8f029db8d5b3b5175f2a200804196d.1685464332.git.jpoimboe@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767341181493578006?= X-GMAIL-MSGID: =?utf-8?q?1767341181493578006?= It's not necessary, objtool's about to exit anyway. Signed-off-by: Josh Poimboeuf --- tools/objtool/elf.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 8d491b2d123e..8d53f18a9502 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -1350,30 +1350,14 @@ int elf_write(struct elf *elf) void elf_close(struct elf *elf) { - struct section *sec, *tmpsec; - struct symbol *sym, *tmpsym; - struct reloc *reloc, *tmpreloc; - if (elf->elf) elf_end(elf->elf); if (elf->fd > 0) close(elf->fd); - list_for_each_entry_safe(sec, tmpsec, &elf->sections, list) { - list_for_each_entry_safe(sym, tmpsym, &sec->symbol_list, list) { - list_del(&sym->list); - hash_del(&sym->hash); - } - list_for_each_entry_safe(reloc, tmpreloc, &sec->reloc_list, list) { - list_del(&reloc->list); - hash_del(&reloc->hash); - } - list_del(&sec->list); - free(sec->reloc_data); - } - - free(elf->symbol_data); - free(elf->section_data); - free(elf); + /* + * NOTE: All remaining allocations are leaked on purpose. Objtool is + * about to exit anyway. + */ }