diff mbox series

x86/signal: Fix the value returned by strict_sas_size()

Message ID 73882d43ebe420c9d8fb82d0560021722b243000.1673717552.git.christophe.jaillet@wanadoo.fr
State New
Headers
Series x86/signal: Fix the value returned by strict_sas_size() |

Commit Message

Christophe JAILLET Jan. 14, 2023, 5:33 p.m. UTC 
  Functions used with __setup() return 1 when the argument has been
successfully parsed.

Reverse the returned value so that 1 is returned when kstrtobool() is
successful (i.e. returns 0)

Fixes: 3aac3ebea08f ("x86/signal: Implement sigaltstack size validation")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
This patch is completely speculative. Review with care!

My understanding of these __setup() functions is that returning 1 or 0
does not change much anyway.

I spot it and found it spurious while looking at something else.
Even if the output is not perfect, you'll get the idea with:
   git grep -B2 -A10 retu.*kstrtobool | grep __setup -B10
---
 arch/x86/kernel/signal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
index 1504eb8d25aa..004cb30b7419 100644
--- a/arch/x86/kernel/signal.c
+++ b/arch/x86/kernel/signal.c
@@ -360,7 +360,7 @@  static bool strict_sigaltstack_size __ro_after_init = false;
 
 static int __init strict_sas_size(char *arg)
 {
-	return kstrtobool(arg, &strict_sigaltstack_size);
+	return kstrtobool(arg, &strict_sigaltstack_size) == 0;
 }
 __setup("strict_sas_size", strict_sas_size);