From patchwork Thu Jun 22 09:21:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 111570 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4937736vqr; Thu, 22 Jun 2023 02:34:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4idxt00cAGPy7S4idZHrAQje5AUhzVPlTPfVWe3XpF53rTXR9xTN6RRPUD8U3nqMx7uRUI X-Received: by 2002:a05:6a00:a86:b0:657:f26e:b01a with SMTP id b6-20020a056a000a8600b00657f26eb01amr8894977pfl.26.1687426442743; Thu, 22 Jun 2023 02:34:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687426442; cv=none; d=google.com; s=arc-20160816; b=EntYnE2eY1GyHF7I+OKktVEbreyM7UvOuVYqgJZrNOcysuUFSxz1mpfe0S2vRvuK+8 Pz6P+dlrwqumkQF+rV08+23D+mIjnudPGj4yjhJNjTES7hroaq7UPNunK5JlT6xhuzar IeCZ5LixuuMyRSkhBuHhGARikWT/8iVtsPR2fT1d4Hh0QcYBd5cLGUTjhXegDJbqitSU z6EPs4QpfE0h/L14Xk3H+YMIpFsysV6sWbI+MMvlnNGI9N61ejF715kvmHMuSyOax9nk 88sVlboyvSbE+Sqs1ZSlqgbDbNP0jiqlLW53kYspWxiNSH82dsJ54xLDRCMPgHUm2mG+ Vt4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=jibTCEI+qGllXRWK/Xyw5Fy8fcL6xvauDpvziKS8f4g=; b=KPQchkH6HoddMlu5hi71A5Bdv9USWaq5rnH834Y8N+ASeUHU54dOtmJWOrzzLl6phY n0DVUxkTPT2SgULrcVwnDgL5L2R1QwbXUNfSfJF+14gjb6pDcn/q+jiClLRe+znFvdCN BlRlibHaIWUH1xV/uhIYPQs6EasE0Wo327U8mnrpAMgrc6IjwZ4DDbXu3CBm633v7NXz bYnnn5B1gxqxbJonZxzW3RyrWZ+l0ctX0TiH2oeg4HxRinF5HDBwJ7/FdxqUvc64l7Hv xWf26i0iGFE6ttcJm3RnX0MkrQkPW8AIyAZ5QNoAofAHp6KgtPjq/9K7uzxZKalT40db nkzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s30-20020a63925e000000b0054fd8d57b1esi4614253pgn.668.2023.06.22.02.33.44; Thu, 22 Jun 2023 02:34:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbjFVJcR (ORCPT + 99 others); Thu, 22 Jun 2023 05:32:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbjFVJaI (ORCPT ); Thu, 22 Jun 2023 05:30:08 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4DB84EDE for ; Thu, 22 Jun 2023 02:22:48 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:991a:a831:ea4b:6058]) by xavier.telenet-ops.be with bizsmtp id C9Nj2A0131yfRTD019NjEq; Thu, 22 Jun 2023 11:22:44 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qCGWY-000BxS-7R; Thu, 22 Jun 2023 11:22:43 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qCGWZ-003VyC-QU; Thu, 22 Jun 2023 11:22:43 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 33/39] drm: renesas: shmobile: Cleanup encoder Date: Thu, 22 Jun 2023 11:21:45 +0200 Message-Id: <736a0b26a9393f82769b185e2daa30eb128ff240.1687423204.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769394869236972359?= X-GMAIL-MSGID: =?utf-8?q?1769394869236972359?= Most unused callbacks can be NULL pointers these days. Drop a bunch of empty encoder callbacks. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c index b184019d8b1ed89c..ef327da39bca415a 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c @@ -586,11 +586,6 @@ int shmob_drm_crtc_create(struct shmob_drm_device *sdev) * Encoder */ -static void shmob_drm_encoder_dpms(struct drm_encoder *encoder, int mode) -{ - /* No-op, everything is handled in the CRTC code. */ -} - static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode) @@ -613,29 +608,8 @@ static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, return true; } -static void shmob_drm_encoder_mode_prepare(struct drm_encoder *encoder) -{ - /* No-op, everything is handled in the CRTC code. */ -} - -static void shmob_drm_encoder_mode_set(struct drm_encoder *encoder, - struct drm_display_mode *mode, - struct drm_display_mode *adjusted_mode) -{ - /* No-op, everything is handled in the CRTC code. */ -} - -static void shmob_drm_encoder_mode_commit(struct drm_encoder *encoder) -{ - /* No-op, everything is handled in the CRTC code. */ -} - static const struct drm_encoder_helper_funcs encoder_helper_funcs = { - .dpms = shmob_drm_encoder_dpms, .mode_fixup = shmob_drm_encoder_mode_fixup, - .prepare = shmob_drm_encoder_mode_prepare, - .commit = shmob_drm_encoder_mode_commit, - .mode_set = shmob_drm_encoder_mode_set, }; int shmob_drm_encoder_create(struct shmob_drm_device *sdev)