From patchwork Wed Jan 10 15:42:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 186939 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp875161dyi; Wed, 10 Jan 2024 07:44:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGG+mVfNFN+Lfgz4voAD/LlW5c/NHA3YLnhl++u0ij29yLAeMUmmQwYJjkb5mrYByqxy0xH X-Received: by 2002:a05:6e02:180c:b0:35f:ebc7:663a with SMTP id a12-20020a056e02180c00b0035febc7663amr1869841ilv.29.1704901483069; Wed, 10 Jan 2024 07:44:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704901483; cv=none; d=google.com; s=arc-20160816; b=oWCKrPK54B+GHHkAUeE3th3DyA5dr/nDx2GvqM2HegvKG10YoZEUcYuV04R6nsoEHX W2q1BkN+GUbHvVZMjCiOwbLhuRML6JxmbpmA/EkY8xSvGferlZX2y3/hKZpKZGeh5hXw yO7lqrrzYBg1eOv6b8dCXp+j7QwSpuCsHRx4B0Zs/2Yv+rZmOCrbEsfK/usErcmqBqdJ CBhUsySXuHlLm7ZlHZ/cCz9WJO63n95DlCK8KCj2/GAiSQoEJahET3FmjGma+Xn4xnqo IX7vse8AbSVHstfdrZXuXUvC9eMxvXH1IlCrr3g2qEHOH12ZmtUyBjd3ck81UkOBn/xZ Rbyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=3DErZVgIxqv0ItQdb58B7uTIix1D2K6jmFyPouZra0w=; fh=SqPi9dDHXtQdEcWVPls+hhXQkWQrXyuO3Tueytp7Eac=; b=JelTk8p6hBYls4QMGXGl0zKVhjt8jyg0Js6CROtrFuC39Hf9MgV/h4UR9c2r1cczPs +X5MbsBHTSdofYckIMnwTg7brCJlmUgqgq7BS/RNPAKxvCiRlDWG0U0n8GHMHnNXrPmH P25+Y2+KZG/4EFwgEZZNDzbHF1myhhYXUFjUetkmisOV4gUUKAJSNX+YdisFWbzrVdGo 9VUhaxokRlzOGFRweY8e2dcw07NA+aVSV43Qs3Y2azkqtKkcHmCCW63fi36mOJO4sJu+ LE5S3+BDv+FjHh9KHTykot8C2ihtLFqAIjYSBxo/2nidOQg/1UVETtN4+5h+qiZoWbo3 GIZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-22444-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22444-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id y67-20020a636446000000b005cee9115685si3914230pgb.496.2024.01.10.07.44.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 07:44:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-22444-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-22444-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22444-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D192C286255 for ; Wed, 10 Jan 2024 15:44:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2EB3A4CE07; Wed, 10 Jan 2024 15:43:27 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3673EA80 for ; Wed, 10 Jan 2024 15:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNajS-0007JL-EX; Wed, 10 Jan 2024 16:43:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNajS-001jUk-1Y; Wed, 10 Jan 2024 16:43:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNajR-006c4X-38; Wed, 10 Jan 2024 16:43:05 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] macintosh: windfarm_pm81: Convert to platform remove callback returning void Date: Wed, 10 Jan 2024 16:42:52 +0100 Message-ID: <725a17c7fb1bbe6d827b38bbee40494aebf9c06d.1704900449.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1754; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=JIumVAh3vPYREF//u7bkB7EN6JDIcq7JQV0/55+tgig=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlnrr9cGJf6iwan3BelkYvjxz1rORpYhL3KQpVA H9WZZ5TI1WJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZZ66/QAKCRCPgPtYfRL+ TriLB/wMDX8j2YkG3CwhSFKfGseVipaO6qkUR7ahpC0Up2CnkrqOwZAobIsf3dw0Y/01I0ZNjtc 8+8LchW5znSHRLxrlQBxaCoeN1dKsRNtzRRkf+vHnAQ53cG9J3OLv7hBL1J+2WtgT6nrZ8VjLqX U1RKwAMSzpK1UzOZs1BUrfpXhNQNigflasKZUFYTfDP/uHGRtATepZ/SNqMKG0XZ9kSbVVrDEcj uNzXxdWCArERgcm9ufu+623M897Wzo6B46xttPUtXAdDQ/PsS2x6iITCaoSlbxFiffqIswxbLyE 0BzKDEr3DmmT0xNnzNC2zLxFrOt+ZszHMFOat94qUpmNvHGT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787718777580741872 X-GMAIL-MSGID: 1787718777580741872 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/windfarm_pm81.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/macintosh/windfarm_pm81.c b/drivers/macintosh/windfarm_pm81.c index 257fb2c695c5..404d2454e33d 100644 --- a/drivers/macintosh/windfarm_pm81.c +++ b/drivers/macintosh/windfarm_pm81.c @@ -724,7 +724,7 @@ static int wf_smu_probe(struct platform_device *ddev) return 0; } -static int wf_smu_remove(struct platform_device *ddev) +static void wf_smu_remove(struct platform_device *ddev) { wf_unregister_client(&wf_smu_events); @@ -761,13 +761,11 @@ static int wf_smu_remove(struct platform_device *ddev) /* Destroy control loops state structures */ kfree(wf_smu_sys_fans); kfree(wf_smu_cpu_fans); - - return 0; } static struct platform_driver wf_smu_driver = { - .probe = wf_smu_probe, - .remove = wf_smu_remove, + .probe = wf_smu_probe, + .remove_new = wf_smu_remove, .driver = { .name = "windfarm", },