From patchwork Thu Mar 9 20:26:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 67089 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp503853wrd; Thu, 9 Mar 2023 12:32:51 -0800 (PST) X-Google-Smtp-Source: AK7set8PIOz2Cm50Cr7uQe/XKRp+Px6TajLE92Lsxv+KW+wvksYbdH7LJ4NTelAMHvyQUDMS77Zx X-Received: by 2002:a17:90b:1b4e:b0:233:ee67:8eb3 with SMTP id nv14-20020a17090b1b4e00b00233ee678eb3mr23610525pjb.24.1678393971619; Thu, 09 Mar 2023 12:32:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678393971; cv=none; d=google.com; s=arc-20160816; b=z/b0+JvCu4TXkIw8/yeNedaN+BsjATKEaFAvEeEJTvy4sFeYM+1MunuroRzaRiHF8F eNtzrgsSAAibrnj38C12F/3a1e0z08okvjhYG1nHRB251h+KaFqqZ9ZvZ2MHVGCA7l/R xtt/jZIgahTOrhkO7fRr+EbsoiQjuWxXqvWa41+uYU6v1bgtr4pyAOtZZ85ioFdI+lxT hbvlywheL+hMVNtNTSoC39V22G0GOKtHgxJ4fkQJyK1PSkV5IJQ3tsxBgiRoPlYA/eaZ lr/cUzjyHbplyaAgpkr2UX7bwOK+SGR+APJsFLuHVOXANRT2ixu1krapaj45CfnefrUd tHlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:subject:from:cc:to :in-reply-to:content-language:user-agent:mime-version:date :message-id:dkim-signature; bh=qHtnZady8MO5P+SxKXbSQQ1axjJ6o1RkSBId0/l8vfY=; b=d+O1zJ/kCMGZF7euc1Tsn7Fp+F+NtPDWvSfVdtgHWmqyRNxtV3UUlVx/F3NzRdeIbg kUIAc8ht2DRcJFVPRiqK1tBTf1/L4D0IznqyLHHaVsErYgZl3FL7gp9COHcFSKj/UgdM kBzfV0I/Im7Yj7ic1RuDtIXipTY42ppR2f9xvAxyoFzI+Zzp1Z5QAWrAwogrrUoG/yr4 fXpmAxmY3hPJfpk7qKP/xe0Q16pImPw3Jz/Yo0ODHhMXjua0oYsR5soC6l/ptAeSmFHm COPe/nu+Td0LzsWHzIIK0D/sjSktT4x+B06McV0XTh33Y0Z/1RNgnpDrc9hHaqmsLy62 uztg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=BM1cE+z+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f3-20020a17090ac28300b00225f3e34336si673884pjt.89.2023.03.09.12.32.34; Thu, 09 Mar 2023 12:32:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=BM1cE+z+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229751AbjCIU3J (ORCPT + 99 others); Thu, 9 Mar 2023 15:29:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjCIU3G (ORCPT ); Thu, 9 Mar 2023 15:29:06 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CA4D65AE; Thu, 9 Mar 2023 12:29:03 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 80F165FD1B; Thu, 9 Mar 2023 23:29:01 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1678393741; bh=qHtnZady8MO5P+SxKXbSQQ1axjJ6o1RkSBId0/l8vfY=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type; b=BM1cE+z+UXNOGOh/Z25liYbmVfs1mS1SWXYiysOj9dV1n1Cvividvl/KhRAFROcOZ R5SxlhNRkIAJ95LLurt1Ssa0rzfwl/vXDns4VxeD3y6ycNwszqO0VFbvUCJOIyJF44 qjYVbYI8lRiJCwf5MDPvlBWArI4EPBN927KlTIn3dqh/9AVNywH1oEJMe6cwnQM5PM /ZT7NvFnF2vEugClgiuFVk+iwMKuety+FZ8D1EP+mMxoS1p1JI7pJwpw4wDk68BKKa GoeSdNqCa8Oi8KlymXD1Z/V+c8N2d48DF+gxUZTdyomLHNLMoXmtsbPgLGGlpInAAu iLBzuKCfO0jWw== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Thu, 9 Mar 2023 23:29:01 +0300 (MSK) Message-ID: <71a296ad-6619-c8e6-14a1-9423ac2e4841@sberdevices.ru> Date: Thu, 9 Mar 2023 23:26:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US In-Reply-To: <1804d100-1652-d463-8627-da93cb61144e@sberdevices.ru> To: Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bobby Eshleman CC: , , , , , , From: Arseniy Krasnov Subject: [RFC PATCH v4 1/4] virtio/vsock: don't use skbuff state to account credit X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/03/09 18:14:00 #20929517 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759923636854342832?= X-GMAIL-MSGID: =?utf-8?q?1759923636854342832?= 'skb->len' can vary when we partially read the data, this complicates the calculation of credit to be updated in 'virtio_transport_inc_rx_pkt()/ virtio_transport_dec_rx_pkt()'. Also in 'virtio_transport_dec_rx_pkt()' we were miscalculating the credit since 'skb->len' was redundant. For these reasons, let's replace the use of skbuff state to calculate new 'rx_bytes'/'fwd_cnt' values with explicit value as input argument. This makes code more simple, because it is not needed to change skbuff state before each call to update 'rx_bytes'/'fwd_cnt'. Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff") Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella --- net/vmw_vsock/virtio_transport_common.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index a1581c77cf84..618680fd9906 100644 --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c @@ -241,21 +241,18 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk, } static bool virtio_transport_inc_rx_pkt(struct virtio_vsock_sock *vvs, - struct sk_buff *skb) + u32 len) { - if (vvs->rx_bytes + skb->len > vvs->buf_alloc) + if (vvs->rx_bytes + len > vvs->buf_alloc) return false; - vvs->rx_bytes += skb->len; + vvs->rx_bytes += len; return true; } static void virtio_transport_dec_rx_pkt(struct virtio_vsock_sock *vvs, - struct sk_buff *skb) + u32 len) { - int len; - - len = skb_headroom(skb) - sizeof(struct virtio_vsock_hdr) - skb->len; vvs->rx_bytes -= len; vvs->fwd_cnt += len; } @@ -388,7 +385,9 @@ virtio_transport_stream_do_dequeue(struct vsock_sock *vsk, skb_pull(skb, bytes); if (skb->len == 0) { - virtio_transport_dec_rx_pkt(vvs, skb); + u32 pkt_len = le32_to_cpu(virtio_vsock_hdr(skb)->len); + + virtio_transport_dec_rx_pkt(vvs, pkt_len); consume_skb(skb); } else { __skb_queue_head(&vvs->rx_queue, skb); @@ -437,17 +436,17 @@ static int virtio_transport_seqpacket_do_dequeue(struct vsock_sock *vsk, while (!msg_ready) { struct virtio_vsock_hdr *hdr; + size_t pkt_len; skb = __skb_dequeue(&vvs->rx_queue); if (!skb) break; hdr = virtio_vsock_hdr(skb); + pkt_len = (size_t)le32_to_cpu(hdr->len); if (dequeued_len >= 0) { - size_t pkt_len; size_t bytes_to_copy; - pkt_len = (size_t)le32_to_cpu(hdr->len); bytes_to_copy = min(user_buf_len, pkt_len); if (bytes_to_copy) { @@ -484,7 +483,7 @@ static int virtio_transport_seqpacket_do_dequeue(struct vsock_sock *vsk, msg->msg_flags |= MSG_EOR; } - virtio_transport_dec_rx_pkt(vvs, skb); + virtio_transport_dec_rx_pkt(vvs, pkt_len); kfree_skb(skb); } @@ -1040,7 +1039,7 @@ virtio_transport_recv_enqueue(struct vsock_sock *vsk, spin_lock_bh(&vvs->rx_lock); - can_enqueue = virtio_transport_inc_rx_pkt(vvs, skb); + can_enqueue = virtio_transport_inc_rx_pkt(vvs, len); if (!can_enqueue) { free_pkt = true; goto out;