diff mbox series

m68k: defconfig: Update virt_defconfig for v6.6-rc3

Message ID 6f30b86b83b972e9902b62295f397a20512d5507.1695977960.git.geert@linux-m68k.org
State New
Headers
Series m68k: defconfig: Update virt_defconfig for v6.6-rc3 |

Commit Message

Geert Uytterhoeven Sept. 29, 2023, 9:01 a.m. UTC 
  - Enable CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE (no longer
    auto-enabled since commit bb6c4507fe825f1b ("drm: fix up fbdev
    Kconfig defaults")),
  - Drop CONFIG_FRAMEBUFFER_CONSOLE=y (auto-enabled since commit
    bb6c4507fe825f1b ("drm: fix up fbdev Kconfig defaults")).

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Perhaps CONFIG_FB_DEVICE should not be enabled?

To be queued in the m68k for-v6.7 branch.
---
 arch/m68k/configs/virt_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Laurent Vivier Sept. 29, 2023, 9:44 a.m. UTC | #1 
Le 29/09/2023 à 11:01, Geert Uytterhoeven a écrit :
>    - Enable CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE (no longer
>      auto-enabled since commit bb6c4507fe825f1b ("drm: fix up fbdev
>      Kconfig defaults")),
>    - Drop CONFIG_FRAMEBUFFER_CONSOLE=y (auto-enabled since commit
>      bb6c4507fe825f1b ("drm: fix up fbdev Kconfig defaults")).
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Perhaps CONFIG_FB_DEVICE should not be enabled?

Why do you think it should not be enabled?

I think X was needing this to work on m68k.

Thanks,
Laurent

> 
> To be queued in the m68k for-v6.7 branch.
> ---
>   arch/m68k/configs/virt_defconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/m68k/configs/virt_defconfig b/arch/m68k/configs/virt_defconfig
> index 3afc6762b0946aa6..ec021a1d48ee7d86 100644
> --- a/arch/m68k/configs/virt_defconfig
> +++ b/arch/m68k/configs/virt_defconfig
> @@ -47,8 +47,9 @@ CONFIG_INPUT_EVDEV=y
>   CONFIG_VIRTIO_CONSOLE=y
>   CONFIG_HW_RANDOM_VIRTIO=y
>   CONFIG_DRM=y
> +CONFIG_DRM_FBDEV_EMULATION=y
>   CONFIG_DRM_VIRTIO_GPU=y
> -CONFIG_FRAMEBUFFER_CONSOLE=y
> +CONFIG_FB_DEVICE=y
>   CONFIG_SOUND=y
>   CONFIG_SND=y
>   CONFIG_SND_VIRTIO=y
Geert Uytterhoeven Sept. 29, 2023, 10:03 a.m. UTC | #2 
Hi Laurent,

On Fri, Sep 29, 2023 at 11:44 AM Laurent Vivier <laurent@vivier.eu> wrote:
> Le 29/09/2023 à 11:01, Geert Uytterhoeven a écrit :
> >    - Enable CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE (no longer
> >      auto-enabled since commit bb6c4507fe825f1b ("drm: fix up fbdev
> >      Kconfig defaults")),
> >    - Drop CONFIG_FRAMEBUFFER_CONSOLE=y (auto-enabled since commit
> >      bb6c4507fe825f1b ("drm: fix up fbdev Kconfig defaults")).
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > Perhaps CONFIG_FB_DEVICE should not be enabled?
>
> Why do you think it should not be enabled?

Because virt uses virtio_gpudrm.

> I think X was needing this to work on m68k.

Perhaps a version of X or Wayland can work with virtio_gpudrm
directly, without needing DRM's fbdev emulation and /dev/fb0?

DRM's fbdev emulation is still needed for the text console, of course.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/arch/m68k/configs/virt_defconfig b/arch/m68k/configs/virt_defconfig
index 3afc6762b0946aa6..ec021a1d48ee7d86 100644
--- a/arch/m68k/configs/virt_defconfig
+++ b/arch/m68k/configs/virt_defconfig
@@ -47,8 +47,9 @@  CONFIG_INPUT_EVDEV=y
 CONFIG_VIRTIO_CONSOLE=y
 CONFIG_HW_RANDOM_VIRTIO=y
 CONFIG_DRM=y
+CONFIG_DRM_FBDEV_EMULATION=y
 CONFIG_DRM_VIRTIO_GPU=y
-CONFIG_FRAMEBUFFER_CONSOLE=y
+CONFIG_FB_DEVICE=y
 CONFIG_SOUND=y
 CONFIG_SND=y
 CONFIG_SND_VIRTIO=y