diff mbox series

[3/3] ARM: dts: at91: Return to boolean properties

Message ID 6f06be9e393c02563bc877498c8af75daf3b47f8.1684313910.git.Ryan.Wanner@microchip.com
State New
Headers
Series AT91 PIO4 push-pull enable |

Commit Message

Ryan.Wanner@microchip.com May 17, 2023, 11:54 a.m. UTC 
  From: Ryan Wanner <Ryan.Wanner@microchip.com>

Returning back to commit 0dc23d1a8e17
("arm: dts: at91: Fix boolean properties with values") as pinctrl driver no
longer expects an integer value and expects a simple boolean property.

Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
---
 arch/arm/boot/dts/at91-kizbox3-hs.dts      | 2 +-
 arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Nicolas Ferre May 22, 2023, 9:22 a.m. UTC | #1 
On 17/05/2023 at 13:54, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
> 
> Returning back to commit 0dc23d1a8e17
> ("arm: dts: at91: Fix boolean properties with values") as pinctrl driver no
> longer expects an integer value and expects a simple boolean property.
> 
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>

Okay:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks for fixing this as well. Best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/at91-kizbox3-hs.dts      | 2 +-
>   arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-kizbox3-hs.dts b/arch/arm/boot/dts/at91-kizbox3-hs.dts
> index 7075df6549e9..fec7269088d1 100644
> --- a/arch/arm/boot/dts/at91-kizbox3-hs.dts
> +++ b/arch/arm/boot/dts/at91-kizbox3-hs.dts
> @@ -225,7 +225,7 @@ pinctrl_pio_zbe_rst: gpio_zbe_rst {
>   		pinctrl_pio_io_reset: gpio_io_reset {
>   			pinmux = <PIN_PB30__GPIO>;
>   			bias-disable;
> -			drive-open-drain = <1>;
> +			drive-open-drain;
>   			output-low;
>   		};
>   		pinctrl_pio_input: gpio_input {
> diff --git a/arch/arm/boot/dts/at91-kizbox3_common.dtsi b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> index abe27adfa4d6..465664628419 100644
> --- a/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> +++ b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> @@ -211,7 +211,7 @@ pinctrl_flx4_default: flx4_i2c6_default {
>   		pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA
>   		<PIN_PD13__FLEXCOM4_IO1>; //CLK
>   		bias-disable;
> -		drive-open-drain = <1>;
> +		drive-open-drain;
>   	};
>   
>   	pinctrl_pwm0 {
Claudiu Beznea May 23, 2023, 5:05 a.m. UTC | #2 
On 22.05.2023 12:22, Nicolas Ferre wrote:
> On 17/05/2023 at 13:54, Ryan.Wanner@microchip.com wrote:
>> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>>
>> Returning back to commit 0dc23d1a8e17
>> ("arm: dts: at91: Fix boolean properties with values") as pinctrl driver no
>> longer expects an integer value and expects a simple boolean property.
>>
>> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> 
> Okay:
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Applied to at91-dt, thanks!

> 
> Thanks for fixing this as well. Best regards,
>   Nicolas
> 
>> ---
>>   arch/arm/boot/dts/at91-kizbox3-hs.dts      | 2 +-
>>   arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-kizbox3-hs.dts
>> b/arch/arm/boot/dts/at91-kizbox3-hs.dts
>> index 7075df6549e9..fec7269088d1 100644
>> --- a/arch/arm/boot/dts/at91-kizbox3-hs.dts
>> +++ b/arch/arm/boot/dts/at91-kizbox3-hs.dts
>> @@ -225,7 +225,7 @@ pinctrl_pio_zbe_rst: gpio_zbe_rst {
>>           pinctrl_pio_io_reset: gpio_io_reset {
>>               pinmux = <PIN_PB30__GPIO>;
>>               bias-disable;
>> -            drive-open-drain = <1>;
>> +            drive-open-drain;
>>               output-low;
>>           };
>>           pinctrl_pio_input: gpio_input {
>> diff --git a/arch/arm/boot/dts/at91-kizbox3_common.dtsi
>> b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
>> index abe27adfa4d6..465664628419 100644
>> --- a/arch/arm/boot/dts/at91-kizbox3_common.dtsi
>> +++ b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
>> @@ -211,7 +211,7 @@ pinctrl_flx4_default: flx4_i2c6_default {
>>           pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA
>>           <PIN_PD13__FLEXCOM4_IO1>; //CLK
>>           bias-disable;
>> -        drive-open-drain = <1>;
>> +        drive-open-drain;
>>       };
>>         pinctrl_pwm0 {
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/at91-kizbox3-hs.dts b/arch/arm/boot/dts/at91-kizbox3-hs.dts
index 7075df6549e9..fec7269088d1 100644
--- a/arch/arm/boot/dts/at91-kizbox3-hs.dts
+++ b/arch/arm/boot/dts/at91-kizbox3-hs.dts
@@ -225,7 +225,7 @@  pinctrl_pio_zbe_rst: gpio_zbe_rst {
 		pinctrl_pio_io_reset: gpio_io_reset {
 			pinmux = <PIN_PB30__GPIO>;
 			bias-disable;
-			drive-open-drain = <1>;
+			drive-open-drain;
 			output-low;
 		};
 		pinctrl_pio_input: gpio_input {
diff --git a/arch/arm/boot/dts/at91-kizbox3_common.dtsi b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
index abe27adfa4d6..465664628419 100644
--- a/arch/arm/boot/dts/at91-kizbox3_common.dtsi
+++ b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
@@ -211,7 +211,7 @@  pinctrl_flx4_default: flx4_i2c6_default {
 		pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA
 		<PIN_PD13__FLEXCOM4_IO1>; //CLK
 		bias-disable;
-		drive-open-drain = <1>;
+		drive-open-drain;
 	};
 
 	pinctrl_pwm0 {