From patchwork Thu May 18 08:21:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Daisuke Matsuda (Fujitsu)" X-Patchwork-Id: 95699 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp326582vqo; Thu, 18 May 2023 01:24:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7qFTvTZxhW2ncUCE3NnQ/nn6NP6tr8svCKYoUaKl4FKwwcAKPkoyDJpd4ZGKk6MrIS3VFc X-Received: by 2002:a05:6a00:1a89:b0:62d:d045:392 with SMTP id e9-20020a056a001a8900b0062dd0450392mr3487108pfv.32.1684398249572; Thu, 18 May 2023 01:24:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684398249; cv=none; d=google.com; s=arc-20160816; b=wP2cDE2ll324N4po2uLoCELI17bn/bHhCPayNT/ruX4HmJWODdAXgGROgjAiI2JjXr xjL/tqdkCdeiw/v8bJOCvF0hPq3rRJQNCa66G7pV7Go7ab2wF3WEvC9xzYmGWTJf8Wjt cu12BxifAyeeqYVl6hrQAz+oaZFY7YwtVhJdn+WmzBnJbPG2gtI6BMhS8eotxO4MagW4 V/GjS0jJZ6DpyvUekucCGqJi6ghQyXvsFiowFqLdcxkeMVLboEch3D6p76jr4sATqox8 hnGzx1vLfekkmT/10N06XaVI4kn5BaAPHguq+BzJmaBdPaWyXSnbHOcG4MUlDGl7s+Os RojQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/d/gKhpixQ0HVmDOvua8D34bbXr8rQNaqkp6usVN8CQ=; b=HCRT1STcI/oppiiT2T8ek6p4+/nom+TS02A8f+F37Jcn7Shg9OwT5ZHrMsYjIcniN/ fpd02NlODvkjawUMoGNbnhpU7IMrfCreBSU7yenXQRqGnMQ+L+luCHE0EuED+kWND43Y 3dAEpHoXZUx88ZTerWMFsj3I9mZSNMx7O8PMn/ntsGyg8YtMRibBXNTaX+TmRl5q5zPh Ogzq1wmG79ERdAV6Ph8ybJdAVqs3fYYxEPn9KagX/QFaXZmh6HLR7zJSXo1AAZ5xxKR8 gJ3NJms6yh/FaNdBVdtYrnOVGHv8nXLpU0vp5S5OP3sYRTWIP7NdalLI85ifCJ0jB1/+ jpeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j76-20020a636e4f000000b00518f82d7053si885294pgc.493.2023.05.18.01.23.57; Thu, 18 May 2023 01:24:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230120AbjERIWn (ORCPT + 99 others); Thu, 18 May 2023 04:22:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbjERIWd (ORCPT ); Thu, 18 May 2023 04:22:33 -0400 Received: from esa3.hc1455-7.c3s2.iphmx.com (esa3.hc1455-7.c3s2.iphmx.com [207.54.90.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11E2ADF; Thu, 18 May 2023 01:22:31 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="117164683" X-IronPort-AV: E=Sophos;i="5.99,284,1677510000"; d="scan'208";a="117164683" Received: from unknown (HELO oym-r3.gw.nic.fujitsu.com) ([210.162.30.91]) by esa3.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2023 17:22:29 +0900 Received: from oym-m3.gw.nic.fujitsu.com (oym-nat-oym-m3.gw.nic.fujitsu.com [192.168.87.60]) by oym-r3.gw.nic.fujitsu.com (Postfix) with ESMTP id 52A0AD6473; Thu, 18 May 2023 17:22:27 +0900 (JST) Received: from m3004.s.css.fujitsu.com (m3004.s.css.fujitsu.com [10.128.233.124]) by oym-m3.gw.nic.fujitsu.com (Postfix) with ESMTP id 83F64D94AA; Thu, 18 May 2023 17:22:26 +0900 (JST) Received: from localhost.localdomain (unknown [10.118.237.106]) by m3004.s.css.fujitsu.com (Postfix) with ESMTP id 3FB84200A4E1; Thu, 18 May 2023 17:22:26 +0900 (JST) From: Daisuke Matsuda To: linux-rdma@vger.kernel.org, leonro@nvidia.com, jgg@nvidia.com, zyjzyj2000@gmail.com Cc: linux-kernel@vger.kernel.org, rpearsonhpe@gmail.com, yangx.jy@fujitsu.com, lizhijian@fujitsu.com, y-goto@fujitsu.com, Daisuke Matsuda Subject: [PATCH for-next v5 4/7] RDMA/rxe: Add page invalidation support Date: Thu, 18 May 2023 17:21:49 +0900 Message-Id: <6e9d5e2d1b2a63385d1e4fc2a74c3b11d4909842.1684397037.git.matsuda-daisuke@fujitsu.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766219578902774007?= X-GMAIL-MSGID: =?utf-8?q?1766219578902774007?= On page invalidation, an MMU notifier callback is invoked to unmap DMA addresses and update the driver page table(umem_odp->dma_list). It also set the corresponding entries in MR xarray to NULL to prevent any access. The callback is registered when an ODP-enabled MR is created. Signed-off-by: Daisuke Matsuda Reviewed-by: Bob Pearson --- drivers/infiniband/sw/rxe/Makefile | 2 ++ drivers/infiniband/sw/rxe/rxe_odp.c | 56 +++++++++++++++++++++++++++++ 2 files changed, 58 insertions(+) create mode 100644 drivers/infiniband/sw/rxe/rxe_odp.c diff --git a/drivers/infiniband/sw/rxe/Makefile b/drivers/infiniband/sw/rxe/Makefile index 5395a581f4bb..93134f1d1d0c 100644 --- a/drivers/infiniband/sw/rxe/Makefile +++ b/drivers/infiniband/sw/rxe/Makefile @@ -23,3 +23,5 @@ rdma_rxe-y := \ rxe_task.o \ rxe_net.o \ rxe_hw_counters.o + +rdma_rxe-$(CONFIG_INFINIBAND_ON_DEMAND_PAGING) += rxe_odp.o diff --git a/drivers/infiniband/sw/rxe/rxe_odp.c b/drivers/infiniband/sw/rxe/rxe_odp.c new file mode 100644 index 000000000000..b69b25e0fef6 --- /dev/null +++ b/drivers/infiniband/sw/rxe/rxe_odp.c @@ -0,0 +1,56 @@ +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB +/* + * Copyright (c) 2022-2023 Fujitsu Ltd. All rights reserved. + */ + +#include + +#include + +#include "rxe.h" + +static void rxe_mr_unset_xarray(struct rxe_mr *mr, unsigned long start, + unsigned long end) +{ + unsigned long lower, upper, idx; + + lower = rxe_mr_iova_to_index(mr, start); + upper = rxe_mr_iova_to_index(mr, end); + + /* make elements in xarray NULL */ + spin_lock(&mr->page_list.xa_lock); + for (idx = lower; idx <= upper; idx++) + __xa_erase(&mr->page_list, idx); + spin_unlock(&mr->page_list.xa_lock); +} + +static bool rxe_ib_invalidate_range(struct mmu_interval_notifier *mni, + const struct mmu_notifier_range *range, + unsigned long cur_seq) +{ + struct ib_umem_odp *umem_odp = + container_of(mni, struct ib_umem_odp, notifier); + struct rxe_mr *mr = umem_odp->private; + unsigned long start, end; + + if (!mmu_notifier_range_blockable(range)) + return false; + + mutex_lock(&umem_odp->umem_mutex); + mmu_interval_set_seq(mni, cur_seq); + + start = max_t(u64, ib_umem_start(umem_odp), range->start); + end = min_t(u64, ib_umem_end(umem_odp), range->end); + + rxe_mr_unset_xarray(mr, start, end); + + /* update umem_odp->dma_list */ + ib_umem_odp_unmap_dma_pages(umem_odp, start, end); + + mutex_unlock(&umem_odp->umem_mutex); + return true; +} + +const struct mmu_interval_notifier_ops rxe_mn_ops = { + .invalidate = rxe_ib_invalidate_range, +};