From patchwork Sun Jun 25 14:17:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Adri=C3=A1n_Larumbe?= X-Patchwork-Id: 112610 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp6968753vqr; Sun, 25 Jun 2023 08:22:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5hChv9sI8jjVLxfBlbbWSemQvnPoU9mWmqT0IBiggGbiiNt26BqXSW9PfOVHjPk8kj+Q3G X-Received: by 2002:a17:907:9450:b0:989:3670:3696 with SMTP id dl16-20020a170907945000b0098936703696mr12756961ejc.58.1687706575440; Sun, 25 Jun 2023 08:22:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687706575; cv=none; d=google.com; s=arc-20160816; b=bRP9/6DFADdvvcApaEc6XNyui4ujUS/pysBn7Lhh41Hi7C6AZ5yZ1KnASnIaAr/vnA drmjApK2EKoBH0w7sm+4o+aoFu7OnQdMxwRyNLu8mKIYiNXwk7D2QRHVXIrqfhO9YWjX E77gbjO/HG2ReDVK5qgI+H1WrYn0P/237oaqHl0TuJJHq+pTqvJ833qbFVpK8xtzSHwr Ay5ZHUMG4Lapyc5ebfo7jn8RAr+EsKXdvuSswiopfZoH79fgMrONSNrBwkzxWYnuuyVx aKnz+V+zvEZAPp3dzIzCHYNO+p2C0FdJtWXhS89vmV00kOuArbIaFD6vmixZgs5vzlS6 7Qcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SjXcvT+ogBEwuOo04XpwNmn5/JBm9stCxvy1+I1vM1A=; fh=WPuWzpaBwdto9m67kHHG5v3eBoth1LP2radJRBylFHQ=; b=DrVFdgYEOK2rKzZNQwYfQRosliCKaKZP8jq8F0EfkAS7Bpfu32M/aVfU+kx6a3kp4K HcFXvOqWGOA6lLD87fQjim9BN2zAOZYI6RU6Kvnd7sHp6ulQA1429uFs0ge1fSYwctlH 8SlvXjkEJG1juJ3xqceLp4uwSmLKJasd8y9v3PZp4JHfkQ5E89XrEwV5giwchM3xRP2M lVb49CdCEc5C+c8cLcpdBKXXY2fSRe/5PWhDNiD28KO7WhJ6uVNLmQ4sSVUnXELQ8E5I PKgloc3egnsN6CWq8qcOdDPZEhrwftnOWb70N/vv/LiwVZpfyB6CybXcx8MtTHYPIPW8 D1zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=FGZrClUa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a2-20020a1709065f8200b0098867fad438si2002262eju.479.2023.06.25.08.22.31; Sun, 25 Jun 2023 08:22:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=FGZrClUa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230102AbjFYORu (ORCPT + 99 others); Sun, 25 Jun 2023 10:17:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230029AbjFYORp (ORCPT ); Sun, 25 Jun 2023 10:17:45 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 319DAE4E for ; Sun, 25 Jun 2023 07:17:44 -0700 (PDT) Received: from sobremesa.fritz.box (unknown [IPv6:2a02:8010:65b5:0:bbb0:f8ec:7bc9:dbe4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: alarumbe) by madras.collabora.co.uk (Postfix) with ESMTPSA id 99EA76607134; Sun, 25 Jun 2023 15:17:42 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1687702662; bh=hy/yPAn2uSB4ki0Kb6pM9nocxr+HExnkKdS5jKFuPcs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FGZrClUaLXMLHLNUlXTRCZS7MdYYm5CKkv4TIIOa/WeEtz8nwbRNvxDJwQcnkpmUr 1yQ+gEvrHl6IkZLAgAII0u3MVIzTnE6HWQmD+QV5hmcw/Lw/VR08ihjAhwl1dL4Cvj MeEXNDx6D+hyur1/ehh+B5tgHkX/0dXYZFZo3h0I92dMKAc905CZCS8EOJFdRbgtza ZqpsYyuXUzEjP/gRABmGT7LsmpI0oQSfdfHqRDLi1P8vl27z6Yc49SBerwgiEj96ys 48FhO6kzXj7ng2eGYDTifOg+y92+lW5JM/vKZe4VKXpn5VIJfU5ybsp334N28DbBzp i1/K2EGTjvyNA== From: =?utf-8?q?Adri=C3=A1n_Larumbe?= To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: =?utf-8?q?Adri=C3=A1n_Larumbe?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/3] drm/bridge: dw-hdmi: truly enforce 420-only formats when drm mode demands it Date: Sun, 25 Jun 2023 15:17:16 +0100 Message-Id: <6e6a217c180584a67ed7992c785764ba54af9151.1687702042.git.adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769688610403680158?= X-GMAIL-MSGID: =?utf-8?q?1769688610403680158?= The current output bus format selection logic is enforcing YUV420 even when the drm mode allows for other bus formats as well. Fix it by adding check for 420-only drm modes. Signed-off-by: Adrián Larumbe Acked-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index e6a456b72610..3a788316e2e5 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -2710,9 +2710,10 @@ static u32 *dw_hdmi_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge, /* Default 8bit fallback */ output_fmts[i++] = MEDIA_BUS_FMT_UYYVYY8_0_5X24; - *num_output_fmts = i; - - return output_fmts; + if (drm_mode_is_420_only(info, mode)) { + *num_output_fmts = i; + return output_fmts; + } } /*