From patchwork Wed Aug 16 09:50:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 135786 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b82d:0:b0:3f2:4152:657d with SMTP id z13csp98784vqi; Wed, 16 Aug 2023 08:37:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGWzOmNMvpFtkxZzXPcAgC/1hEo4iMMSEoHgG7HsQteU6luCWQ1afED8aZjnK9CLzjsDHKa X-Received: by 2002:a17:90a:1786:b0:263:72fe:3ef7 with SMTP id q6-20020a17090a178600b0026372fe3ef7mr1726313pja.42.1692200259072; Wed, 16 Aug 2023 08:37:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692200259; cv=none; d=google.com; s=arc-20160816; b=SdS4OhzMGN8/43QiufD1n11KMbfAZIS8y9SOw7GL1YJPvoEa2hCsV/0IvWQFI1ONAV wGDp9u45b93/cD+pGAB+TITCaaaT5NCfIm9eTkxAVL/wIt5DPZo0BAPFtg74c97u/di6 Nl9fawDAx4rXwNQX4AAPuQiVjuJQltWL5yq3aQZPsxyNkW7ja8tbTQSMenzhwSt5E33f Y2m02L8k+snw1BBRhEVZiFRNDnVYJsmNUcPwvgp27PWKH/RT1UjlYji3guTl4kU8fVxP cVO8acSbBTqA6lW9+HEDv69t75YxFftd43fzJnKl7KqgFkOgJ8HnL4BS0Rbpq3zAIEg5 iuWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=9Fib6qXdCwoXWV947g4VmHE4gc50y0vIQMvZ6Owev50=; fh=OmmZDJEp3pl7jaFV8O2/yN66VkuJIFqajAiD2ZUHFno=; b=LzrQnbSzHkuDOVRlWrr2jEc1Sen8ne0KfHNItA0V01PD2qU9+WwPhgJq5XcOq/39TD oi9A8qYfuSRCxoGMOZ72F3YI5shZdszP7eqKG6cUu/7LhqxtIS5ypu7VshXQnbmkM0Wb +llHlZx8UCStlSv8R1MGEgLilIlWOg+VkhOntQ0pgnXOdg3nL2pkmSFoNuayNzkkzqfs IjTx2ZlO1tvr1urkHlaY9m+/T1IYkYRuPt2YLN1dQ6BWp3XGB7mDGktouabv5wtLixLS FhkoOlg/j0bhdZ5gk3fG0O8mwj0h+1tNWWEIJXb50wG/I/hhqpsKuwKah1ybW7u4bjE2 t4yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u5-20020a17090ae00500b0026cffe764cesi711531pjy.39.2023.08.16.08.37.23; Wed, 16 Aug 2023 08:37:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244100AbjHPK5r (ORCPT + 99 others); Wed, 16 Aug 2023 06:57:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244147AbjHPKpT (ORCPT ); Wed, 16 Aug 2023 06:45:19 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7E142712 for ; Wed, 16 Aug 2023 03:45:08 -0700 (PDT) Received: from ramsan.of.borg ([84.195.187.55]) by xavier.telenet-ops.be with bizsmtp id aAki2A0071C8whw01AkixT; Wed, 16 Aug 2023 12:44:43 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qWE0x-000ot5-M6; Wed, 16 Aug 2023 12:44:42 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qWDAw-00674Z-F6; Wed, 16 Aug 2023 11:50:50 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart Subject: [PATCH v3 06/41] drm: renesas: shmobile: Correct encoder/connector types Date: Wed, 16 Aug 2023 11:50:13 +0200 Message-Id: <6ab083200f58434329fcc92492f4e6b09162bc96.1692178020.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774400578430206368 X-GMAIL-MSGID: 1774400578430206368 The first encoder output on the SH-Mobile LCD Controller is a DPI parallel bus. However, at the time of introduction of the driver, no encoder or connector types were defined yet for the DPI parallel bus, hence the driver used the ones for LVDS instead. Adjust the types accordingly. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v3: - No changes, v2: - Add Reviewed-by. --- drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c index 11dd2bc803e7cb62..fbfd906844da490c 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c @@ -598,7 +598,7 @@ int shmob_drm_encoder_create(struct shmob_drm_device *sdev) encoder->possible_crtcs = 1; ret = drm_simple_encoder_init(sdev->ddev, encoder, - DRM_MODE_ENCODER_LVDS); + DRM_MODE_ENCODER_DPI); if (ret < 0) return ret; @@ -684,7 +684,7 @@ int shmob_drm_connector_create(struct shmob_drm_device *sdev, connector->display_info.height_mm = sdev->pdata->panel.height_mm; ret = drm_connector_init(sdev->ddev, connector, &connector_funcs, - DRM_MODE_CONNECTOR_LVDS); + DRM_MODE_CONNECTOR_DPI); if (ret < 0) return ret;