From patchwork Tue Jan 24 22:03:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47919 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2395317wrn; Tue, 24 Jan 2023 14:08:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXsVFeh6ms2XaNiHHpjdi132AKfWfRq20LuoggegBd646Z8R04WuhGxc/jRNCzeboRV48edm X-Received: by 2002:a17:906:848e:b0:7c4:fa17:7202 with SMTP id m14-20020a170906848e00b007c4fa177202mr29268121ejx.33.1674598114106; Tue, 24 Jan 2023 14:08:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598114; cv=none; d=google.com; s=arc-20160816; b=LuDinFFHJnF1lf0HTBXGFzPKChacw0EcLqV9na3rYYvgnlxZVxQw1TVgvvX9wEnIoW jM6/+C6hQcwM8N5q336wfdLY0UCFDPgDCxfEIdP3rT4SU3MqYVLxSM/0N7RLh3Gf7D0O 6Bb91TF+KXSX4hlCklLEC6ZjFm9QVHQn8jpZM5zxk+YR76Cz3bbqY6vSyvm+dqKwtxy9 T2uCeNOQFJw2vBSvhiGAhjp2zEA8wukufvqkak/OnYG3Bzqge3fzrL6YB/zuVH0/TgXr 5B96SeCy4lUV/hlSim4hDK8WxRE7ZZ1OnlXyadKdigJPl2BBFfHb/+XmnIgnUatWOm6d wekw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=75/IjlhstHHhYWzsbQIR4Dd2QgIIp4238rHFb4NvJPg=; b=cUTaHPOsDUZSv/91VG2/8xSc0VKNLTaqaimVMoEaCt1DsNYjiva006tk7hrqPnxdkB Fh86KdUbQe8Bv2MLXK2zM9uYwYvHunl5Jk+ybp9GRj+UyKupgDA6YDwP/25UeM5sRxLm 4I5/BRUEDknhz/r8XuYsUmhGdfsB9t6ufpwBsdChQkKX1/mq/s6NqfcB7M2gOVtPZcni X5e11TxcYkwNbyw9LNe6xbykoNtghDsw+J30mlIgqRZQGM5BgS3PxUJR0pax0osWhWVu nGor5x4U0zky3FMTSrp8qXBB//dllfBjO6fxGkwJwiMsGDBPY6RC7RSF3TrMspOmZAs5 2LKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AUJrtPJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gh13-20020a1709073c0d00b007826cb6f57csi3385030ejc.407.2023.01.24.14.08.10; Tue, 24 Jan 2023 14:08:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AUJrtPJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235113AbjAXWET (ORCPT + 99 others); Tue, 24 Jan 2023 17:04:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235095AbjAXWES (ORCPT ); Tue, 24 Jan 2023 17:04:18 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 079244FCF4 for ; Tue, 24 Jan 2023 14:04:01 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id c4-20020a1c3504000000b003d9e2f72093so41042wma.1 for ; Tue, 24 Jan 2023 14:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=75/IjlhstHHhYWzsbQIR4Dd2QgIIp4238rHFb4NvJPg=; b=AUJrtPJNhcoozirZE5FdY6iWPNtWlFrObe7Pouo+G3eNQt8ubArB/ugRI/EzBk9OSX 1aq6Z17HKeVHJ/q36qE9oS1RMEDv5jjAwcewxT63fnFkjsgfFANbeaC3arfNSH+yM7w2 xT7f7b4ycOCZWq8KFDadRPl3sUvStDTw/0DCHEhhkrbsPyqrywJjmLakQirMH9f56Nu1 d6ulFPt+bPPB/tuHOHKArqU+uU1/KlbWsy+JHfYYHQKIlxIL5g/E7Ok8V27Swx2PG+xI 1/hicgnaOETKo56WUCdj+ruFnlflR0QyzyQ7Dfnx1/hAKZq5jdVhJ55hXLmYCbtzS97/ osZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=75/IjlhstHHhYWzsbQIR4Dd2QgIIp4238rHFb4NvJPg=; b=ehMmjnulyciWJ4zW45+SLMv+dfBWm33RVcpTkDd2atdWNP45k38xF+yTWIRyFEXRIa 7Ou03RF0bFJgD7/R81hihhwUpt+lGOUiAd6yDLMgwiod8ypK6Lxqp5AEElYOks38vey5 j4RKWO2RrK0K+2Mkr6EKhVLlhJVj6AYHC/yu3obTQOAjPhgk2U6friJxrSHLDCXiMJv8 tar6m7W0OIg4W58KbfAefAnnuHp8jCd1ipIQMApiKEG7topsEdkOjqWw9fM96IU7nhBe fdXSNWKfvsk0lQYLcJd//lqAHFwVGtMqK82zA7QIfdkGQlGVuqY8Ud0QB2U+qcM1MMRY PoXw== X-Gm-Message-State: AFqh2kpzZOWTb4OHIUYwvvqYZNGYaZQiIs19LZ1IC41UjN7f2ZVPPFQ9 Wqi80JHZ+Qu+zLs8/solrvc= X-Received: by 2002:a05:600c:3b0a:b0:3db:22a:1349 with SMTP id m10-20020a05600c3b0a00b003db022a1349mr7678769wms.2.1674597839531; Tue, 24 Jan 2023 14:03:59 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id j20-20020a05600c489400b003db0f4e12c8sm22371wmp.34.2023.01.24.14.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:03:58 -0800 (PST) Date: Tue, 24 Jan 2023 23:03:56 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 06/11] staging: rtl8192e: Remove unused variables num_proc.., recei.. and rxov.. Message-ID: <67df12497bc6f93c6ef85b4dda7490b037f2a3da.1674596722.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943392221325976?= X-GMAIL-MSGID: =?utf-8?q?1755943392221325976?= num_process_phyinfo, received_bwtype and rxoverflow are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 5 ----- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 +--- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index 31b4823e6324..154d15b68b8e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1469,10 +1469,6 @@ static void _rtl92e_query_rxphystatus( rxsc_sgien_exflg = pofdm_buf->rxsc_sgien_exflg; prxsc = (struct phy_ofdm_rx_status_rxsc_sgien_exintfflag *) &rxsc_sgien_exflg; - if (pdrvinfo->BW) - priv->stats.received_bwtype[1+prxsc->rxsc]++; - else - priv->stats.received_bwtype[0]++; } if (is_cck_rate) { @@ -1535,7 +1531,6 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer, if (!bcheck) return; - priv->stats.num_process_phyinfo++; if (!prev_st->bIsCCK && prev_st->bPacketToSelf) { for (rfpath = RF90_PATH_A; rfpath < RF90_PATH_C; rfpath++) { if (!rtl92e_is_legal_rf_path(priv->rtllib->dev, rfpath)) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index e0d0f4faeca7..c5fe8e0aa83f 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2183,10 +2183,8 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) tasklet_schedule(&priv->irq_rx_tasklet); } - if (inta & IMR_RXFOVW) { - priv->stats.rxoverflow++; + if (inta & IMR_RXFOVW) tasklet_schedule(&priv->irq_rx_tasklet); - } if (inta & IMR_TXFOVW) priv->stats.txoverflow++; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index e38de4d8a467..bb942283bc7a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long num_process_phyinfo; - unsigned long received_bwtype[5]; - unsigned long rxoverflow; unsigned long rxint; unsigned long ints; unsigned long shints;