From patchwork Wed Jun 28 17:55:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 113996 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9123527vqr; Wed, 28 Jun 2023 11:23:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5NLNI88dsYav7K+W1q4KL5xhgLwebLjm/iNoMX4oQzYrqhKWKefdVJQtEs47Tg/crnZjn8 X-Received: by 2002:a17:906:77c6:b0:988:3171:df06 with SMTP id m6-20020a17090677c600b009883171df06mr25111892ejn.2.1687976617880; Wed, 28 Jun 2023 11:23:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687976617; cv=none; d=google.com; s=arc-20160816; b=okpW0rsJcX8XuIZFvZGHVb0LkLRh/7t2X7H15j0mtiNUhf3Qdp8zeIYLkZG2y0qCcD 3PnNBhvOTPMICXcDqjTI8sBIIQ0FiLCvWbccvUCUgCSgStmPZliA6UE2nIZNnI3z+yJH 5ZGcZA0PqTeo9foZHTBwq2TysBS9An+BjwnA3L45t3MF2lMKc4WptwYelBVBe7tSpgk/ UtakL+oRL/3sF6uUi5kLaM/5kq2rBkznJIO6DpRDVfI6chIqeNwqVVIaBrq0MDt97M+/ WR1EQ6J+FccPchQEW3N57OExa/SYNS38OwdNcNMPp6OJZbyB9OIkpf7ptHUuotamPrX7 VapQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dYiMRfS2c8vdSODcMhyvc/Ot1ysIF20ziPAc9sw1osA=; fh=2ET6nL/wlcZ4gumDTTusm6ilw662ytnheFDwMTsLDv4=; b=I+K1+TrQZHMV4wpfhpKxpcA17Me9b/zbvyDLymP7dLM0WAPzxtuqQjMJl0CRd4lXsw fGv3gVsNNpgFrsKetcx2zX/65GNBsH5XacA19XSWb7Ucuu/YFtL2R1nhQsujU0oyMnhD Ub4IzydT3AqibIvSpO6vp0336oChQ+C+JkqGIHVaqtN5MViMtcOMdB/EaAqH+5VHkucU 8zrMdTv4aY09EgHyBXywrcx+J369fOzF41c4Al76FOkV4x8l0QPw62KaPHP7R+7PCcZG clrpUdhhiUPwulrSPoMYRgrMFEcPjmD7hODK5H60AvmSuF0+Rh+m1oC0guv06iU2b2GZ W4/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=drUR6x+k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s5-20020a1709064d8500b00991d54db2b2si4018363eju.698.2023.06.28.11.23.13; Wed, 28 Jun 2023 11:23:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=drUR6x+k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231732AbjF1RzV (ORCPT + 99 others); Wed, 28 Jun 2023 13:55:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232013AbjF1Ryg (ORCPT ); Wed, 28 Jun 2023 13:54:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 167182704; Wed, 28 Jun 2023 10:54:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9C36A61426; Wed, 28 Jun 2023 17:54:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33042C433C0; Wed, 28 Jun 2023 17:54:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687974870; bh=Bh4L2zCmi8co6ZKpNs0mjBEZPUkU4wABH1EONUGV4ko=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=drUR6x+k+t8/2hPL0PU77jfEmFxwI/9p/nmhLCpepsUyg8imTUiIrSHEitQ39pyf5 dQ6Mi9W1I8tCpaC636iTfWsmcupTbmrxBMXarmQYnzqp1Pou3/R0SUmtsQhYJOjDvy 8Wq7mBolcr/4mLGtxrrTSVunbtlIwBRLVqZ1x4Smg/En4x9EEEvSruh+Am68sBLON+ /Tj8m6Vcrqh+0+ne5Hr1CsIP/Y9egbkv9lVUjXUKXbD353UZv4iq1F3tzSx697BjCg +HXJO39pfxtnt4re3CmOAnW0jqHkXqPVGNFR00FZgY+idT08P01GxOMFRRTNJhyzPh l6EKX6oV4xUVw== Date: Wed, 28 Jun 2023 11:55:24 -0600 From: "Gustavo A. R. Silva" To: aacraid@microsemi.com, "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH 03/10][next] scsi: aacraid: Replace one-element array with flexible-array member in struct aac_aifcmd Message-ID: <65907ee4083de62fbaadc5c2e6512e3828912d1b.1687974498.git.gustavoars@kernel.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769971769775480491?= X-GMAIL-MSGID: =?utf-8?q?1769971769775480491?= Replace one-element array with flexible-array member in struct aac_aifcmd. This results in no differences in binary output. Issue found with the help of Coccinelle and audited and fixed, manually. Link: https://github.com/KSPP/linux/issues/79 Link: https://github.com/ClangBuiltLinux/linux/issues/1851 Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook --- drivers/scsi/aacraid/aacraid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h index 83fa890f28be..2e1623344327 100644 --- a/drivers/scsi/aacraid/aacraid.h +++ b/drivers/scsi/aacraid/aacraid.h @@ -2618,7 +2618,7 @@ struct aac_hba_info { struct aac_aifcmd { __le32 command; /* Tell host what type of notify this is */ __le32 seqnum; /* To allow ordering of reports (if necessary) */ - u8 data[1]; /* Undefined length (from kernel viewpoint) */ + u8 data[]; /* Undefined length (from kernel viewpoint) */ }; /**