From patchwork Mon Jun 5 17:01:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Murphy X-Patchwork-Id: 103402 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2838362vqr; Mon, 5 Jun 2023 10:19:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4o2Wu3FcP/JMrU95/v+Br4lbi1BEesx0Bqr8j+sse7LarTjdM9Apy3rjWphuqQq/hPfSC/ X-Received: by 2002:a05:6a00:99d:b0:63b:8eeb:77b8 with SMTP id u29-20020a056a00099d00b0063b8eeb77b8mr391001pfg.13.1685985593115; Mon, 05 Jun 2023 10:19:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685985593; cv=none; d=google.com; s=arc-20160816; b=ylwoWNkQJGjqLSPcc4MaOMDKhLIB0Sx1rpQUUE/r0EK46bKzJ1p3ZUmjteNhnMi6rC T0+Wh2lZOzzEK2BxPb2SeeAUQdufNB/s7JHtlqbx9HS2q5yYpv8tvgeMIc4Gyy3s2+H8 YU77wuDYa4eamp6HMlDpwha0JXuQM9ozhpVefOxsifp/8vLlokyBc3zLxB1VceZ3t3KC cq06exv4BKb+4zTcE6uRqrAb4ZtVbT9fbSB7pN5y/6kJOXI9EbQ34zfJ2/DzkcpTnQYk YqQYF0NuRyxLsv2IJYS/gRhnezRoZqPzB75avTTGQ5DVpuEY4s9nLLFOUtnzvBgal8FR fOXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PrWGHPepL4BqZMt8r1m7k++jp28c4/60KZBiaeVl8bQ=; b=d8RTnkAWoBi3zvGApWb339l2UEt+WjihwFQIiWHaDyyOxLRrqCNLcltqWpaCY9v1CA WV700CvfdX6EeJJGrcS+7Yk+TArpZZrIizZ7LhFHjBMYAafown9b/DLUV+IGuSn6+OKd 7rIiPx3wtaKt1B3+ixYHGi7XIJA9gfcV9MJkdm1mAc86lPXlvsM9x8lONVCJphor1zfx 8CRCmTJe81KChqZ0ZzS5E+YJGB1w7AMl+Vi1MMlZGt2MSmR4Pbap721pfkj4hlGU9r8+ IpSSheFCaTy8z3AMQPMRTKnhbCpZikzNUO/V7QKj6pb2pQzfdfLhsNabh2PSji7XTfFQ AGFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f10-20020a63de0a000000b0053febd41e7esi5886579pgg.380.2023.06.05.10.19.41; Mon, 05 Jun 2023 10:19:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235233AbjFERCE (ORCPT + 99 others); Mon, 5 Jun 2023 13:02:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234726AbjFERBu (ORCPT ); Mon, 5 Jun 2023 13:01:50 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A4C9219C for ; Mon, 5 Jun 2023 10:01:46 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0349BD75; Mon, 5 Jun 2023 10:02:32 -0700 (PDT) Received: from e121345-lin.cambridge.arm.com (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1C09C3F587; Mon, 5 Jun 2023 10:01:45 -0700 (PDT) From: Robin Murphy To: will@kernel.org Cc: mark.rutland@arm.com, suzuki.poulose@arm.com, bwicaksono@nvidia.com, ilkka@os.amperecomputing.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Sudeep Holla , Hanjun Guo Subject: [PATCH v2 2/4] ACPI/APMT: Don't register invalid resource Date: Mon, 5 Jun 2023 18:01:32 +0100 Message-Id: <63b34656e1f7b41bcb458fb6d7496e04db757e0d.1685983270.git.robin.murphy@arm.com> X-Mailer: git-send-email 2.39.2.101.g768bb238c484.dirty In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767884029096463658?= X-GMAIL-MSGID: =?utf-8?q?1767884029096463658?= Don't register a resource for the second page unless the dual-page extension flag is actually present to say it's valid. CC: Lorenzo Pieralisi CC: Sudeep Holla Reviewed-by: Suzuki K Poulose Reviewed-by: Hanjun Guo Reviewed-and-tested-by: Ilkka Koskinen Signed-off-by: Robin Murphy Acked-by: Lorenzo Pieralisi --- drivers/acpi/arm64/apmt.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/arm64/apmt.c b/drivers/acpi/arm64/apmt.c index 8cab69fa5d59..aa7d5c3c0dd8 100644 --- a/drivers/acpi/arm64/apmt.c +++ b/drivers/acpi/arm64/apmt.c @@ -35,11 +35,13 @@ static int __init apmt_init_resources(struct resource *res, num_res++; - res[num_res].start = node->base_address1; - res[num_res].end = node->base_address1 + SZ_4K - 1; - res[num_res].flags = IORESOURCE_MEM; + if (node->flags & ACPI_APMT_FLAGS_DUAL_PAGE) { + res[num_res].start = node->base_address1; + res[num_res].end = node->base_address1 + SZ_4K - 1; + res[num_res].flags = IORESOURCE_MEM; - num_res++; + num_res++; + } if (node->ovflw_irq != 0) { trigger = (node->ovflw_irq_flags & ACPI_APMT_OVFLW_IRQ_FLAGS_MODE);