From patchwork Wed Feb 15 21:02:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Golle X-Patchwork-Id: 57732 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp421381wrn; Wed, 15 Feb 2023 13:13:37 -0800 (PST) X-Google-Smtp-Source: AK7set/OC9+w3T1Uj+Bzu07LRi7W/D5L1oj+5LztqUYB92PhdamWv2oM4tOanFi30Ipp1pLO/eFg X-Received: by 2002:a17:907:2b11:b0:8ae:b008:9b5a with SMTP id gc17-20020a1709072b1100b008aeb0089b5amr2857615ejc.69.1676495616906; Wed, 15 Feb 2023 13:13:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676495616; cv=none; d=google.com; s=arc-20160816; b=JNWWET7R/rVv8CY/tmLmLuFmUreAWUEcmVZFVfcsx7c3EycEZ4Aw7PxPPcMpmeq//9 SpCmQzO/kQp/9WWDI8lNF28Eg85Io2e2nGSxK0YcGU0r9sfMMK0oVJPLxuaDbhU4WZip gtiHKhjOuOKXN4w2Fj+yNqWQGTlsmn2ZLy9PzCJSZ4nU5nD+0rLdKvrhWEEOHFipm/N+ bIUqAaO8NqfY0bbW3cmi2Qmw3bUaHA5hp9ZE7FSnmG+b+KIknN/P85omWsfx/AUhN/zY rpkzseTtAE5Y9eshhRhAn01bVr3RolPIgfHh1YPyA+Gi9GVY4rXy8MOrQ0xSk6fr2/wt yEQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=JwcrMfNgF63gIrZ/GkmsQ7CjfsIvdJXRwyJlJfugE+g=; b=WqBEo7q/YiiwS3BcLZOFjFUzfpiCmNxp/5OurJKh8FgsNXGd3R0gKNh0v7VrAgyy99 +e0VPwsOhpWpe9qNKEkf23vmi81wamCrQXTLvQKj6BhTor80UqkOq9+qajE5M286RIpG U0PINTzWZszwOmlfIUlbODcY/fTcDFPtX+87kd0GH8/maq/I8QOGEymapfQY4rsdkhYF tZrWH27dEMAPrkjjg+AMeTTpd/qELq/2711/vlr5uB6eZKgEc8AEiANy+ecU79cuyc5G Q4amp8vifyLsZ6qP5r1fFE9N6Z1eWRw7VsAXWVIkT5BvQ2XLdEiS+DWG6nPbp+ICs/Pl lDsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w9-20020aa7d289000000b004acb4f7f7c9si13458095edq.146.2023.02.15.13.12.50; Wed, 15 Feb 2023 13:13:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229796AbjBOVFw (ORCPT + 99 others); Wed, 15 Feb 2023 16:05:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbjBOVFd (ORCPT ); Wed, 15 Feb 2023 16:05:33 -0500 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44E6B4697; Wed, 15 Feb 2023 13:03:41 -0800 (PST) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pSOwF-0003eU-12; Wed, 15 Feb 2023 22:03:39 +0100 Date: Wed, 15 Feb 2023 21:02:04 +0000 From: Daniel Golle To: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn Cc: Jianhui Zhao , =?iso-8859-1?q?Bj=F8rn?= Mork Subject: [PATCH v7 06/12] net: ethernet: mtk_eth_soc: reset PCS state Message-ID: <63acf73a72905fb35182763de6566a3f1603a370.1676491901.git.daniel@makrotopia.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757933068077361709?= X-GMAIL-MSGID: =?utf-8?q?1757933068077361709?= Reset PCS state when changing interface mode. Reviewed-by: Russell King (Oracle) Tested-by: Bjørn Mork Signed-off-by: Daniel Golle --- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 4 ++++ drivers/net/ethernet/mediatek/mtk_sgmii.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h index 7014c02ba2d4..142def8629c8 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h @@ -548,6 +548,10 @@ #define SGMII_SEND_AN_ERROR_EN BIT(11) #define SGMII_IF_MODE_MASK GENMASK(5, 1) +/* Register to reset SGMII design */ +#define SGMII_RESERVED_0 0x34 +#define SGMII_SW_RESET BIT(0) + /* Register to set SGMII speed, ANA RG_ Control Signals III*/ #define SGMSYS_ANA_RG_CS3 0x2028 #define RG_PHY_SPEED_MASK (BIT(2) | BIT(3)) diff --git a/drivers/net/ethernet/mediatek/mtk_sgmii.c b/drivers/net/ethernet/mediatek/mtk_sgmii.c index d7ffaaeaf9ab..d7e7352041a4 100644 --- a/drivers/net/ethernet/mediatek/mtk_sgmii.c +++ b/drivers/net/ethernet/mediatek/mtk_sgmii.c @@ -88,6 +88,10 @@ static int mtk_pcs_config(struct phylink_pcs *pcs, unsigned int mode, regmap_update_bits(mpcs->regmap, SGMSYS_QPHY_PWR_STATE_CTRL, SGMII_PHYA_PWD, SGMII_PHYA_PWD); + /* Reset SGMII PCS state */ + regmap_update_bits(mpcs->regmap, SGMII_RESERVED_0, + SGMII_SW_RESET, SGMII_SW_RESET); + if (mpcs->flags & MTK_SGMII_FLAG_PN_SWAP) regmap_update_bits(mpcs->regmap, SGMSYS_QPHY_WRAP_CTRL, SGMII_PN_SWAP_MASK,