From patchwork Tue Jul 4 19:50:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 115891 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp1444123vqx; Tue, 4 Jul 2023 13:25:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlHq355ZVq8rwvW9T4vGgn2yUTBwXFb0F8jEhL2ccWuCev1aCoEzGbUgZWvvmfkmJVE0hLhm X-Received: by 2002:a17:90b:3e86:b0:263:2335:594e with SMTP id rj6-20020a17090b3e8600b002632335594emr15366996pjb.38.1688502317599; Tue, 04 Jul 2023 13:25:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688502317; cv=none; d=google.com; s=arc-20160816; b=xHzhjXS3BlwoCeyv9IrsrkCI8Lnay8y16+zjle+CLgky7BDdK7BzlnRsFM2tcpDFej II/THcPsRKrfEr4iRCEMJzYUzI/5myPN54BSj1hWP1ap/rJ32M0FVccl3AE5XIrUb8kz gwo4ZDZdLvMFI5QMA7DOJb1L7e4pvHHcq4o7qPFGgeoJnIwPyPwHdaJ7bLovNjUgzIPk nNGL2wwuqmr7JpwzqlXAZ8OcphRHxZCCPeLWe+UhonE9ePYsB8X+cQ7UwXQYwi7sXCBe TDQmFklvuOwJpI3arSf+IM39yx4Fxy8qXnVmup3AHr+zVMgSOBRxBwyyY3WX7mKkpVpm nRcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=E5rO26Dz3CWK8l+Od+4vE1x2c+orHF72b1zdbUbPDV4=; fh=g/KG9tEeoZYi4weLi14IzejqUwK3BsJZwld8h7n9SWM=; b=elBRPieX61ApvysHhUnT/TiLLet8boNg8mKVmxoZQe/7icQYlKy+lDjKBbcld6Xr6Z 4CpOwfIwqPppSr77PQAbzjNbMN8MNBfv4b8m3esPStcP1eSxDZTZIkG5q8UXzdqiWsfE 9Ko2Colc/fISwjgxfG0/weBJ6pAnAz8AKpbXy5u1wIMWVr8eP4L6RFDVX4Vdmn7dQzmJ c/JRuXHj0qw5TW/SIsVzugzixE+32K0N3INhgO8CsFXlvSOZpT+zBToixb0YQG/LdUlh iJ7bQtYGLijcGPteLbtxUbjtDPfED56A9WzpwvPq5o1kNG/XEYy+v+SeIfvsVhdXdluC noFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=Vtze80gT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z16-20020a17090abd9000b002636a32aff2si48789pjr.114.2023.07.04.13.24.52; Tue, 04 Jul 2023 13:25:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=Vtze80gT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbjGDTvP (ORCPT + 99 others); Tue, 4 Jul 2023 15:51:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbjGDTvN (ORCPT ); Tue, 4 Jul 2023 15:51:13 -0400 Received: from smtp.smtpout.orange.fr (smtp-14.smtpout.orange.fr [80.12.242.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA27910DA for ; Tue, 4 Jul 2023 12:51:11 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id Gm3HqhIN61lRhGm3Hq4oNQ; Tue, 04 Jul 2023 21:51:09 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1688500269; bh=E5rO26Dz3CWK8l+Od+4vE1x2c+orHF72b1zdbUbPDV4=; h=From:To:Cc:Subject:Date; b=Vtze80gT9MTMD9rA3V9bGewsYl3ApaMoHm2coqNXA2EIJYAbnuj/jrjX6wzceUUrY 8ZXcbDtR0rZkV0KZlPL31Rx4tDuX45eSyEH5/HUlapU4xhaQy9oepa92Ex3GuxPGN6 M6jCQg3gSdxCCXFgmvhKHrHsRZvt7J9ZYdfdkciXcU/7sKSlghv1zHtfgqBlk2c0Y1 Qw3dA9LeA2lUnpSa7YAnKJyUMCNPG5CpOLHz2QwvPLlUAR4tuxtOm55LHjh+/T6d3y ryL1iciITpEf9iTlxjnbvWptvB6wcjt+eM23rzaeVNMSKojQ/6nAWQnetfDJfAkr1W SxHEUFahQVGcA== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Tue, 04 Jul 2023 21:51:09 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: dan.carpenter@linaro.org, Linus Walleij , Andi Shyti , Alessandro Rubini , Wolfram Sang , Giancarlo Asnaghi Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Subject: [PATCH v3] i2c: busses: i2c-nomadik: Remove a useless call in the remove function Date: Tue, 4 Jul 2023 21:50:28 +0200 Message-Id: <62ae6810d41e04a9eb5adfa18a9e40904bc72256.1688160163.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770523006482353984?= X-GMAIL-MSGID: =?utf-8?q?1770523006482353984?= Since commit 235602146ec9 ("i2c-nomadik: turn the platform driver to an amba driver"), there is no more request_mem_region() call in this driver. So remove the release_mem_region() call from the remove function which is likely a left over. Fixes: 235602146ec9 ("i2c-nomadik: turn the platform driver to an amba driver") Cc: # v3.6+ Acked-by: Linus Walleij Reviewed-by: Andi Shyti Signed-off-by: Christophe JAILLET --- v3: - update commit description - add R-b and A-b - fix Fixes tag [Dan Carpenter] - add cc stable [Andi Shyti] v2: - synch with latest -next - https://lore.kernel.org/all/62ae6810d41e0429ebaadfac8a95409f4bc72456.1688160163.git.christophe.jaillet@wanadoo.fr/ v1: - https://lore.kernel.org/all/4f4c2c5c20b61c4bb28cb3e9ab4640534dd2adec.1629530169.git.christophe.jaillet@wanadoo.fr/ --- drivers/i2c/busses/i2c-nomadik.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 1e5fd23ef45c..212f412f1c74 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -1038,7 +1038,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id) static void nmk_i2c_remove(struct amba_device *adev) { - struct resource *res = &adev->res; struct nmk_i2c_dev *dev = amba_get_drvdata(adev); i2c_del_adapter(&dev->adap); @@ -1047,7 +1046,6 @@ static void nmk_i2c_remove(struct amba_device *adev) clear_all_interrupts(dev); /* disable the controller */ i2c_clr_bit(dev->virtbase + I2C_CR, I2C_CR_PE); - release_mem_region(res->start, resource_size(res)); } static struct i2c_vendor_data vendor_stn8815 = {