From patchwork Fri Jun 30 21:23:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 114886 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp10675157vqr; Fri, 30 Jun 2023 14:45:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlGop3QhTyw6fLwD7NDe/eSCFf1jP9yJP+HB/djDoBNAsvKFRimExgUefEpbkvBcEAONZC9I X-Received: by 2002:a17:902:ec82:b0:1b8:45e4:cc73 with SMTP id x2-20020a170902ec8200b001b845e4cc73mr4681868plg.40.1688161500480; Fri, 30 Jun 2023 14:45:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688161500; cv=none; d=google.com; s=arc-20160816; b=YaVV549ndlfgS84AAVouDT04hERahhzaYSNx8YQ49apThTdUfIQ7pQzrESLXL9/Jhi AzBMuPoFWOfwBQfHLx0A1GkhmtkmdI+sar139+oCuOhlZk6kO/04zeSmGF1cZKW4PZRM LO7eWSnGgBY8oMzlBpmxG6JlqJGij+iyjuOVPWaFRYiRquHUn8vFlytD6eUJAbAWJz6K auub0lwEc7qMQGZQnuyspbz38z8YAO9MDA4aZBqwfJnzdgzEsqUJDwZK/5ectcj3TXBQ uflK5TLQc0cbbQSPJA7o5CgODx4C4pSjW4LpgzD9BrSSHhXbh9zmhMfSGxOdpDxY2Alx 1kzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=kMcJl7rvulaYPvsNlfWsI9/je8sVJ9jmEHBC5pxujxE=; fh=pXgZ1Gw/uWpsOpa8ZbKSudDSY9nii/s8UwDti459HAc=; b=MRONv4+JUKLqsRNqZovvbpVPmGhjMu3B5+NjytYkvYhyIKaTRQdKpaveH1LgD7gkHZ 2A+yWCdMBgRzxc9U79sy0bU/QXzV502qaU19wPQ1gtdUuzoDokKvVsnfgyDhCtNbKlaz t53KrNKHfNJO4Ug43e2xKGjOrN0nAmBzUeOYa0Z+imy8pIf3aH8P9qRyu2BbigpqVKNi drafgHYjwlv/bFwj5Iw+XQUU1lOOs1BCfZfOYRNlBKUKfRClq+3SE0pNZ6ltpduRHCny qqUjJFpAVlC3ao1HWge4EZa7+YVLaBZO4jxIfrlG1M7dG7PUlk2ABJLEnXzLVxOtJAJO 6ZfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=O8ML1LNR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id je2-20020a170903264200b001b7eb86ae19si11714023plb.195.2023.06.30.14.44.44; Fri, 30 Jun 2023 14:45:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=O8ML1LNR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231617AbjF3VX4 (ORCPT + 99 others); Fri, 30 Jun 2023 17:23:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbjF3VXy (ORCPT ); Fri, 30 Jun 2023 17:23:54 -0400 Received: from smtp.smtpout.orange.fr (unknown [80.12.242.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A20B4102 for ; Fri, 30 Jun 2023 14:23:50 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id FLaWqFE741lRhFLaWqu2BO; Fri, 30 Jun 2023 23:23:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1688160215; bh=kMcJl7rvulaYPvsNlfWsI9/je8sVJ9jmEHBC5pxujxE=; h=From:To:Cc:Subject:Date; b=O8ML1LNRtqOBAXG4IUAARTGOG4bbWqctKdJCWvjnoFtNnYF4JIikMW/veVPXHlGtN qENoZRqlrMJekwDGxR9X+hXSz/LOJesjZxS44YRA7UBb3ongN/YFK/GY1OX4BhW5pT fgEq+VWs1lCN0cQhuLgxHyEx20Pid8ftLkEsYy2kLPrjyG8QP1b7+BV4AFkQAX0eph EJuPNUgLuePv0w3ezdcIJsxqF5hHlzDK7P+vgeVRIvcqleA9NrcNk6ozzKdhLlSwqt vrcgtjVBDBTY1K1kEOWMYouMC4xdNSq6sAAaKxHHJ6M8vhZgWHT0E9Y63evhoOAtJo kWP44ZYBRSDFg== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Fri, 30 Jun 2023 23:23:35 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: wsa@kernel.org, Linus Walleij , Andi Shyti Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Subject: [PATCH v2] i2c: busses: i2c-nomadik: Remove a useless call in the remove function Date: Fri, 30 Jun 2023 23:23:28 +0200 Message-Id: <62ae6810d41e0429ebaadfac8a95409f4bc72456.1688160163.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770160238717057005?= X-GMAIL-MSGID: =?utf-8?q?1770165633434714611?= Since commit a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux"), there is no more request_mem_region() call in this driver. So remove the release_mem_region() call from the remove function which is likely a left over. There is no details in the above commit log, but at its end we can read: Conflicts: drivers/i2c/busses/i2c-nomadik.c This may explain why this call has been left here. Fixes: a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux Signed-off-by: Christophe JAILLET Acked-by: Linus Walleij Reviewed-by: Andi Shyti --- v2: synch with latest -next v1: https://lore.kernel.org/all/4f4c2c5c20b61c4bb28cb3e9ab4640534dd2adec.1629530169.git.christophe.jaillet@wanadoo.fr/ /!\ /!\ /!\ /!\ /!\ /!\ This patch is completely speculative and without details about commit a410963ba4c0 it's hard to be sure of the intent. /!\ /!\ /!\ /!\ /!\ /!\ All I can say is that it looks logical to me and that it compiles! --- drivers/i2c/busses/i2c-nomadik.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 1e5fd23ef45c..212f412f1c74 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -1038,7 +1038,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id) static void nmk_i2c_remove(struct amba_device *adev) { - struct resource *res = &adev->res; struct nmk_i2c_dev *dev = amba_get_drvdata(adev); i2c_del_adapter(&dev->adap); @@ -1047,7 +1046,6 @@ static void nmk_i2c_remove(struct amba_device *adev) clear_all_interrupts(dev); /* disable the controller */ i2c_clr_bit(dev->virtbase + I2C_CR, I2C_CR_PE); - release_mem_region(res->start, resource_size(res)); } static struct i2c_vendor_data vendor_stn8815 = {