From patchwork Thu Mar 9 20:27:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 67093 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp509325wrd; Thu, 9 Mar 2023 12:46:09 -0800 (PST) X-Google-Smtp-Source: AK7set+17cCjxhtpg71MRnXJEaCgT3ZnwRjOJ6yq0YKkOQCGUsPe/ow+n0OmSwNr780wLysXQy5F X-Received: by 2002:a17:902:c103:b0:19e:7611:7162 with SMTP id 3-20020a170902c10300b0019e76117162mr20085168pli.16.1678394768748; Thu, 09 Mar 2023 12:46:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678394768; cv=none; d=google.com; s=arc-20160816; b=qQjDT4F9MnDji9a2jePWRncG5yVbEyCIZbntj3jtoN3G5lLwRpwW3Lb9WkgI51P3Ho BydfObcuWQj8LRxBuw9gI2DlqqQ6JsNE3bT8qLHfrF17j8khDn5IYQf5HvzPTUYaEpjW G+CumuaQKIQaJLRjhW4lm0brN7eOtgXnozLlTCPyouaZ0n8jDd6rTjMWvRVzhQDdBaEK u0ymroOukGRhq0iTXwaEJC2wBRR5LZct9oV7IDcDUXUiZ3zlBaWt8C3M01n3ayR/7svV iRsqjXrcJNfVgg/eBtl+iww+MPsvkWzK6AK2zMsy/fJSbNMriyUxubnNrI5jahTf40er EukA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:subject:from:cc:to :in-reply-to:content-language:user-agent:mime-version:date :message-id:dkim-signature; bh=7S+FEVatmyxfzv6iVztbucqvJz0EITDWICpCYpuxfvk=; b=beFccOn7Q7NAsGTYrV1/fWNLY881ZqxJLGdHNRPPf+v1AzO1AQcFkcY9FIyA1UZ3wJ heG6g5/AbnHn6kzeUeVdifDU1VwBrKX/ROWwoNBw8fhFFcuzu/HTV3fXzZ4noWa/OCPY CInRbxS5XcCzBvGXkgE64fD3Jx3kyqCuJCQL9+3a4suuWEdb3gxBcg35JH0nBj5+pku7 BQcMBbGs83kMwwiTpgq4OIZJiRB6LQV+VLoNYYRFXoIybVKciNMClV/xqiLE5eAvv333 3n48ZPLlWYewZuX7JNUHTA8re64eKgwKOw/S6i8WaowWZZ8sPH7PduRZlUWBvUKSkXFz XnHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=IsAp98zz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s8-20020a17090302c800b0019cce1df447si280430plk.5.2023.03.09.12.45.56; Thu, 09 Mar 2023 12:46:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=IsAp98zz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230107AbjCIUaO (ORCPT + 99 others); Thu, 9 Mar 2023 15:30:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230294AbjCIUaJ (ORCPT ); Thu, 9 Mar 2023 15:30:09 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 768A2F8665; Thu, 9 Mar 2023 12:30:05 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id C86765FD3A; Thu, 9 Mar 2023 23:30:03 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1678393803; bh=7S+FEVatmyxfzv6iVztbucqvJz0EITDWICpCYpuxfvk=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type; b=IsAp98zzR9YAzaB3tCd01ZJDaQF5BjfswpzyfTLDIJfApCQK2ojIMCcG9iZYWV8+h EsKsek2lywxioA6h5gidQqnfSyGNusHmr2nMt1zSUixdgkF4k1zrz/hzbcbZSdsmbu 1n091N7EkktU8FVZU7kcFzYPe3HVOILTbO8DKHbF5sZu+MKwAaMWfVjExKsKcCX53r 2Yvaf93Kqo8aYFPsqYRsb+9SnstdPf/cGlMZB/0jElgRhNrnuK1GRVjMz32LncoZL9 e/n0S/x6BpzgVhrmfS0moQIYmB8A3lbXzsqvWemzgS3OGgiDuyq/YDUHyMLcwp2tGD 2xmDzSXt62zVA== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Thu, 9 Mar 2023 23:30:03 +0300 (MSK) Message-ID: <6260a6cc-bd69-72a6-8aa5-34ff68764287@sberdevices.ru> Date: Thu, 9 Mar 2023 23:27:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US In-Reply-To: <1804d100-1652-d463-8627-da93cb61144e@sberdevices.ru> To: Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bobby Eshleman CC: , , , , , , From: Arseniy Krasnov Subject: [RFC PATCH v4 2/4] virtio/vsock: remove redundant 'skb_pull()' call X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/03/09 18:14:00 #20929517 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759924472740859804?= X-GMAIL-MSGID: =?utf-8?q?1759924472740859804?= Since we now no longer use 'skb->len' to update credit, there is no sense to update skbuff state, because it is used only once after dequeue to copy data and then will be released. Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff") Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella --- net/vmw_vsock/virtio_transport_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index 618680fd9906..9a411475e201 100644 --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c @@ -465,7 +465,6 @@ static int virtio_transport_seqpacket_do_dequeue(struct vsock_sock *vsk, dequeued_len = err; } else { user_buf_len -= bytes_to_copy; - skb_pull(skb, bytes_to_copy); } spin_lock_bh(&vvs->rx_lock);