From patchwork Tue Jul 18 16:54:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 122151 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1896493vqt; Tue, 18 Jul 2023 10:21:10 -0700 (PDT) X-Google-Smtp-Source: APBJJlFeH48HpZStcBMPEV8ruTY9cdUOE2mDmEmP4ZUb4Eg6Nlh/lVs0d1Ueoqw0sb4IYEC+kDl/ X-Received: by 2002:a92:c943:0:b0:348:7c4e:2959 with SMTP id i3-20020a92c943000000b003487c4e2959mr3086057ilq.23.1689700870312; Tue, 18 Jul 2023 10:21:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689700870; cv=none; d=google.com; s=arc-20160816; b=yHiyst+rkXeKXUOkUKKKGMdv1L41AGEYHXil7Xx9pOWN9RPMfdrjgmgPP11/nyAbHW YnwEHzQenN+81pXjJms7ZD2UUskJiOcy9Lt1Bdd2wzBr5E6pQ7KunpADxyfUMZ3dVATi 8S7Escy39Wqya7C6z4Z8q77Ox2gbNccXvGvJ5aS700ccK7fe0ao/qViE+vQ7UeWc6pYX yDUuPNeAeFoqUcPIPeyvPGgbNP9HR3xcjEWy8q5rTnJUTkWMOalbXpKAlQ59phymLFxR wgxx9yfe3h6QbGVFoCmNoGTcY34WlKOorCQ0tjHnuOC8n9bX867Qepy4KIqDB9eQvOg0 IXTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=vjOpHBtKCW6Mh+wgzaXYkBP22lixDBaLJQTpGIwzxU0=; fh=Ople2ijcDVdvBJwvAg2RvyZp0qNZK7It46SN0LxlrVk=; b=rjGEOeAeNgBFnxoOrTvmJldQHqivnqN1iManhLia8fN/8YnSl7Zud5CCMJaVQFkAIw NnSR3ol3iE3pxZFdf2qj5eFcOAmLpSD+2bCOPkVLa/qRlvuOBc+Hd8iyronj1ZMILIUw cwypVz4vCyVIC9XsabWnA1QqA9xTJuFPWcGyjRKvuFChbVyEFMwUSWYGK7ymBaTH8533 s8tNBGuFiKTZ6zcFSKsMjA5gzRF8tcSaXJ2dnPd0AwvAGnafyLzQETSasMvjiVf9ZnUH QSXgxcmfSqOksAV/doiPD5aVIuv/jn9E0hcLmTce5uTzw2kus77De43DN1Vg++uVvQzz rEhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b1-20020a17090a6e0100b002639ae468d4si1913077pjk.162.2023.07.18.10.20.55; Tue, 18 Jul 2023 10:21:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233414AbjGRQzU (ORCPT + 99 others); Tue, 18 Jul 2023 12:55:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232047AbjGRQy6 (ORCPT ); Tue, 18 Jul 2023 12:54:58 -0400 Received: from michel.telenet-ops.be (michel.telenet-ops.be [IPv6:2a02:1800:110:4::f00:18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C42871BC9 for ; Tue, 18 Jul 2023 09:54:55 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5803:2d6d:5bbc:e252]) by michel.telenet-ops.be with bizsmtp id Ngur2A00Q0ucMBo06gurXS; Tue, 18 Jul 2023 18:54:53 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qLnyD-001nZc-MO; Tue, 18 Jul 2023 18:54:51 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qLnyN-000gdp-NZ; Tue, 18 Jul 2023 18:54:51 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart Subject: [PATCH v2 34/41] drm: renesas: shmobile: Shutdown the display on remove Date: Tue, 18 Jul 2023 18:54:39 +0200 Message-Id: <61738d0ed968fa59c3e5180123e208eaf8c9a43e.1689698048.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771779779774789554 X-GMAIL-MSGID: 1771779779774789554 When the device is unbound from the driver, the display may be active. Make sure it gets shut down. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v2: - Add Reviewed-by. --- drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c index 78f9650e3a61365f..51a9a6955d1fb0fb 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c @@ -16,6 +16,7 @@ #include #include +#include #include #include #include @@ -172,6 +173,7 @@ static int shmob_drm_remove(struct platform_device *pdev) struct drm_device *ddev = &sdev->ddev; drm_dev_unregister(ddev); + drm_helper_force_disable_all(ddev); drm_kms_helper_poll_fini(ddev); return 0; }