From patchwork Fri Feb 3 22:05:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Poimboeuf X-Patchwork-Id: 52669 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1079977wrn; Fri, 3 Feb 2023 14:07:23 -0800 (PST) X-Google-Smtp-Source: AK7set9jHFMmyybkU1PAWK3E1Z5ndfppwwshIlN74WNcNfTbFT7topk++oU9mgTyZe77tyBlMa4Y X-Received: by 2002:a17:90a:185:b0:230:66c8:3e15 with SMTP id 5-20020a17090a018500b0023066c83e15mr6003561pjc.3.1675462043590; Fri, 03 Feb 2023 14:07:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675462043; cv=none; d=google.com; s=arc-20160816; b=V62Q9MCY+LZ85jmlB5bIX5sbNwQL/WOUz2Hhp83LXMg1iu5UnCXfKliILFY5WtDn3D VyQkmRjZrEZnXdJtLoo8aPaHLQKFr2dspmdO4thrT7NVAbPz6tl6X9Yv8RsP5kJYbplL l2HPj/HON2I99d0Mt4Y6B2OEHka+1NnxNy4yIPlYP4iSO0IAzMgjnetomfTDtaApG99n K9mBVq/HoaSL0ZTpYyF7GJWL75SpSWXFXYXLU+cFLphA574X75oYEyJzH3XkhwHvXCOL F6XHXtbbWHAqdZegY+DAq3R38hi//dl7RkyfZO1tV9mneFYllWWIlSAwLkIPVkF16ZrY 1ZJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SBQ+RTqi0RcF18ZSna+5hPIdkwEW0xnL/rAxr57XCWE=; b=nGITIQcFlobbUE9G+aZqjzwhgbz3J0EODrE+I5ih3QtF7OLZk5OGOg3QwjJOaJTc8r SkE0Hq7+/mLsihMfssrXlIuLNrKyTAlHRt9cbZoT2VElUP6r2l2FoWX0Ikl9Zay3VNJ5 okxvUbquR/LdOJWQAfqYir6UM/lEZ8xINLhaM0zPJb4G+XUU48k23+htF1Oi8JtYJeDM 4q9fAUjTP68dMqDO3K7/GH0udgtKsiOBcvx5hzR3jhZZlnuY2gEgU9mSZsJWvn6zy0iR Rm+tHU3U+pA3CxMCJfp7CVCIikxsSldOpzkIFt7mS/xV19AZNO7sk7Sji1OG2hWySrL6 NK9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z3i2Svvz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h1-20020a17090a580100b0023035600c54si3704370pji.84.2023.02.03.14.07.10; Fri, 03 Feb 2023 14:07:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z3i2Svvz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231205AbjBCWFy (ORCPT + 99 others); Fri, 3 Feb 2023 17:05:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233901AbjBCWFs (ORCPT ); Fri, 3 Feb 2023 17:05:48 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C66C8AB5D6; Fri, 3 Feb 2023 14:05:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 61F7062024; Fri, 3 Feb 2023 22:05:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B087C433AC; Fri, 3 Feb 2023 22:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675461946; bh=b34U778UNXN7FRC5Ic8t90JQ9Tx7F3W870Rcd50IB6g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z3i2Svvz2DgckJMayCk0gnjzplyWv/xWz4lNF/4iQturQRPy9bpRXkh6LHKDE0VTj hLT80F7fD7LkSFDdo5XVfokUo2iYIZIkb6RfMG4ZOdTlIUUKJz7jxdNBXJhwhDJi7k TtZBctqmDSxTE/uROnYS1JbhnFDadTX80kk2WDbnIWma9DW9nR8COcEuQ+AJZyfnGM 43FlnaF2H3EggZw3KAqoB2U390Knt/al5l2dzI1AD5mqnBV8xoNTaf+0YclHPcnzYS 7yH77W1niwbTQwyCnpJgLEmtK0D79wQ1JvuUdroyJZVYC4GQi6U4CJfIOFQxXXFLMP YxbeNerpjAahQ== From: Josh Poimboeuf To: linux-kernel@vger.kernel.org Cc: jgross@suse.com, richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, linux-alpha@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, ysato@users.sourceforge.jp, dalias@libc.org, linux-sh@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, linux-xtensa@linux-xtensa.org, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, paulmck@kernel.org Subject: [PATCH 03/22] arm/cpu: Make sure arch_cpu_idle_dead() doesn't return Date: Fri, 3 Feb 2023 14:05:12 -0800 Message-Id: <5ef67c263f7602d0accfe7b50805a7eb576618c0.1675461757.git.jpoimboe@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756849287816042197?= X-GMAIL-MSGID: =?utf-8?q?1756849287816042197?= arch_cpu_idle_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Signed-off-by: Josh Poimboeuf --- arch/arm/kernel/smp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c index 0b8c25763adc..adcd417c526b 100644 --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -382,6 +382,8 @@ void arch_cpu_idle_dead(void) : "r" (task_stack_page(current) + THREAD_SIZE - 8), "r" (current) : "r0"); + + BUG(); } #endif /* CONFIG_HOTPLUG_CPU */