From patchwork Sun Apr 2 11:44:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Golle X-Patchwork-Id: 78236 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1711556vqo; Sun, 2 Apr 2023 05:20:30 -0700 (PDT) X-Google-Smtp-Source: AKy350YT6cLoyaSqmLxFT42ZhjIis5Ql+4tJk+iaj6YMO1+IBVIILsAw3pBsD/wk5XivGx5qHgoh X-Received: by 2002:a05:6a20:9307:b0:e1:3bde:3a98 with SMTP id r7-20020a056a20930700b000e13bde3a98mr16904710pzh.52.1680438029825; Sun, 02 Apr 2023 05:20:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680438029; cv=none; d=google.com; s=arc-20160816; b=Kf/fF2eNI+DNcmNxHOoM6AlHL+w9eupX7PNyFFKndZYtxJq3Xc8X/wV25bEatrVKRB kyLBxKSCaPVm7dZ5GNqbk8+JYnJ0wBVRLbQopDZFd/o1FleHxM5UBqHLpv/p164amIwL olJ9x/IalgRdJuLCU9AUlJkef1u9101Y/0GhcPGxFc3/ZDdJ9vR06Tx4D3AoKwSmSfGV SbS1IOVrrU/JDixe2w8oWzjIJ0DWT9zcg3tyCUyz8XvPCoC0dOuumVjKhspdK7INKrhM WZSIcbpQiDvJMXXtSMS5HrAtbYSqQTjGIuMnm0a37rI0O124tDgkUF667ZEOjw1riyX1 EYkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date; bh=zL1ll6nYswAxSYIcOvAkiWk5UZzXYdxsYMminEqh4kQ=; b=LI3Dn3OpN7a0+vGfgCEntc6DovWaH3DLyr9V7DiXNU9tNkDb8afr2IaP8XXmKqQqAY RwMH5qPWGRKmY72JcX+sLnSdTc5q4CTuEk3aFhMxmjfPzZCo5qasCJf/0S2xpCwaeT8N 8O/bBImfcMI/RZKtkop91YnzcG/F1bVMIY42galRPJ53b8De+MIRXIzktDnf/WMfy2bj vrVHDcFH5fQeVCLQ/wYBm+DaaiV1kibAgUdg2PTbJLOyIA/ElK2vYY+EfUDC+Vtjs2Gg 7uftD0FTA6+evWdbFknarx2ickzmTH3PMzwV8rvmspIBVjBoPS+zDLvdcg0L5iLgD2GF znwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o125-20020a634183000000b005139ef2fc1dsi6375529pga.58.2023.04.02.05.20.16; Sun, 02 Apr 2023 05:20:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbjDBLow (ORCPT + 99 others); Sun, 2 Apr 2023 07:44:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbjDBLou (ORCPT ); Sun, 2 Apr 2023 07:44:50 -0400 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B54C52443A; Sun, 2 Apr 2023 04:44:49 -0700 (PDT) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1piw8a-0003lK-1H; Sun, 02 Apr 2023 13:44:44 +0200 Date: Sun, 2 Apr 2023 12:44:37 +0100 From: Daniel Golle To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: chowtom , Frank Wunderlich Subject: [PATCH] net: sfp: add qurik enabling 2500Base-x for HG MXPD-483II Message-ID: <5e9a87a3f4c1ccc30625c8092b057f0fbd8a9947.1680435823.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762066987038344205?= X-GMAIL-MSGID: =?utf-8?q?1762066987038344205?= The HG MXPD-483II 1310nm SFP module is meant to operate with 2500Base-X, however, in their EEPROM they incorrectly specify: Transceiver type : Ethernet: 1000BASE-LX ... BR, Nominal : 2600MBd Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway. https://forum.banana-pi.org/t/bpi-r3-sfp-module-compatibility/14573/60 Reported-by: chowtom Tested-by: chowtom Signed-off-by: Daniel Golle Reviewed-by: Russell King (Oracle) --- drivers/net/phy/sfp.c | 4 ++++ 1 file changed, 4 insertions(+) base-commit: d74aab2ca19842d16815a97d4dd605deaae73c69 diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index f0fcb06fbe829..5e515165ceab7 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -406,6 +406,10 @@ static const struct sfp_quirk sfp_quirks[] = { SFP_QUIRK_F("HALNy", "HL-GSFP", sfp_fixup_halny_gsfp), + // HG MXPD-483II-F 2.5G supports 2500Base-X, but incorrectly reports + // 2600MBd in their EERPOM + SFP_QUIRK_M("HG GENUINE", "MXPD-483II", sfp_quirk_2500basex), + // Huawei MA5671A can operate at 2500base-X, but report 1.2GBd NRZ in // their EEPROM SFP_QUIRK("HUAWEI", "MA5671A", sfp_quirk_2500basex,