From patchwork Mon Mar 27 16:00:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Poimboeuf X-Patchwork-Id: 75544 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:3404:b0:112:7285:5352 with SMTP id h4csp1532415rwd; Mon, 27 Mar 2023 09:15:16 -0700 (PDT) X-Google-Smtp-Source: AKy350YfD+Oq1fbg22QrQq1LEzr/KCl5Qmqk/gS0mlcsyX4iF9NNYWbGBBAYrhbs4Nzp7veuDLUf X-Received: by 2002:a17:907:1c95:b0:93d:e6c8:ed5e with SMTP id nb21-20020a1709071c9500b0093de6c8ed5emr14950943ejc.20.1679933716398; Mon, 27 Mar 2023 09:15:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679933716; cv=none; d=google.com; s=arc-20160816; b=AaOtSvFs7cGGMOgvPLnds0p7SPdOBtINaL9vAHK5Ql2eN6wfqm6IcHcwMxtnY2Zrou 2WhsXeRcgh6dwbw5r2wYQMQY2gI/qDHfXhID5hMY/ZLoMKZlI5yHFy/XFEUV440r2amM oPlIia36upMazH4KrmN8QwSigpHiwn81ESu4TJNxKFcE/uthIfpvAdqp7EDnVQI2CWmb zhd2kfXTtb0h6WRYrIUc/BLJUvP4QdVB1MlpyDzqJl8cZMDQM0k5tMZRzt+vbwM9jrHt Uoa+RE1pd9hu4td0M5ed4c0enjU1U9/Wf0M+pKKYPps65bJNQqnVajyPNfntbXADZUDC 6JIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FO27veqfKklp7/B8Iqp7KNeb07+qdG7JO7K1jLrX2fs=; b=I+Ks6AdUQHBJHhHX7fSBc8y608/HXRtS9oAwCmgPaGalFv84qRVXdswUMSset6HhD5 bMCg5Vx47Vq0PZ0flxT8dJmtfoLypxPsNWFNV/FgeqRrg8ugzNaXYk4GHnbXWJs+Z98I 4LntNPqN8Dk3SN+18rcPOozQUO2043skV2ISgxN5L5MjUUclqVSMHKcIy1xx7nPT+bWZ 461QJoXGj++1RSYzJ6Bb3VW3lTThBrhxs42NW1jER8/RaNeIQ/ZKMoLexOTuNNEx2WRZ IB+pYWbvQXsqQBETr65a/nhCWMbJxN0/vHiDLnLFn3tjdkC+UQZS9WEwNes1g/Fahblj ufJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ce8fKwBD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rb9-20020a170907690900b009333a755b3bsi21368479ejc.460.2023.03.27.09.14.51; Mon, 27 Mar 2023 09:15:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ce8fKwBD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233001AbjC0QBd (ORCPT + 99 others); Mon, 27 Mar 2023 12:01:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232885AbjC0QBN (ORCPT ); Mon, 27 Mar 2023 12:01:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6413A65A1 for ; Mon, 27 Mar 2023 09:00:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F34606136E for ; Mon, 27 Mar 2023 16:00:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AA57C4339B; Mon, 27 Mar 2023 16:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679932856; bh=q9Vpi9kjIy4hLyGLwLZZ/FrbCreS4bEtiQO84AJpizA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ce8fKwBD6Dw2NN7jzRcnIZfQhhi1c3/If+5JYNRxH8r9ImWozIW/nFAt3O5YlUHCM a/lkGW/n8x4sQc9a1cKMi78zWRO8e8aa8xolV3pvq+A0vsqTHaxoIPpPYuAGFNRiUg 2Ncezskn9wnNWwDYTdX0D16z4PQ9REaLLcZyTm8Yb3d8z0+BspRNbBctgTCpKzaF5A Fb89O1bUAoxOvuLfQ4oyeY0R5+wALY4GC4Axz/L9uX7JDGfM/LPRXJqNTTQtA/CYAt UCxdhbKwY6t872sHXpD0DfyVBInkwKIqUUlODfvrQSElN6Py31W+Zrc+TanMf6N4ZV hwJLMXRYIg+fA== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Peter Zijlstra Subject: [PATCH 3/5] objtool: Remove superfluous dead_end_function() check Date: Mon, 27 Mar 2023 09:00:46 -0700 Message-Id: <5e314b6d68090f3aa32e5e02551e6a8db62d6728.1679932620.git.jpoimboe@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761538176411387332?= X-GMAIL-MSGID: =?utf-8?q?1761538176411387332?= annotate_call_site() already sets 'insn->dead_end' for calls to dead end functions. Signed-off-by: Josh Poimboeuf --- tools/objtool/check.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index a652b9e5c805..73dd091c0075 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -4140,8 +4140,7 @@ static bool ignore_unreachable_insn(struct objtool_file *file, struct instructio * It may also insert a UD2 after calling a __noreturn function. */ prev_insn = prev_insn_same_sec(file, insn); - if ((prev_insn->dead_end || - dead_end_function(file, insn_call_dest(prev_insn))) && + if (prev_insn->dead_end && (insn->type == INSN_BUG || (insn->type == INSN_JUMP_UNCONDITIONAL && insn->jump_dest && insn->jump_dest->type == INSN_BUG)))