From patchwork Wed Dec 27 16:26:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183518 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1532967dyb; Wed, 27 Dec 2023 08:29:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYVTciX4O5lxybnpPzCL6CaLgwge/dei8tNQzC2jGaBKXcyha/CYFvfGDdElCczx5eddjp X-Received: by 2002:a05:6808:16a4:b0:3bb:8021:7d9b with SMTP id bb36-20020a05680816a400b003bb80217d9bmr9110880oib.91.1703694540849; Wed, 27 Dec 2023 08:29:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694540; cv=none; d=google.com; s=arc-20160816; b=RetrDpUkRkSMvqAqZRBXzUVMBbwYa6/bAoRyTj1K5a274eieR4AjTWN8FMmOka1TDI pUV2sHndvQp97MyHG5O5HPFYHOENJ+JEfMzSkJB6p07TjDvofKTi5GU4t+623n5xkyPB V2Byj7Yb26wjEiZgneIW/xC8/JL3E2VGGwP6exi8KBWfu4+N1Wb3n+J/eF/La2lk3tQU VW2rvljor84kFAN/bjluqUaOfrJtc/90fhFb35smzHr2ipUFjZ8W1tGxiMwp4lPC8N6E /TKc6no9Fp5Bmq0VUmF0/pU1jVnZCkZ7rsrMLVcblB9A/eEPILDBoaqX0YbRXdDchItd M5lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=QdSW832qXq+pFGBmudFy89fudOYigaDKiGzZCxxrCMY=; fh=mslbplF7pyPB4FwwbMkb69JqaQYQCRyEhCJnroWAO+A=; b=oogekEY2GOS3xCJ0cZhnATUErs6kRGOX8JwglPsLo0/LA66VB39R00NAOSbBKcFOKo XWP2Ca3UqVnasPVA6w6CBxCQIkSOQqNGHdME8f635CgQP+EVwQcZ4KNns/mkleCjzKGT /+rmDmpQe6RKKOSAhyg2nsKKookJIzUaBWKeSIdhg/458BBh9YmcPsCDBWeNyhh6hmv9 2Qk93RbyeBW9oNq4So7LUiDwUea08jDT1Nk4C9TN2nyDkqqF8hHQXK5rxS3LeMnwz6/I MNH0NkExK5nGE0w4niOH0QOTLQ33ZOsStSHRCEWezfZc92IaV8mEgSTHh8KDATgwKWb/ ew7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12133-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12133-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h1-20020a0cf201000000b0067f6b017e53si14347042qvk.585.2023.12.27.08.29.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:29:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12133-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12133-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12133-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9F3EB1C219B5 for ; Wed, 27 Dec 2023 16:29:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 667D748CCB; Wed, 27 Dec 2023 16:26:59 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CF4D47F41 for ; Wed, 27 Dec 2023 16:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWk0-00059y-0b; Wed, 27 Dec 2023 17:26:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjy-001tZc-14; Wed, 27 Dec 2023 17:26:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjz-001Wn5-08; Wed, 27 Dec 2023 17:26:43 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Florian Fainelli , Kieran Bingham , Arnd Bergmann , Rob Herring Cc: kernel@pengutronix.de, Broadcom internal kernel review list , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/11] firmware: raspberrypi: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:31 +0100 Message-ID: <5df31ef3c069f45634631c9c639bbb60ab1d4798.1703693980.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1900; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=8OnFnV9+Q+XjHGFocc6jyNJphVm9oGZbvop0yAJNf9o=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA5eCGsDsplPuScmklfE3nyikx3e0+FJY3l8 BL3mj5KWsuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQOQAKCRCPgPtYfRL+ TrYJB/wKMxZ0dVeqePWzIe13JUFhLVI4QUjz0EFQb5Rn475cfqK+B7i3dx0wcVewGUkDahlovG2 tdfvhL//8Gt6HvqFq2H+aCEBbKA4BHa48gkArRdq6xQEZDt5z0rQld5osnTbW0IDOdPoYaNuxo5 mkLOex1INSKouwkConwu8R0j9KDoV2neCB/vd0WEhYl0KpkvNgNdCBWBvMxmtoqSGdvAjb9+zb7 qwYQ7p93oWEIF4p9nBNulGEjF14nU7UlVrhmDf7OSOreQ02WFGTaYPacVKdTH9dxk/m5za93xoD 3zuzyc/kgU28KdvmxsL8G2Y1/r2et4CQOAkdyHhWt/k34anG X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453207270832173 X-GMAIL-MSGID: 1786453207270832173 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Florian Fainelli --- drivers/firmware/raspberrypi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c index 4cd290a60fba..322aada20f74 100644 --- a/drivers/firmware/raspberrypi.c +++ b/drivers/firmware/raspberrypi.c @@ -317,7 +317,7 @@ static void rpi_firmware_shutdown(struct platform_device *pdev) rpi_firmware_property(fw, RPI_FIRMWARE_NOTIFY_REBOOT, NULL, 0); } -static int rpi_firmware_remove(struct platform_device *pdev) +static void rpi_firmware_remove(struct platform_device *pdev) { struct rpi_firmware *fw = platform_get_drvdata(pdev); @@ -327,8 +327,6 @@ static int rpi_firmware_remove(struct platform_device *pdev) rpi_clk = NULL; rpi_firmware_put(fw); - - return 0; } static const struct of_device_id rpi_firmware_of_match[] = { @@ -406,7 +404,7 @@ static struct platform_driver rpi_firmware_driver = { }, .probe = rpi_firmware_probe, .shutdown = rpi_firmware_shutdown, - .remove = rpi_firmware_remove, + .remove_new = rpi_firmware_remove, }; module_platform_driver(rpi_firmware_driver);