From patchwork Wed Sep 13 14:08:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 138817 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp1116954vqx; Wed, 13 Sep 2023 07:15:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGgfhItIJVj8tU1Aa4zz4xAb1zLUnmDWtX5YMWpZmrZyxfkbxGRTJz/fwXDajhccgvbeCh1 X-Received: by 2002:a17:902:f809:b0:1c3:f09b:2f44 with SMTP id ix9-20020a170902f80900b001c3f09b2f44mr1068962plb.38.1694614514498; Wed, 13 Sep 2023 07:15:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694614514; cv=none; d=google.com; s=arc-20160816; b=WqboR4BcH5K67hqJDPXD/8eU+LHdOhOPrWd4jz0Ya30fHVcQxyu+N/9vwtRvSzct0P rbStt4FPXMLB4EosuyQak0Wvv2lcg7ahBePbRoAvDZcac3bEqJV+DEILgp+DdHrqZo1h kbuMpbtsQGUeBOul+I9o6YR+HJGSAhOfnM6orQYecxuc0knk8tU4Lm+XPS5jJ2ceP02t wotpeKjB+ApKzQ2Eu0ksRRvRhFZZ0QCM9JMyRK+VwirItLeY/vGABOhiDRYEOje50oMw SjR8zjjMV4xUGLRbPakK/zwXOOimy9+ignFcak/5WG/4kzf0aL87j5cBDwG+0Ue1xy40 9eCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=vh2TYUNJonlIeWs/tVAZczatv9QG1cU/hJr9iuyzBG4=; fh=fKMC3BTGjlLXl5EvEhzqt3WHCynqYJKK7wAqLAOkWUw=; b=rKcZrlPI+oWsK7FKgAop0Jfr+dmvuZFRuVrQO1sdDRA6BKdROV7dU9OB9HlumBlZsH bTnYivoOf4f6omti1CPhISEQLEKCuPItK6VlMAp10YvmGMlFlOpeh1uXf5L9c4Gaoj8H D1wm3KOIWlWoIMqPQJF5IGXLG+RlaKp6Wa07OifpZR3vMCHrbRhvNa1gVxsjn4XqvNW8 Zg2VknsVfx35it3pvJLNtmZmxV2c1JSnvqig3DbjcE4ynwREcwW5Diqr0vMhe/UR4DfJ OBqjr4zwFMVZbv9wZUd8I3zH63JWcANeFjYHYlYDzpPDU2yjEAKRp+ESngTdRwk5663t gwBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id d2-20020a170903230200b001bb98357332si4821136plh.365.2023.09.13.07.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 07:15:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C17EF8050609; Wed, 13 Sep 2023 07:09:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241362AbjIMOJS (ORCPT + 36 others); Wed, 13 Sep 2023 10:09:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241267AbjIMOI4 (ORCPT ); Wed, 13 Sep 2023 10:08:56 -0400 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84E431BDF for ; Wed, 13 Sep 2023 07:08:50 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:f674:9611:cd05:f25a]) by baptiste.telenet-ops.be with bizsmtp id lS8n2A0083fvA4V01S8nqF; Wed, 13 Sep 2023 16:08:48 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qgQXd-003csQ-QR; Wed, 13 Sep 2023 16:08:47 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qgQXv-00FV5C-5J; Wed, 13 Sep 2023 16:08:47 +0200 From: Geert Uytterhoeven To: linux-m68k@lists.linux-m68k.org Cc: Arnd Bergmann , Finn Thain , Michael Schmitz , Philip Blundell , Greg Ungerer , Joshua Thompson , Sam Creasey , Laurent Vivier , linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2 23/52] m68k: apollo: Remove unused debug console functions Date: Wed, 13 Sep 2023 16:08:13 +0200 Message-Id: <5da9036914a5c84c20b6af55f1801f0c734a96bb.1694613528.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 13 Sep 2023 07:09:37 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776932108832499782 X-GMAIL-MSGID: 1776932108832499782 When building with W=1: arch/m68k/apollo/config.c:111:5: warning: no previous prototype for ‘dn_serial_console_wait_key’ [-Wmissing-prototypes] 111 | int dn_serial_console_wait_key(struct console *co) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/m68k/apollo/config.c:118:6: warning: no previous prototype for ‘dn_serial_console_write’ [-Wmissing-prototypes] 118 | void dn_serial_console_write (struct console *co, const char *str,unsigned int count) | ^~~~~~~~~~~~~~~~~~~~~~~ arch/m68k/apollo/config.c:238:6: warning: no previous prototype for ‘dn_dummy_waitbut’ [-Wmissing-prototypes] 240 | void dn_dummy_waitbut(void) { | ^~~~~~~~~~~~~~~~ Fix this by removing these unused functions. The last user of dn_serial_console_write() was removed in v2.3.41. The other functions never had any users. Signed-off-by: Geert Uytterhoeven Acked-by: Arnd Bergmann --- v2: - Add Acked-by. --- arch/m68k/apollo/config.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c index 42a8b8e2b664226a..fccbb40772dca6b9 100644 --- a/arch/m68k/apollo/config.c +++ b/arch/m68k/apollo/config.c @@ -4,7 +4,6 @@ #include #include #include -#include #include #include #include @@ -108,27 +107,6 @@ static void __init dn_setup_model(void) } -int dn_serial_console_wait_key(struct console *co) { - - while(!(sio01.srb_csrb & 1)) - barrier(); - return sio01.rhrb_thrb; -} - -void dn_serial_console_write (struct console *co, const char *str,unsigned int count) -{ - while(count--) { - if (*str == '\n') { - sio01.rhrb_thrb = (unsigned char)'\r'; - while (!(sio01.srb_csrb & 0x4)) - ; - } - sio01.rhrb_thrb = (unsigned char)*str++; - while (!(sio01.srb_csrb & 0x4)) - ; - } -} - void dn_serial_print (const char *str) { while (*str) { @@ -237,12 +215,6 @@ void dn_dummy_reset(void) { } -void dn_dummy_waitbut(void) { - - dn_serial_print("waitbut\n"); - -} - static void dn_get_model(char *model) { strcpy(model, "Apollo ");