diff mbox series

fs/ntfs3: Correct mode for label entry inside /proc/fs/ntfs3/

Message ID 5ce7410b-3715-dabb-0135-139f86546337@paragon-software.com
State New
Headers
Series fs/ntfs3: Correct mode for label entry inside /proc/fs/ntfs3/ |

Commit Message

Konstantin Komarov July 3, 2023, 7:33 a.m. UTC 
  Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
---
  fs/ntfs3/super.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)

      }
diff mbox series

Patch

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index e36769eac7de..1a02072b6b0e 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -1548,11 +1548,12 @@  static int ntfs_fill_super(struct super_block 
*sb, struct fs_context *fc)
      /* Create /proc/fs/ntfs3/.. */
      if (proc_info_root) {
          struct proc_dir_entry *e = proc_mkdir(sb->s_id, proc_info_root);
+        static_assert((S_IRUGO | S_IWUSR) == 0644);
          if (e) {
-            proc_create_data("volinfo", S_IFREG | S_IRUGO, e,
+            proc_create_data("volinfo", S_IRUGO, e,
                       &ntfs3_volinfo_fops, sb);
-            proc_create_data("label", S_IFREG | S_IRUGO | S_IWUGO,
-                     e, &ntfs3_label_fops, sb);
+            proc_create_data("label", S_IRUGO | S_IWUSR, e,
+                     &ntfs3_label_fops, sb);
              sbi->procdir = e;
          }