From patchwork Thu Apr 6 06:26:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matija Glavinic Pecotic X-Patchwork-Id: 80074 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp816558vqo; Wed, 5 Apr 2023 23:40:50 -0700 (PDT) X-Google-Smtp-Source: AKy350bDgQYjFCmnUvwordJls620O7qfRNjMrcBhNWY1l1crssmw2DwqlOIsJYZ+wrWqIXB7XGE3 X-Received: by 2002:aa7:d9cc:0:b0:4fa:b05e:ced5 with SMTP id v12-20020aa7d9cc000000b004fab05eced5mr3532522eds.36.1680763250411; Wed, 05 Apr 2023 23:40:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1680763250; cv=pass; d=google.com; s=arc-20160816; b=luEYUxpG1QXFyh6x7JVsqMXp6aPYaggbS0zvZZ7p5iNLQzEZBXM7uvtKia8VIGs9NV 7OGHEk045NxQgmnsqcob1YnCd9H5syEy5/bL56I1iCC39+WF2wZFZmMgb8TgVhXRslDt gN3rAya0xfVTxXPHkH9cHner0ZPtYP++oyFSm2jGXjEryUcjPw4pQnGx4y04fKftTGU9 bSkqwEbnxPPCRCcEr73KNUP4mGO/2UBYzYvHifti+Cirn1JSZlMnyWCVC7XWfehKPC+1 UIj4L/oZ9Lq6ZVqza45tI7jADUjzo1Qrmz8qQXEpb0S+h0zIuMdlc7EWgBNwmw8iAOZA Yn4w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding:subject :from:to:content-language:user-agent:date:message-id:dkim-signature; bh=/mCFsc1POSZFfhHy/0iFbaCXE3Jqk9xABbzorxWwGHY=; b=BuukeXoi6+QC4qdfN1UKbjLsgJ5263X0QJc7MnMtgURNLuFn6qH7fNZAvsUQ0JdGTn L/BmbwehbF25StoUeYn7q4r3PTPToOCKw9TvR6SjwJCEqn6Bqez/JAvG4gsGAJ+y1ziY 8qs5KwIbvHnWMIYFDeX6HWzQVn68NR7vZCjv2w6taYC2rw/JW8lJKNEFGD6BdJbTQSkE m1GVJLJhdfjSc6QnhpOEcXhc9/CvS1BKkPeC2OY3e+765NegwFMBBwrJleWONAyQwv1d ttHC22yAB9VbmBOeAZHJGn5qminYdkVJeZ3zBfI4LnaUebEHFFwYzdzTyE3g7gFdzhoE Y8pA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nokia.com header.s=selector2 header.b=DxAOC16c; arc=pass (i=1 spf=pass spfdomain=nokia.com dkim=pass dkdomain=nokia.com dmarc=pass fromdomain=nokia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nokia.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l15-20020aa7c3cf000000b004af7e6911e7si561435edr.528.2023.04.05.23.40.24; Wed, 05 Apr 2023 23:40:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nokia.com header.s=selector2 header.b=DxAOC16c; arc=pass (i=1 spf=pass spfdomain=nokia.com dkim=pass dkdomain=nokia.com dmarc=pass fromdomain=nokia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nokia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235135AbjDFG1P (ORCPT + 99 others); Thu, 6 Apr 2023 02:27:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235323AbjDFG1I (ORCPT ); Thu, 6 Apr 2023 02:27:08 -0400 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2099.outbound.protection.outlook.com [40.107.20.99]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCE9AA5CA for ; Wed, 5 Apr 2023 23:26:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N2ifxgZDZbwsywJjwo/k3m8Ml4fzx+JkAelOjPfCwvxAQEWvuSCKfCS1SDeAsH5FVOVsaEbtPXILCyq6uznjCp48eLFKIGUeSw6Hsc3TbIei5y5COvfLPMvE/Em0VwOVLvC8cI521nq5WypKcMaxH7vaCNQkh+LCizHgUui7pKcRm9+nxsjROUfmkIXO5+Iiy9Dhk4we91TBJWjYVT/9RhsHnMtIOpOXCOYmj4/Op6mH7EfWcVYYnN8Vt2nwKBqKMZJeaaxWMf70bD15jRPvjchOJmHCmaPN+TPjmf8po7+c9flkOvAlwx9CEaqi7quHXxqejTIZk2O1H/oUBfMs6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/mCFsc1POSZFfhHy/0iFbaCXE3Jqk9xABbzorxWwGHY=; b=nBum7cvjhv/QT/AoMZPW4kNNgNaUzx2Boeaq6MHv1r3hlXVHT0LsZIldeGterKnfoIpbLcrLm32kuapaBQE18LO+U/vyedn8t4A9Yj8VxfaKTlpiLDtBSREpvs+xPIEo2vTBMFVKqEYV3g9j7OuIf6thjp8BG0EXPVE5noJ3poyOYyXaYO2170SFag1prlASGJOP+8RokPOb3QNz3o0ZcN/XiyOov94+IbaSSRvRp1fvGjHPtlVXyLiShOByqpEb19EAn9BRG+ZaKdV1SZ3Z7X+UArqwDCUnXBWXvy3yzpBC/jkR55a5s4DZKPTKbhi9RgqaK5/sV2PyshcIUTR43g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/mCFsc1POSZFfhHy/0iFbaCXE3Jqk9xABbzorxWwGHY=; b=DxAOC16cMQiaxAXh5g9THDvT2A4TIDrTGVof7w1QDDVUGcOsCOGZP1mCXZG35GhP2xFXUwkCMKPZ0/Kcbu1SM/4q9T1rkVcVncfi11ojysEwAfnEG2p87UaXDcVThsoC6iFQv9+23ejf3vyf+61eUFzKdSlWr4exHu8SPrq34wIfoVsC3/ybbB3VMuyKs76nvrfp29J6Lr5XDynwjQJOijwjYhfoC6vJra0U1rn6MC4V5lB7njoVUeFE/bnogxLcLgyoKsjwl3EgSsLFieAJIty7Wcj3eGP+RWP4lqRf92HLmpCgPTF/jfceo6az3nCRb6usbmnbmcOjt3Y08LdtLQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com; Received: from AM6PR07MB4535.eurprd07.prod.outlook.com (2603:10a6:20b:17::17) by AS8PR07MB7446.eurprd07.prod.outlook.com (2603:10a6:20b:2a0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 06:26:55 +0000 Received: from AM6PR07MB4535.eurprd07.prod.outlook.com ([fe80::5eff:1178:303f:7ba9]) by AM6PR07MB4535.eurprd07.prod.outlook.com ([fe80::5eff:1178:303f:7ba9%4]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 06:26:55 +0000 Message-ID: <59f7ceb1-446b-1d3d-0bc8-1f0ee94b1e18@nokia.com> Date: Thu, 6 Apr 2023 08:26:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, Linux Kernel Mailing List , Andy Shevchenko , hpa@zytor.com From: Matija Glavinic Pecotic Subject: [PATCH v4 RESEND] x86/rtc: Remove __init for runtime functions X-ClientProxiedBy: VI1PR0102CA0072.eurprd01.prod.exchangelabs.com (2603:10a6:803::49) To AM6PR07MB4535.eurprd07.prod.outlook.com (2603:10a6:20b:17::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR07MB4535:EE_|AS8PR07MB7446:EE_ X-MS-Office365-Filtering-Correlation-Id: 2dc1505d-9aa1-4791-eaac-08db3667ea79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ir5W/TIl55mErdrQAMK7FJjuXXCsDL2sFaW3rK7B/Ifd1xqa93NxsiRGheSrYrsr31HNiTvc8IiKrW8dga4Ytll4muTaWsCZxL+7DE41FPHlE2NscQk4Ljqk+M09TjYzCYae/5ClHH68CR+tMX7pND3GML/khW9eWYUEVyjsKTd9uNKDmf9sXmJ7jAbo3OM2AO8+N7HGSTdUFPUO7vduqtKnW5Xu2a7Dx6UEeQJpvkVPK6WJOBpDarUTvkKe5jEVg49Ej3kpgFjLPJXS+b0yFW0+O7fRnD55DPEHM17cAURv4Uxsr8/TMWV5JuiJm4qvIpMfb+P/13wjEbF9vfLd9OuCpwtUNSrVM2OF1ts90/PQI9i5mMooRdPtxKa1OPjEN3x1kYvLN2SmGlddlwD4OLlZy7PiQNrfTfiJY6kHbXw1tmjUK6cY/TgfhVykHWpDLvmg6BDVEpa0d6xS3s1HtydV7NBsJgVbkIcgjxZn97Y0p1wRsj4z4b5Fs9+ojg5FtSmbs0evea3npE5aY0K4iaLnSUY+F84xXYwiBwfo9V7ExAY83JBl2gFvKz1B7fXi70t6Um2MfYnf7L7JzY7JyCnWL+C+/PNndVbUhkTauGJ12ohQAZpJjR9NzDdaZ1GPTw1HRMWur09d7Ovn9Sik+P+SNGxvRVxr+qyXlg1lSk/S5utFKth+j3x+T/GD/Jt1c98NUnUW5eNUztfca9LWpw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR07MB4535.eurprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(376002)(346002)(136003)(39860400002)(451199021)(8676002)(66946007)(66556008)(66476007)(478600001)(110136005)(316002)(8936002)(5660300002)(41300700001)(82960400001)(38100700002)(186003)(55236004)(83380400001)(2616005)(6666004)(6486002)(6512007)(6506007)(26005)(86362001)(31696002)(36756003)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?GGFIqNmPlON+4o1RDaa8JfJnY48F?= =?utf-8?q?jIbVDklMRoqH7klQoJZm4zVOPIJ/oGiGQmu+InpLKPX6wH1bMBNu0xcWrJhgzxq/S?= =?utf-8?q?V8Mtk5hHA8dTg9tQMEhMRH96U2N9G8lcnZ2nsOoRKQQF7UwhwmVIWmxhUkBcBP428?= =?utf-8?q?oH/Gu4LsO9id2HeLwmfeuPtcI4y5up40gzF5HdmfxoSitdHLmwZVgOcCBRS/aNsjj?= =?utf-8?q?fS6JZyjOgq6v0bW+PLTjozHpKxIHTv3XRhXf/pXj/Jr6R1WpufLgcSqhOAMMsHOHU?= =?utf-8?q?N8IsORF/BYBJQDuK5E37X1PyEYMhhta7tbO++V5dfDpISH8TRG7F5ZIBaoD8YobUf?= =?utf-8?q?mUzWSKEosswAULr2kueEwUJRVD03R8b4vS5q/OjJJ+u53TOtHIJZyFeyuhoQaHNCz?= =?utf-8?q?jfMdoaQ0iJ5RSwGu8K5dUOlIix+mTiO4TQy8GzgChkAS4YvEAra+AMhVpXJnYH89C?= =?utf-8?q?gKI0Zmp8UH4z6SSfzLxBJ831l9j8wxew3LJFL3owYOcB0uni/Im0HcQlWPWAUySlO?= =?utf-8?q?VIZP+jmxU1jOlM3GCLwxYg9n1GaVc8WagnWe0cj1XfKre+cl4wTfpUjZs70UY1LwH?= =?utf-8?q?6NsWlQTHLiU9UGYicUg0VVcO8Yc4XnsX0MWRFjGteVWzFAEVkK6yL0XdVYoMHLUSd?= =?utf-8?q?BapeeeJr2vY0ZLsm2T0G1BPS1tVgwLjf7t+x9ej+poR9H856XpCFmvBNoQueaVC46?= =?utf-8?q?lAmDFM9jv1IXfNNHGh5vjJRSNx5QaAbkD4HC8y6+x1gb3EHQxDtxQmqXFfyFZb1A1?= =?utf-8?q?s5Go+6WGZIQe/BTPA9MSVAv5J91cgh+AsuuhU6S2voSwDHHypzt2NorLekhlYYqtE?= =?utf-8?q?ymw+c6xjsRLyDOVhalateCvURXiOD2d9oqccn1VhbAjvpXPodfmXa2xE27VMGTYeq?= =?utf-8?q?bXsemF1zovKNyHr4hldVciZnJjrmCGr6TFm841b8l+s8ZQtW4JL4xGYc/hdNsc7+u?= =?utf-8?q?Os3nKNQP98ilOmQkqG1swn52K10MfgVeLhNq4uYXsKBkfflEBnReGQtNfFTfwYZBr?= =?utf-8?q?m8mkUFtdq69lsy7evMQiMFPRiIPqeA13rOLZkepENJL/q/dm5K2DwtX5WiPtXCCs/?= =?utf-8?q?GrEJ/+4evSynXrt7ptePy+qdn3dl+pyi4lW5We/qTvs0FZ3zmKvkTfV6bT1vmehDS?= =?utf-8?q?3cyTQk/4g8jJ3jP8izyXgNTO9zRhedt2OjaYNjp5Fb+LvI7tRwX5Twd1cyuHjlAfQ?= =?utf-8?q?A+uioDYOuvVLy7vZRV8+qdxFgY8NHrM140KBrQuPbBvMwh9tFuEqFy1Rq+ZE6KKAh?= =?utf-8?q?keYzQYOO3Zp+tEIJIUEOxHV62Ap/RgOOE5d9dyVjWqHYdqV8cGyUHLxLjvSmpqkmI?= =?utf-8?q?TU1+1cm7Vg2hh3EM2PmdT4m3GfMLs8/IaXtfBzBS2vp+62vs1CsPapRaJPGX+u7FK?= =?utf-8?q?hc3aYf/Gfdl3BxNHfpEIlzqVQ6yX/CzX6Gj6gKJ4PIjcuStWj7YxRsb7ioljl+gha?= =?utf-8?q?vK8AKLAkacA3TW5i4mNUR6G7H1jha75c7oilqCIwV0mDA34lf7mLIwO1dXjnV0O8F?= =?utf-8?q?cxlGU3kESdS2vxxHBCWzyjfi8sm+7PnqvHrsFnMXwBuc0s1zM5VM6Pc=3D?= X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2dc1505d-9aa1-4791-eaac-08db3667ea79 X-MS-Exchange-CrossTenant-AuthSource: AM6PR07MB4535.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 06:26:54.9900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C6WHlSTJPC8ZNVaO4GP2EA5rtKSaKUY9/Ib0+DKk0rbuxXx4H0jxe0b6ewxWYbOlMk1yFWrfM1FinGBw5agzlftr1xKeRFIuO431pQC91cNYOHQno9OzoA/hePixSGM5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR07MB7446 X-Spam-Status: No, score=0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762408006175163835?= X-GMAIL-MSGID: =?utf-8?q?1762408006175163835?= set_rtc_noop, get_rtc_noop are used runtime, therefore need init removed. Crash was observed on x86 platform where cmos rtc is unused and disabled via device tree. Function was triggered from ntp: sync_hw_clock, although CONFIG_RTC_SYSTOHC=n, however sync_cmos_clock doesn't honour that. Workqueue: events_power_efficient sync_hw_clock RIP: 0010:set_rtc_noop Call Trace: update_persistent_clock64 sync_hw_clock Fix by dropping __init and making set/get_rtc_noop available runtime. Fixes: c311ed6183f4 ("x86/init: Allow DT configured systems to disable RTC at boot time") Reviewed-by: Andy Shevchenko Signed-off-by: Matija Glavinic Pecotic --- v4: Update commit subject and message, resend to proper addresses v3: Update commit message based on Andy's comments (further trim to backtrace, proper tag) v2: Update commit message based on Andy's comments arch/x86/kernel/x86_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c index ef80d361b463..10622cf2b30f 100644 --- a/arch/x86/kernel/x86_init.c +++ b/arch/x86/kernel/x86_init.c @@ -33,8 +33,8 @@ static int __init iommu_init_noop(void) { return 0; } static void iommu_shutdown_noop(void) { } bool __init bool_x86_init_noop(void) { return false; } void x86_op_int_noop(int cpu) { } -static __init int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } -static __init void get_rtc_noop(struct timespec64 *now) { } +static int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } +static void get_rtc_noop(struct timespec64 *now) { } static __initconst const struct of_device_id of_cmos_match[] = { { .compatible = "motorola,mc146818" },