From patchwork Sun Jun 18 13:06:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Hegde X-Patchwork-Id: 109618 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2468486vqr; Sun, 18 Jun 2023 06:43:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4QYf6oEod5zxWr2l4yEtes3kFMjSrtQZmFUm9a6v3w/YBJR8qwdTMn+LwpwTPRPg/h/wev X-Received: by 2002:a17:902:d509:b0:1b0:4a37:9ccc with SMTP id b9-20020a170902d50900b001b04a379cccmr8910498plg.62.1687095791861; Sun, 18 Jun 2023 06:43:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687095791; cv=none; d=google.com; s=arc-20160816; b=sYoH2YSoHEpxId0Hn5cHNevosZnBetRsl9cTXuwTY7EwKP8FD2JOhqqnYDPe9nbtee QZkNN47PIf3rpOQeHH+z+W1wzm0+XGYBjNR8TjEmDtO5FUGydQqmaVD45hVdYl21i6Is hRhL7LDkA1CIgvn664fACyB1Q/dPPtJNdlU/rrkzM8VmWyjBdoEgbpPkAwqYPfZXtryA 9ZfXNKkWDM28hWUIKTc/4Uk3tsHh2/1uN8tDIj3HbA3K4nlmt2lF6ormZtaLjUe/XroP GY49jUsmo6vazWAXmnQwJF6dcbhx+KPcHGhj8d3yqgwm790NT1OO6e3bsxrgwKwJMjjp n3vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ooiaPbgSDk2Vavd/yz78VigQmMncQVwP5N8EDeWNlmo=; b=DJ+o+4TaX0DW1NfZ5J3J0bGEweQPVfRG872THwhzO8+tqrtu/HCrV5hh8ICOT/vxzL TJSITr4tOnB80Xfgw0SGIKksNpZZiLW92omwBh3f8dCMP1+o9d2fQM1U7fp9HKYGsGpH lD8w4rEYPhhIGwio2G5mw003WKkfPfvgQaqNtSILFMoy3HjivXmRP/cCusfJxBwf++8A Vn4xo8ZdkbZaJi3mLT02nYMbP/860ajsvRpYHWDIdZ4WeAf1vYdPkzQxShLgLUO3pjby 7xVbAYiFXb9tyiVZRIeQ9Tta8fRiTQJjRQR2KRJ+/5CUhFtKHlfVJ5h9LClZc6XPwW/2 lXzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=j+it1mrQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j15-20020a170902da8f00b001aaeed1a0e3si14116210plx.487.2023.06.18.06.42.56; Sun, 18 Jun 2023 06:43:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=j+it1mrQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229579AbjFRNHG (ORCPT + 99 others); Sun, 18 Jun 2023 09:07:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjFRNHE (ORCPT ); Sun, 18 Jun 2023 09:07:04 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BEFEB0 for ; Sun, 18 Jun 2023 06:07:04 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-66615629689so2451331b3a.2 for ; Sun, 18 Jun 2023 06:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687093623; x=1689685623; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ooiaPbgSDk2Vavd/yz78VigQmMncQVwP5N8EDeWNlmo=; b=j+it1mrQUvR/fZDFPPpYHa5RUyGfo/KR3ts/RFYP6cRh8d32bZFpPVhN409/WDBC9X 6+7y6VwhwA1/XDSjGOy6p/VPFjpqG3+hhvk7JTfeOpzkBAKASts7Dla9lbrKFn3apDC2 DtV5jg5oZnTrtG9k/NCZ4+c3tM6z1aWzFh4/6JbZEDX9az+neu7UTbQrmU5boSSSq2Ec 41nuPaRAe537iaI+HSgVLBNbWp4BDJpbJCyr6EbTP9zjV0aCZfLDrAaj+nsuyNBOnf+P WX4w0d/J0lZcmgy+acQq5cq7ICtuMv0E9KxCk4Rez3AjBHZkwqv0tfp42afWRR7khSKm K8TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687093623; x=1689685623; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ooiaPbgSDk2Vavd/yz78VigQmMncQVwP5N8EDeWNlmo=; b=f5MvmHcTZ1bSqrgrfduAq6X6FTc3kXPPS2253cXx8Zucm/BMX6Cpq6woS9P1NmSZsd qvX4E06i+ouCWou6pQbpN2aFDW47b/zQjQC5Kw2D0aZ3r/W0qK6j6yo5oTjqU5n3i7bO BfB1N0Q34Oe6NHBdGrBDIOFeChPbp5aVC4yxGB8K0+Pd08AMSCJAeqgSYolUv96p1N1C +mKTbNiX1fY/dHV/U493eGM1LiFRu43bhJI9yyb2P0D8GQbrS6ehjvcAK302jNkSbPX2 1eK3a2Vp9niESw1SUftU6WPKqUAJfIZmD7yA65s92xZNOWtQhA19Z9chySo+yzz8zTzr J+pQ== X-Gm-Message-State: AC+VfDxfJe6achOjHrvEAPEjitJfQD5nVmflqMhZUpty9xRblKnAhrrx Jwd7zlpnhWaCuS5ac7sVasY= X-Received: by 2002:a05:6a00:1691:b0:665:c10f:709c with SMTP id k17-20020a056a00169100b00665c10f709cmr11340188pfc.21.1687093623535; Sun, 18 Jun 2023 06:07:03 -0700 (PDT) Received: from zephyrusG14 ([103.251.210.211]) by smtp.gmail.com with ESMTPSA id y9-20020aa78049000000b0065e154bac6dsm16159760pfm.133.2023.06.18.06.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jun 2023 06:07:03 -0700 (PDT) Date: Sun, 18 Jun 2023 18:36:58 +0530 From: Yogesh Hegde To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, philipp.g.hortmann@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, ivan.orlov0322@gmail.com Subject: [PATCH v3 4/4] staging: rtl8192e: Rename variable InitialGainHandler Message-ID: <59e1d108e07a159e766d33df1556ffbeab1f7693.1687092111.git.yogi.kernel@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769048156968017460?= X-GMAIL-MSGID: =?utf-8?q?1769048156968017460?= Rename variable InitialGainHandler to init_gain_handler to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde --- v3: Revert back to v1 of the patch as suggested by Greg Kroah-Hartman . v2: Removed the variable and called the function directly instead of just renaming the variable as suggested by Greg Kroah-Hartman . --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c index 7b0da55fa7aa..267fc6f8800e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -1109,11 +1109,11 @@ void rtl92e_scan_op_backup(struct net_device *dev, u8 Operation) if (priv->up) { switch (Operation) { case SCAN_OPT_BACKUP: - priv->rtllib->InitialGainHandler(dev, IG_Backup); + priv->rtllib->init_gain_handler(dev, IG_Backup); break; case SCAN_OPT_RESTORE: - priv->rtllib->InitialGainHandler(dev, IG_Restore); + priv->rtllib->init_gain_handler(dev, IG_Restore); break; } } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index b82d2b7aa26c..eb20b8014997 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -734,7 +734,7 @@ static void _rtl92e_init_priv_handler(struct net_device *dev) priv->rtllib->SetHwRegHandler = rtl92e_set_reg; priv->rtllib->AllowAllDestAddrHandler = rtl92e_set_monitor_mode; - priv->rtllib->InitialGainHandler = rtl92e_init_gain; + priv->rtllib->init_gain_handler = rtl92e_init_gain; priv->rtllib->rtllib_ips_leave_wq = rtl92e_rtllib_ips_leave_wq; priv->rtllib->rtllib_ips_leave = rtl92e_rtllib_ips_leave; priv->rtllib->ScanOperationBackupHandler = rtl92e_scan_op_backup; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 0ee9b99b4c5e..0551f9b108f6 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1711,7 +1711,7 @@ struct rtllib_device { void (*set_wireless_mode)(struct net_device *dev, u8 wireless_mode); bool (*GetHalfNmodeSupportByAPsHandler)(struct net_device *dev); u8 (*rtllib_ap_sec_type)(struct rtllib_device *ieee); - void (*InitialGainHandler)(struct net_device *dev, u8 Operation); + void (*init_gain_handler)(struct net_device *dev, u8 Operation); void (*ScanOperationBackupHandler)(struct net_device *dev, u8 Operation); void (*SetHwRegHandler)(struct net_device *dev, u8 variable, u8 *val);