From patchwork Fri Sep 15 13:02:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Bristot de Oliveira X-Patchwork-Id: 140424 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1030236vqi; Fri, 15 Sep 2023 06:07:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUWOOsXPR2ywjfNQXEX4vP6QQOCzfEq9CXBp4SBIeEulE0tS8PDE6aJTzqpi4gYKyrstbP X-Received: by 2002:a17:90b:250:b0:26c:f6db:ad77 with SMTP id fz16-20020a17090b025000b0026cf6dbad77mr1345834pjb.2.1694783259989; Fri, 15 Sep 2023 06:07:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694783259; cv=none; d=google.com; s=arc-20160816; b=tJCx65pWMlWG5NOaRmOMyE0EBX3EU4f4OFq7ILyKwRhB1TPY0HoRwgOfbn9gbCuOLk 12zZcHFiq7vRLCTOGe5sCULk6814DZcLnhVB91Nwv3f8LOFyTxdRBPRhZNFc0cf7lsOD Ek+6ZTkWDpdsocN4q/ijS0nUJ9+uTd8mVtQdOGqtKez2NBYCt+0kvAPBfzWTqHAty8mm GcZLyOQeHkNlBZz9bcCW3erHVFAWyvnjpvM49jTwUYgXBWw7P0SuiNOl+aK3KIHkSC0K GouEXiBkRgnRgbwljM5GCWkayXXWqWDhe+aKb+OjUIdKelI645Z1e0po7Q2NXA75Vy4x xMkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ep7pMYsni37Rta3nvXw117O20YuqPclXh6WtSNL5gIY=; fh=FhFlZeTOqBdKb5qW8LZUQRjwBUgSGZWcGo4/ppoyMH0=; b=lfUfKuqNQ4IGRg+VGI6zLYqOoMn8ePrujRmOcdSEybnIiNduS7GMLFs5Co/ZQpSC1u 9f0Du0RkXkf6datBPc8idl+nJAUpxD3Q/j8ESNU9IyOhR5yaB1yt81w4xCHOII/N/15B nyAI2Nm9ootQQUBFvftaTZsCOgvcJ4tCTvoFPQCRCcQcexfOKU43Eq/i1gzLsc1VKrMA ueIGfztUpw6HNXRwwY+cYLLTsIFvW8NBfXeQ246NQGg5XLidcVQTthuDjWA5JtmJWZHh 42t93RlwpIN66vpACJz7yDaQA8QJpESGw4H5Rqq8W8jjJBH3AtUAELqbDTjLZXZCzWhw I7aA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sdlLB7uZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id f11-20020a17090ab94b00b002680abd9398si3413497pjw.88.2023.09.15.06.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 06:07:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sdlLB7uZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 9696A8131C37; Fri, 15 Sep 2023 06:03:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235215AbjIONCp (ORCPT + 32 others); Fri, 15 Sep 2023 09:02:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235074AbjIONCp (ORCPT ); Fri, 15 Sep 2023 09:02:45 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98E0A1713; Fri, 15 Sep 2023 06:02:40 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F7A6C43140; Fri, 15 Sep 2023 13:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694782960; bh=PF90Mq9GKBKhxFzP0kY+WP/uPSlw1h/Ixf38Df80sAg=; h=From:To:Cc:Subject:Date:From; b=sdlLB7uZhOUd36nT6/0DPR3XafPHCIC5J5TscCYoPUoqqEkS3URooqj0j4t0eCyzG +F4MFAbxTjDq0J8nAF/TGGo+2Owbph+3iOCgAB8Y9s5qvQt5mMPXXT3P77bzDMf3D2 J7cocD61SHPXFDhs0bZkoGyzpurKcSF3qjsId7Dz+Kte9ac3pQWNkAmJTWGTF8AoVc 4zG0gNkKvXs2h0EGM5sp+bgz4sqTJU89jyJtGVJyvl2RBmSNVWNJK0E5NQJFWCE26D 99Knb9BzeDoMl4fkq4aP80h5m4SlMz3ZsZ8OE71qT6zYyQhhhmfkr+IzXHB+hXy7lJ EWyOkktOt8vwA== From: Daniel Bristot de Oliveira To: Daniel Bristot de Oliveira , Steven Rostedt Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] tools/rtla: Do not stop user-space if a cpu is offline Date: Fri, 15 Sep 2023 15:02:32 +0200 Message-Id: <59cf2c882900ab7de91c6ee33b382ac7fa6b4ed0.1694781909.git.bristot@kernel.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 15 Sep 2023 06:03:05 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777109051666976774 X-GMAIL-MSGID: 1777109051666976774 If no CPU list is passed, timerlat in user-space will dispatch one thread per sysconf(_SC_NPROCESSORS_CONF). However, not all CPU might be available, for instance, if HT is disabled. Currently, rtla timerlat is stopping the session if an user-space thread cannot set affinity to a CPU, or if a running user-space thread is killed. However, this is too restrictive. So, reduce the error to a debug message, and rtla timerlat run as long as there is at least one user-space thread alive. Fixes: cdca4f4e5e8e ("rtla/timerlat_top: Add timerlat user-space support") Signed-off-by: Daniel Bristot de Oliveira --- tools/tracing/rtla/src/timerlat_u.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/tracing/rtla/src/timerlat_u.c b/tools/tracing/rtla/src/timerlat_u.c index 05e310696dd5..01dbf9a6b5a5 100644 --- a/tools/tracing/rtla/src/timerlat_u.c +++ b/tools/tracing/rtla/src/timerlat_u.c @@ -45,7 +45,7 @@ static int timerlat_u_main(int cpu, struct timerlat_u_params *params) retval = sched_setaffinity(gettid(), sizeof(set), &set); if (retval == -1) { - err_msg("Error setting user thread affinity\n"); + debug_msg("Error setting user thread affinity %d, is the CPU online?\n", cpu); exit(1); } @@ -193,7 +193,9 @@ void *timerlat_u_dispatcher(void *data) procs_count--; } } - break; + + if (!procs_count) + break; } sleep(1);