i2c: Make I2C_ATR invisible

Message ID 588d302477cb7e6b30b52ee6448807324c57b88a.1692113321.git.geert+renesas@glider.be
State New
Headers
Series i2c: Make I2C_ATR invisible |

Commit Message

Geert Uytterhoeven Aug. 15, 2023, 3:29 p.m. UTC
  I2C Address Translator (ATR) support is not a stand-alone driver, but a
library.  All of its users select I2C_ATR.  Hence there is no need for
the user to enable this symbol manually, except when compile-testing.

Fixes: a076a860acae77bb ("media: i2c: add I2C Address Translator (ATR) support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Do we care yet about out-of-tree drivers that need this functionality?
---
 drivers/i2c/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Wolfram Sang Sept. 13, 2023, 8:54 a.m. UTC | #1
On Tue, Aug 15, 2023 at 05:29:11PM +0200, Geert Uytterhoeven wrote:
> I2C Address Translator (ATR) support is not a stand-alone driver, but a
> library.  All of its users select I2C_ATR.  Hence there is no need for
> the user to enable this symbol manually, except when compile-testing.
> 
> Fixes: a076a860acae77bb ("media: i2c: add I2C Address Translator (ATR) support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Fixed checkpatch warning:

WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: a076a860acae ("media: i2c: add I2C Address Translator (ATR) support")'

and applied to for-current, thanks!
  

Patch

diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
index c6d1a345ea6d8aee..9388823bb0bb960c 100644
--- a/drivers/i2c/Kconfig
+++ b/drivers/i2c/Kconfig
@@ -72,7 +72,7 @@  config I2C_MUX
 source "drivers/i2c/muxes/Kconfig"
 
 config I2C_ATR
-	tristate "I2C Address Translator (ATR) support"
+	tristate "I2C Address Translator (ATR) support" if COMPILE_TEST
 	help
 	  Enable support for I2C Address Translator (ATR) chips.