ACPI: thermal: Adjust critical.flags.valid check

Message ID 5883789.lOV4Wx5bFT@kreacher
State New
Headers
Series ACPI: thermal: Adjust critical.flags.valid check |

Commit Message

Rafael J. Wysocki Dec. 5, 2022, 6:56 p.m. UTC
  From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

It is not necessary to compare critical.flags.valid to 1 in
acpi_thermal_trips_update() and doing so is also inconsistent with
other similar checks in that code, so simply check if the flag is
not 0 instead.

No expected functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/thermal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Patch

Index: linux-pm/drivers/acpi/thermal.c
===================================================================
--- linux-pm.orig/drivers/acpi/thermal.c
+++ linux-pm/drivers/acpi/thermal.c
@@ -291,7 +291,7 @@  static int acpi_thermal_trips_update(str
 					  "Found critical threshold [%lu]\n",
 					  tz->trips.critical.temperature);
 		}
-		if (tz->trips.critical.flags.valid == 1) {
+		if (tz->trips.critical.flags.valid) {
 			if (crt == -1) {
 				tz->trips.critical.flags.valid = 0;
 			} else if (crt > 0) {