Message ID | 54c16281234d057ebed1ef05bde20d2d57d70669.1676987821.git.drv@mailo.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp36757wrd; Tue, 21 Feb 2023 06:25:18 -0800 (PST) X-Google-Smtp-Source: AK7set+lOmvu5NGxpg83WnCMkMo1EGY0t9cmCLDz9SnJ1qQJdL3tCz3Y6NCRlyddaBFNupWM3A/Z X-Received: by 2002:a05:6a20:840d:b0:c7:717f:4863 with SMTP id c13-20020a056a20840d00b000c7717f4863mr5479017pzd.21.1676989518317; Tue, 21 Feb 2023 06:25:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676989518; cv=none; d=google.com; s=arc-20160816; b=ISu1ZDh3O3mIIIUW2/YYWSOxcowyZBvjfSU1HfvCHe8NRO9H8RvYUOzfHZfAYrxqmh VjO/KDt3/rHu1QLGj8hQgh8Vsq6zBObaUNvd2x7O8tcZYT6XHcjMy7RRuXz2JLXRM91Z HCImWnzFyYMX6/hlisCwL4VTXN7DKbTEUJi1qFgStH0WkqJKAxZbdT9XhFhgBaCOBOu6 iguCMBSzWqF2VDSx1CWbNU59qQ7P4FD4JZy3hAZ2SrUQINujLcQrXFJyXFsUh3NWKzNh p7FRGU5FkPxIrByK6powMVey45OfmAvmjCBYcNTMv6+EeAVqKXjCuUFqIF/3pGBEs5YS Jx6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=19VRzcXsM0miFVLsrMxq099FYLBUt7DF1wd1649/hrM=; b=BjGfL0whZFcl5OaNCR2QGJARtwIVymsVTf5DTfn0ej3PDK481XyZCGyEYrNmLN9WVA JJ/mXcNgpClNbsFCgDD3cLp5k2H1cFgKkDTZnX87rh5K/31Fzp8pukeI1Ejvr2JWUC4n Vtnr5fh/CMe/kCW8eyPmt2JydLVgcZU/NA3dwauHxltBLhMwVW4kKb8p/Df88pD410Ec F79t+u47wPrfI6NzBCQ6nYyw1MQSe7FeP/VFz203RooPGD9ewgkR64b3A4+OC57U0mbt Nw5SEJ5aUiRlICpZl7LtaTzNk/AkkQ6B757B69Wg9BGsBTF5jEq1zOCIc8pXDIDIgReJ Pe0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b="ct/HGOoS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u190-20020a6279c7000000b005cd3a233e3asi2567556pfc.346.2023.02.21.06.25.04; Tue, 21 Feb 2023 06:25:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b="ct/HGOoS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234045AbjBUOIM (ORCPT <rfc822;kloczko.tomasz@gmail.com> + 99 others); Tue, 21 Feb 2023 09:08:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233656AbjBUOII (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 21 Feb 2023 09:08:08 -0500 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94CC82A99A; Tue, 21 Feb 2023 06:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1676988418; bh=oLZwRpXxfR8jKepCYgBAd0gcxoO2D6bBAKStsCYFVz8=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=ct/HGOoSPl2yfAJdpTmfbCK4kQ8qIvxaKs0L4O54Kib0xMGCCh0W34MpMfkFTJl8j VOcr/oyOReG12/EEQ5gUPB3DGFW3K01KcX6ECXSJqTVFA0yZHWook5MYdkKBMhrspq rPqb2ddx9urUVC9k78cNNCT253DHeqi8pEPTluaQ= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via ip-206.mailobj.net [213.182.55.206] Tue, 21 Feb 2023 15:06:58 +0100 (CET) X-EA-Auth: at9OF3ziCtOVa+pv6TzsuxHGTTSacIrTPKQNDcL9n3nWoXnaOhWUsf84g1TEAEzf2IJx/eMLezJ3x9Jg2DvqQbGUPd6TRiTO Date: Tue, 21 Feb 2023 19:36:52 +0530 From: Deepak R Varma <drv@mailo.com> To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar <ssengar@microsoft.com>, Praveen Kumar <kumarpraveen@linux.microsoft.com>, Deepak R Varma <drv@mailo.com> Subject: [PATCH v2 2/3] perf/x86/intel/pt: Use sysfs_emit() in show() callback function Message-ID: <54c16281234d057ebed1ef05bde20d2d57d70669.1676987821.git.drv@mailo.com> References: <cover.1676987821.git.drv@mailo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <cover.1676987821.git.drv@mailo.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758450960867720394?= X-GMAIL-MSGID: =?utf-8?q?1758450960867720394?= |
Series |
perf/x86: Use sysfs_emit() in show() callback function
|
|
Commit Message
Deepak R Varma
Feb. 21, 2023, 2:06 p.m. UTC
As per C99 standard, snprintf() returns the number of bytes that would
be encoded in the destination buffer when it is sufficiently large. This
return value may be different from what the caller is expecting and hence
may lead to potential errors in the program.
Kernel release 2.6.2 introduced scnprintf() & vscnprintf() which precisely
return the actual bytes encoded into the destination buffer.
For the sysfs attribute show() callback functions, which returns the number
of bytes to the user space, a more recent recommendation is to use
sysfs_emit() or sysfs_emit_at() instead of sprintf() family of functions.
This is recorded in the Documentation/filesystems/sysfs.rst Kernel
documentation file.
Issue identified using the coccinelle device_attr_show.cocci script.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
Changes in v2:
- Revise patch log message to include details on the potential issues with
current implementation and how the proposal is a better solution.
Feedback provided by Peter Zijlstra <peterz@infradead.org>
arch/x86/events/intel/pt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/intel/pt.c b/arch/x86/events/intel/pt.c index 42a55794004a..d9e6d771b458 100644 --- a/arch/x86/events/intel/pt.c +++ b/arch/x86/events/intel/pt.c @@ -96,7 +96,7 @@ static ssize_t pt_cap_show(struct device *cdev, container_of(attr, struct dev_ext_attribute, attr); enum pt_capabilities cap = (long)ea->var; - return snprintf(buf, PAGE_SIZE, "%x\n", intel_pt_validate_hw_cap(cap)); + return sysfs_emit(buf, "%x\n", intel_pt_validate_hw_cap(cap)); } static struct attribute_group pt_cap_group __ro_after_init = {