From patchwork Wed Mar 15 20:59:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Reinette Chatre X-Patchwork-Id: 70442 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp125949wrt; Wed, 15 Mar 2023 14:11:19 -0700 (PDT) X-Google-Smtp-Source: AK7set8Ovgva3xpumz0N6u7zq+cTYN1Q5Fa2sr3JzY+4qoh6/EV2fMW52CBAJaK/U5pCq5EFWVkw X-Received: by 2002:a05:6a20:699a:b0:cd:71de:e757 with SMTP id t26-20020a056a20699a00b000cd71dee757mr1525071pzk.32.1678914679689; Wed, 15 Mar 2023 14:11:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678914679; cv=none; d=google.com; s=arc-20160816; b=lXmbD2WxfdZhdKyzJd31BvrafZq6x1mJEkbdyQIWDvm348miZeetLIqDp/DzrTe6lO 7ZfEdkeUU390BYZ2ET+sUSwJRWQNgYW3SI4xZiHSKMYsGnD9XyrT+gQYi9joIdCO6dLv gkke9t4qAl4L+U8Q5MEUq3Q5PXw2F6GS5IuFsuTzqEligihdeOECwkuTDJPWcpE6YN0J /GCwpUxYK7Ya4iA5viQDxantedFQi46Iqg3QDL9dStlNBwiPc/3x7/enOGEYzgdCK+nt pjNKVvpkt512qwV6SUZzS69BoJCXsqadrPfTXef1Jkg45s2RjjGuc+o5PxmYGxp7K0T/ 1BnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0YW/W512RTtxPSBcQKJqJ1vZo15y6GVmzC9judIYRsc=; b=iZR6G9wE6r2X6jPiCJ3jubj3xucy0K9ccyNOk7qplyUcg3LoMFeSIw+ZscqeI8EYw0 kY5Q6FJ5A7RPpLwF0VXua1YnfislQklX6fOvs9ZKgqR63sDl6wPNtv0Ma9NmqRCvO94w dqBPrMzgkt9/rz5O9bEsz9BSrFAGa7vhj9ee+quxFxh1wHroSd6LT/S7dxkxqoL/l1YX na8hEHUPwGBK3vN0VGT1b8s2cKbvXSutYx/lfCG17eF1aeDJdlyJolCWpCAtHaZm30gV CjvhCYM8W8Wh27VvTNO8M+jzlotEXrBWwoEevkQQJ9ViDh6zcKNAKRCZs5UF4JIGVtGg NCYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=B2Mj7uSS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x189-20020a6386c6000000b0050bde92f3a3si2222084pgd.283.2023.03.15.14.11.02; Wed, 15 Mar 2023 14:11:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=B2Mj7uSS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232848AbjCOVAQ (ORCPT + 99 others); Wed, 15 Mar 2023 17:00:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232648AbjCOU7s (ORCPT ); Wed, 15 Mar 2023 16:59:48 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAA5E8C97A; Wed, 15 Mar 2023 13:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678913985; x=1710449985; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7B1A/cTDYcTxTgWo5idyY91azCfGJIiJsYGrC8xzLuY=; b=B2Mj7uSSnLuerG/uJoRvgVyLqqQr8Nn27VGpFolzk18MaboTDG16YFDa dYvgIh/OUHfe66UJigazxjPumsipXCihsJVW8d5GJEMqK/M30i/LsEsjh aNZrWAx/z4KJuWH6qdycTf8juXCD+YJFB6g3OUba7F/BHu6vTzsJkqy8f euWWu8Izuo8FT2onugR5oyWQJuWkoPKAuF1a+T9UTCwhplDrICwD2XFmg 41oZp+mfSQNpMVhzoWntQpBHBh0CudsEjLh0eEK2ytT3SiLPpWayivrZy hnpSR7rwyXoOxMeTOwsP4SbPRnI11vRpvlPT20v/6Cv8xeck7egomVhzW g==; X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="326176540" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="326176540" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 13:59:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="853747235" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="853747235" Received: from rchatre-ws.ostc.intel.com ([10.54.69.144]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 13:59:39 -0700 From: Reinette Chatre To: jgg@nvidia.com, yishaih@nvidia.com, shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com, alex.williamson@redhat.com Cc: tglx@linutronix.de, darwi@linutronix.de, kvm@vger.kernel.org, dave.jiang@intel.com, jing2.liu@intel.com, ashok.raj@intel.com, fenghua.yu@intel.com, tom.zanussi@linux.intel.com, reinette.chatre@intel.com, linux-kernel@vger.kernel.org Subject: [RFC PATCH 8/8] vfio/pci: Clear VFIO_IRQ_INFO_NORESIZE for MSI-X Date: Wed, 15 Mar 2023 13:59:28 -0700 Message-Id: <549e6300c0ea011cdce9a2712d49de4efd3a06b7.1678911529.git.reinette.chatre@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760469639125399485?= X-GMAIL-MSGID: =?utf-8?q?1760469639125399485?= Dynamic MSI-X is supported. Clear VFIO_IRQ_INFO_NORESIZE to provide guidance to user space. Signed-off-by: Reinette Chatre --- drivers/vfio/pci/vfio_pci_core.c | 2 +- include/uapi/linux/vfio.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c index ae0e161c7fc9..1d071ee212a7 100644 --- a/drivers/vfio/pci/vfio_pci_core.c +++ b/drivers/vfio/pci/vfio_pci_core.c @@ -1111,7 +1111,7 @@ static int vfio_pci_ioctl_get_irq_info(struct vfio_pci_core_device *vdev, if (info.index == VFIO_PCI_INTX_IRQ_INDEX) info.flags |= (VFIO_IRQ_INFO_MASKABLE | VFIO_IRQ_INFO_AUTOMASKED); - else + else if (info.index != VFIO_PCI_MSIX_IRQ_INDEX) info.flags |= VFIO_IRQ_INFO_NORESIZE; return copy_to_user(arg, &info, minsz) ? -EFAULT : 0; diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h index 0552e8dcf0cb..1a36134cae5c 100644 --- a/include/uapi/linux/vfio.h +++ b/include/uapi/linux/vfio.h @@ -511,6 +511,9 @@ struct vfio_region_info_cap_nvlink2_lnkspd { * then add and unmask vectors, it's up to userspace to make the decision * whether to allocate the maximum supported number of vectors or tear * down setup and incrementally increase the vectors as each is enabled. + * Absence of the NORESIZE flag indicates that vectors can be enabled + * and disabled dynamically without impacting other vectors within the + * index. */ struct vfio_irq_info { __u32 argsz;