From patchwork Tue Aug 1 12:03:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 129321 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2692155vqg; Tue, 1 Aug 2023 07:06:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlHDOQc0YrDcine2l4DXET5H8HWGHT0+HEqfIQ9DFbpWTwSKkpJTFVKScplBcLxY39OFBxwg X-Received: by 2002:a05:6512:281c:b0:4fb:7559:aea3 with SMTP id cf28-20020a056512281c00b004fb7559aea3mr2601106lfb.39.1690898769800; Tue, 01 Aug 2023 07:06:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690898769; cv=none; d=google.com; s=arc-20160816; b=O2IqJXNMt4pUYvJc3WVG4+f++JJVFsp9e31OrRJpsu6xkHfWs0w0iItD0mDUhOPZJq MkQ7vdRtieiM5E0HRS2v9Y12+7Dvt6OO210NN950PuVVtaK0UyIvSJ+Co1t4FnUYCarL eT9x+I83q6s9rskCdZiOvy0nEUBfwImXK+yozAnmkVw0UgcHcIwiQj2FC0V7shIoRpZN AwaOUpGO2jmk6k5LZ8eZPpYLkCoNQ/036rjufAJPPOspyXvO2gx7a97VTqXDAZTUEkny cH7+iYoRgufS677gu2EOcCN9ifeUdpmfotHCQPtD5YfJOAhWeJ9clOAqjpldBzw4z5A3 RHww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aE2psrYzSQU8So7H2lqtVFtbvK/aQHA4jm0AH9xBQUo=; fh=0/rNyOK8O3sGi9zt50kSBfR+qAilZF/CyDEU5Llxodw=; b=v7emEeBGt86nNaDcDbZc00KZ3vivfF0KMg742jV16nJF6zXFQ1VnFlQi68cYdYLgso ZbQEKVs1iVxTyhfnWaBYmLGJVnjGEhhJisxwDOFLSckIf6BxlcNjSkrggwQLttv+Dp5r 6n8oMdddIw8RocRx2KjA2fFc8FO4CaChZxvvXCD/eSvGZNWEsbzqluyOHkDPHsoQ3T5w GFjrRD6GuBTLdmhFMwhvea1GRG+1QtcaC1IodbZYtBlkaNxsbQULlKQf8Srijw7dHre8 efboQn/OZCi/tdbxctMJgC6k5gMGXoEXuR74CgYyYmbJnK56ZhYns4PLxgpLYJkl1wBc QYxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Kt2466pE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id se9-20020a170906ce4900b0098871664f55si9008219ejb.800.2023.08.01.07.05.44; Tue, 01 Aug 2023 07:06:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Kt2466pE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234484AbjHAMES (ORCPT + 99 others); Tue, 1 Aug 2023 08:04:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbjHAMD5 (ORCPT ); Tue, 1 Aug 2023 08:03:57 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EB221990; Tue, 1 Aug 2023 05:03:56 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4fe0c566788so9199398e87.0; Tue, 01 Aug 2023 05:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690891435; x=1691496235; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aE2psrYzSQU8So7H2lqtVFtbvK/aQHA4jm0AH9xBQUo=; b=Kt2466pEvz8QaUHjluSm/1dxuyp5VUaPGYzBbsiHrWYAi28e53FJAF2TG6wXZjkoRq 4K3o/fh0Ey5kPHKhL83Qgt+m1uJ3DigTwKl4ZtFQv8D2Fw+OzaF6FNbFQwjvw1ARdSII Qre33ysDCX60hrAa80VBLKIUGbdDo+uGWUnw5/ff4fpn/P5pcE1yzA4DFl5O7MedHNFQ c1vEj04FMU/DDpJmuS6vmT1GDdc2LyKc4r6tvsy6ioK83tVpwJ4V6hbKT36OKP4Il5BF towKWW6NwstJ9TTE7D2IZPQyIGxhaqh3AGE/G3G1myGVKCBsZfMIu6Kwq5+qEQOY8IDx qJPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690891435; x=1691496235; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aE2psrYzSQU8So7H2lqtVFtbvK/aQHA4jm0AH9xBQUo=; b=PQvcKgGgmwkARU0g8KUQZNpdQAkDtdWm2lBK+yG0Nd39F0J4u/oS7DwRqMrWtRYDFw egMF82wpeSps7gYcAWNeCmw3os8ReUDD7wnXbUqfGtL1ApA2AvOxkxCG42bjoLarVcSA JotjkamadjYhi5NA8iwNKFEps284vewq1w2slEk8cs9NQh+OtIo3Z0Yi4P6HegkI99LG tsyw1G8oRK25h8HH3nZET8zeeOmpdORGbzRpW+m7rzUp0UHBhKLZE0L6FqT0vbZGtPQ2 EHPkvcllhZM+wWULeAW/DuvjgruyJ83ERmGzcT/2/qgDQXFE/Q+iZkUzlpWIfmkSwLih ClWw== X-Gm-Message-State: ABy/qLZSTl1Pcy1guhwqykWGJIta82ToDlDil/xTNd8cXH//DiMN2XGX HeWGSIyab1LoLRlNr4A5raqdywzkIe4= X-Received: by 2002:a19:7b12:0:b0:4fe:958:88ac with SMTP id w18-20020a197b12000000b004fe095888acmr2062862lfc.6.1690891434702; Tue, 01 Aug 2023 05:03:54 -0700 (PDT) Received: from fedora ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id b21-20020ac25635000000b004fe0ec5596bsm2542136lff.54.2023.08.01.05.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 05:03:54 -0700 (PDT) Date: Tue, 1 Aug 2023 15:03:50 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 5/8] pinctrl: pistachio: relax return value check for IRQ get Message-ID: <5077c4df68da920ab1119d6332878d0d31dc6d1b.1690890774.git.mazziesaccount@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773035868429550447 X-GMAIL-MSGID: 1773035868429550447 fwnode_irq_get[_byname]() were changed to not return 0 anymore. Drop check for return value 0. Signed-off-by: Matti Vaittinen Acked-by: Linus Walleij Reviewed-by: Jonathan Cameron --- Revision history: - No changes Please note, I took Linus' reply to v4 cover-letter as ack && added the tag. Please let me know if this was not Ok. The patch changing the fwnode_irq_get() got merged during 5.4: https://lore.kernel.org/all/fb7241d3-d1d1-1c37-919b-488d6d007484@gmail.com/ This is a clean-up as agreed. --- drivers/pinctrl/pinctrl-pistachio.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c index 53408344927a..8c50e0091b32 100644 --- a/drivers/pinctrl/pinctrl-pistachio.c +++ b/drivers/pinctrl/pinctrl-pistachio.c @@ -1393,12 +1393,6 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) dev_err(pctl->dev, "Failed to retrieve IRQ for bank %u\n", i); goto err; } - if (!ret) { - fwnode_handle_put(child); - dev_err(pctl->dev, "No IRQ for bank %u\n", i); - ret = -EINVAL; - goto err; - } irq = ret; bank = &pctl->gpio_banks[i];